BUGFIX: WPF0092 allow RoutedEventHandler

Author: JohanLarsson

WpfAnalyzers.Test/WPF0092RegisterClassHandlerDelegateType/Valid.cs

@@ -37,8 +37,11 @@ static void OnPasswordChanged(object sender, RoutedEventArgs e)
     }
 
     [TestCase("new KeyEventHandler(OnKeyDown)")]
+    [TestCase("new RoutedEventHandler(On)")]
     [TestCase("new KeyEventHandler((sender, e) => { })")]
+    [TestCase("new RoutedEventHandler((sender, e) => { })")]
     [TestCase("new KeyEventHandler((sender, e) => OnKeyDown(sender, e))")]
+    [TestCase("new RoutedEventHandler((sender, e) => On(sender, e))")]
     public static void RegisterClassHandlerKeyDownEvent(string expression)
     {
         var code = @"
@@ -50,17 +53,21 @@ namespace N;
 
 public static class C
 {
+#pragma warning disable CS8321, WPF0090
     static C()
     {
         EventManager.RegisterClassHandler(
             typeof(TextBox),
             TextBox.KeyDownEvent,
             new KeyEventHandler(OnKeyDown));
 
-#pragma warning disable CS8321
         static void OnKeyDown(object sender, KeyEventArgs e)
         {
         }
+
+        static void On(object sender, RoutedEventArgs e)
+        {
+        }
     }
 }".AssertReplace("new KeyEventHandler(OnKeyDown)", expression);
         RoslynAssert.Valid(Analyzer, code);

WpfAnalyzers/Analyzers/RoutedEventCallbackAnalyzer.cs

@@ -142,7 +142,8 @@ private static void Handle(SyntaxNodeAnalysisContext context)
                     routedSymbol.Name.EndsWith("Event", StringComparison.Ordinal) &&
                     routedSymbol.ContainingType.TryFindEvent(routedSymbol.Name.Substring(0, routedSymbol.Name.Length - 5), out var accessor) &&
                     context.SemanticModel.GetType(callbackArg.Expression, context.CancellationToken) is { } actualType &&
-                    !TypeSymbolComparer.Equal(actualType, accessor.Type))
+                    !TypeSymbolComparer.Equal(actualType, accessor.Type) &&
+                    actualType != KnownSymbols.RoutedEventHandler)
                 {
                     return ImmutableDictionary<string, string?>.Empty.Add(nameof(ITypeSymbol), accessor.Type.MetadataName);
                 }

WpfAnalyzers/Helpers/KnownSymbols/KnownSymbols.cs

@@ -21,6 +21,7 @@ internal static class KnownSymbols
     internal static readonly QualifiedType FrameworkPropertyMetadata = Create("System.Windows.FrameworkPropertyMetadata");
     internal static readonly QualifiedType DependencyPropertyChangedEventArgs = Create("System.Windows.DependencyPropertyChangedEventArgs");
     internal static readonly QualifiedType RoutedEvent = Create("System.Windows.RoutedEvent");
+    internal static readonly QualifiedType RoutedEventHandler = Create("System.Windows.RoutedEventHandler");
     internal static readonly QualifiedType Style = Create("System.Windows.Style");
     internal static readonly QualifiedType TemplatePartAttribute = Create("System.Windows.TemplatePartAttribute");
     internal static readonly QualifiedType AttachedPropertyBrowsableForTypeAttribute = Create("System.Windows.AttachedPropertyBrowsableForTypeAttribute");