Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit 08fbe87

Browse files
Allow using the front camera in ML Kit streaming views #705
1 parent c95b444 commit 08fbe87

2 files changed

Lines changed: 13 additions & 12 deletions

File tree

src/mlkit/barcodescanning/barcodescanning-common.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,6 @@ export const formatsProperty = new Property<MLKitBarcodeScanner, string>({
2525
defaultValue: null,
2626
});
2727

28-
export const preferFrontCameraProperty = new Property<MLKitBarcodeScanner, boolean>({
29-
name: "preferFrontCamera",
30-
defaultValue: false,
31-
valueConverter: booleanConverter
32-
});
33-
3428
export const beepOnScanProperty = new Property<MLKitBarcodeScanner, boolean>({
3529
name: "beepOnScan",
3630
defaultValue: true,
@@ -45,18 +39,13 @@ export const reportDuplicatesProperty = new Property<MLKitBarcodeScanner, boolea
4539

4640
export abstract class MLKitBarcodeScanner extends MLKitCameraView {
4741
protected formats: string;
48-
protected preferFrontCamera: boolean;
4942
protected beepOnScan: boolean;
5043
protected reportDuplicates: boolean;
5144

5245
[formatsProperty.setNative](value: string) {
5346
this.formats = value;
5447
}
5548

56-
[preferFrontCameraProperty.setNative](value: boolean) {
57-
this.preferFrontCamera = value;
58-
}
59-
6049
[beepOnScanProperty.setNative](value: boolean) {
6150
this.beepOnScan = value;
6251
}
@@ -67,6 +56,5 @@ export abstract class MLKitBarcodeScanner extends MLKitCameraView {
6756
}
6857

6958
formatsProperty.register(MLKitBarcodeScanner);
70-
preferFrontCameraProperty.register(MLKitBarcodeScanner);
7159
beepOnScanProperty.register(MLKitBarcodeScanner);
7260
reportDuplicatesProperty.register(MLKitBarcodeScanner);
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,34 @@
11
import { ContentView } from "tns-core-modules/ui/content-view";
22
import { Property } from "tns-core-modules/ui/core/properties";
3+
import { booleanConverter } from "tns-core-modules/ui/core/view-base";
34

45
export const processEveryNthFrameProperty = new Property<MLKitCameraView, number>({
56
name: "processEveryNthFrame",
67
defaultValue: 10,
78
});
89

10+
export const preferFrontCameraProperty = new Property<MLKitCameraView, boolean>({
11+
name: "preferFrontCamera",
12+
defaultValue: false,
13+
valueConverter: booleanConverter
14+
});
15+
916
export abstract class MLKitCameraView extends ContentView {
1017
static scanResultEvent: string = "scanResult";
1118

1219
protected lastVisionImage;
1320

1421
protected processEveryNthFrame: number;
22+
protected preferFrontCamera: boolean;
1523

1624
[processEveryNthFrameProperty.setNative](value: number) {
1725
this.processEveryNthFrame = value;
1826
}
27+
28+
[preferFrontCameraProperty.setNative](value: boolean) {
29+
this.preferFrontCamera = value;
30+
}
1931
}
2032

2133
processEveryNthFrameProperty.register(MLKitCameraView);
34+
preferFrontCameraProperty.register(MLKitCameraView);

0 commit comments

Comments
 (0)