Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit 11be190

Browse files
committed
Feat: use custom TNSCrashlyticsLogger framework
#1134
1 parent 55eb5f8 commit 11be190

5 files changed

Lines changed: 26 additions & 5 deletions

File tree

src/crashlytics/crashlytics.android.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,13 @@ export function sendCrashLog(exception: any /* java.lang.Exception */): void {
66
}
77
}
88

9-
export function log(priority: number, tag: string, msg: string): void {
9+
export function log(msg: string, tag?: string, priority?: number): void {
1010
if (isCrashlyticsAvailable()) {
11-
com.crashlytics.android.Crashlytics.log(priority, tag, msg);
11+
if (tag && priority) {
12+
com.crashlytics.android.Crashlytics.log(priority, tag, msg);
13+
} else {
14+
com.crashlytics.android.Crashlytics.log(msg);
15+
}
1216
}
1317
}
1418

src/crashlytics/crashlytics.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55
export declare function sendCrashLog(exception: any): void;
66

7-
export declare function log(priority: number, tag: string, msg: string): void;
7+
export declare function log(msg: string, tag?: string, priority?: number): void;
88

99
export declare function setString(key: string, value: string): void;
1010

src/crashlytics/crashlytics.ios.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,13 @@ export function sendCrashLog(exception: any /* NSError */): void {
44
}
55
}
66

7-
export function log(priority: number, tag: string, msg: string): void {
7+
export function log(msg: string, tag?: string, priority?: number): void {
88
if (isCrashlyticsAvailable()) {
9-
Crashlytics.sharedInstance().logEvent(tag + " - " + msg);
9+
if (tag) {
10+
TNSCrashlyticsLoggerWrapper.log(tag + " - " + msg);
11+
} else {
12+
TNSCrashlyticsLoggerWrapper.log(msg);
13+
}
1014
}
1115
}
1216

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
declare var TNSCrashlyticsLoggerVersionNumber: number;
2+
3+
declare var TNSCrashlyticsLoggerVersionString: interop.Reference<number>;
4+
5+
declare class TNSCrashlyticsLoggerWrapper extends NSObject {
6+
7+
static alloc(): TNSCrashlyticsLoggerWrapper; // inherited from NSObject
8+
9+
static new(): TNSCrashlyticsLoggerWrapper; // inherited from NSObject
10+
11+
static log(string: string): void;
12+
}

src/references.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
/// <reference path="./platforms/ios/typings/objc!GoogleSignIn.d.ts" />
2424

2525
/// <reference path="./platforms/ios/typings/objc!TNSMLKitCamera.d.ts" />
26+
/// <reference path="./platforms/ios/typings/objc!TNSCrashlyticsLogger.d.ts" />
2627

2728
/// <reference path="./platforms/android/typings/nativescript-android-lib/android.d.ts" />
2829
//

0 commit comments

Comments
 (0)