arrayUnion with objects produces null values #1138

Author: EddyVerbruggen

demo-ng/app/tabs/firestore/firestore.component.ts

@@ -238,8 +238,12 @@ export class FirestoreComponent {
           fieldToDelete: firestore.FieldValue.delete(),
           updateTs: firebase.firestore().FieldValue().serverTimestamp(),
           // just fyi - both of these work:
-          colors: firestore.FieldValue.arrayUnion("red", "blue")
-          // colors: firebase.firestore().FieldValue().arrayUnion(["red", "blue"])
+          colors: firestore.FieldValue.arrayUnion("red", "blue"),
+          messages: firebase.firestore().FieldValue().arrayUnion({
+            message: "Test 1",
+            source: "central",
+            time: Date.now()
+          })
         })
         .then(() => console.log("Woofie updated from 'arrayUnion'"))
         .catch(err => console.log("Updating Woofie from 'arrayUnion' failed, error: " + JSON.stringify(err)));

src/firebase.android.ts

@@ -127,7 +127,9 @@ firebase.toHashMap = obj => {
           const fieldValue: FieldValue = obj[property];
           if (fieldValue.type === "ARRAY_UNION") {
             // nested arrays are not allowed, so harden against wrong usage: arrayUnion(["foo", "bar"]) vs arrayUnion("foo", "bar")
-            node.put(property, com.google.firebase.firestore.FieldValue.arrayUnion(Array.isArray(fieldValue.value[0]) ? fieldValue.value[0] : fieldValue.value));
+            let values: Array<any> = Array.isArray(fieldValue.value[0]) ? fieldValue.value[0] : fieldValue.value;
+            values = values.map(v => typeof(v) === "object" ? firebase.toHashMap(v) : v);
+            node.put(property, com.google.firebase.firestore.FieldValue.arrayUnion(values));
           } else if (fieldValue.type === "ARRAY_REMOVE") {
             node.put(property, com.google.firebase.firestore.FieldValue.arrayRemove(Array.isArray(fieldValue.value[0]) ? fieldValue.value[0] : fieldValue.value));
           } else {