Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit 22da104

Browse files
[Feature request] Ability to use array-contains in .where query (in API since July 19, 2018) #830
1 parent d4acb68 commit 22da104

3 files changed

Lines changed: 5 additions & 1 deletion

File tree

src/firebase.android.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2490,6 +2490,8 @@ firebase.firestore.where = (collectionPath: string, fieldPath: string, opStr: fi
24902490
query = query.whereGreaterThanOrEqualTo(fieldPath, firebase.toValue(value));
24912491
} else if (opStr === ">") {
24922492
query = query.whereGreaterThan(fieldPath, firebase.toValue(value));
2493+
} else if (opStr === "array-contains") {
2494+
// TODO
24932495
} else {
24942496
console.log("Illegal argument for opStr: " + opStr);
24952497
return null;

src/firebase.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -698,7 +698,7 @@ export namespace dynamicLinks {
698698

699699
export namespace firestore {
700700
export type DocumentData = { [field: string]: any };
701-
export type WhereFilterOp = '<' | '<=' | '==' | '>=' | '>';
701+
export type WhereFilterOp = '<' | '<=' | '==' | '>=' | '>' | 'array-contains';
702702
export type OrderByDirection = 'desc' | 'asc';
703703

704704
export interface GeoPoint {

src/firebase.ios.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2462,6 +2462,8 @@ firebase.firestore.where = (collectionPath: string, fieldPath: string, opStr: fi
24622462
query = query.queryWhereFieldIsGreaterThanOrEqualTo(fieldPath, value);
24632463
} else if (opStr === ">") {
24642464
query = query.queryWhereFieldIsGreaterThan(fieldPath, value);
2465+
} else if (opStr === "array-contains") {
2466+
query = query.queryWhereFieldArrayContains(fieldPath, value);
24652467
} else {
24662468
console.log("Illegal argument for opStr: " + opStr);
24672469
return null;

0 commit comments

Comments
 (0)