Merge pull request #1142 from kanclalg/tns-crashlytics-logger-wrapper

Custom TNSCrashlyticsLogger framework for logging custom logs to crashlytics

Author: EddyVerbruggen

demo/app/main-view-model.ts

@@ -1896,7 +1896,7 @@ export class HelloWorldModel extends Observable {
   }
 
   public doLogMessageCrashlytics(): void {
-    firebaseCrashlytics.log(1, "TAG", "Tag message");
+    firebaseCrashlytics.log("Tag message", "TAG", 1);
     if (isAndroid) {
       firebaseCrashlytics.sendCrashLog(new java.lang.Exception("test Exception"));
     } else if (isIOS) {

src/crashlytics/crashlytics.android.ts

@@ -6,9 +6,13 @@ export function sendCrashLog(exception: any /* java.lang.Exception */): void {
   }
 }
 
-export function log(priority: number, tag: string, msg: string): void {
+export function log(msg: string, tag?: string, priority?: number): void {
   if (isCrashlyticsAvailable()) {
-    com.crashlytics.android.Crashlytics.log(priority, tag, msg);
+    if (tag && priority) {
+      com.crashlytics.android.Crashlytics.log(priority, tag, msg);
+    } else {
+      com.crashlytics.android.Crashlytics.log(msg);
+    }
   }
 }
 

src/crashlytics/crashlytics.d.ts

@@ -4,7 +4,7 @@
  */
 export declare function sendCrashLog(exception: any): void;
 
-export declare function log(priority: number, tag: string, msg: string): void;
+export declare function log(msg: string, tag?: string,  priority?: number): void;
 
 export declare function setString(key: string, value: string): void;
 

src/crashlytics/crashlytics.ios.ts

@@ -4,11 +4,13 @@ export function sendCrashLog(exception: any /* NSError */): void {
   }
 }
 
-export function log(priority: number, tag: string, msg: string): void {
+export function log(msg: string, tag?: string, priority?: number): void {
   if (isCrashlyticsAvailable()) {
-    // TODO this seems deprecated, see https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/1134
-    Crashlytics.sharedInstance().logEvent(tag + " - " + msg);
-    // Answers.logCustomEventWithNameCustomAttributes(tag + " - " + msg, null);
+    if (tag) {
+      TNSCrashlyticsLoggerWrapper.log(tag + " - " + msg);
+    } else {
+      TNSCrashlyticsLoggerWrapper.log(msg);
+    }
   }
 }
 

src/platforms/ios/TNSCrashlyticsLogger.framework/Headers/TNSCrashlyticsLogger.h

@@ -0,0 +1,8 @@
+// In this header, you should import all the public headers of your framework
+#import "TNSCrashlyticsLoggerWrapper.h"
+
+//! Project version number for TNSCrashlyticsLogger.
+FOUNDATION_EXPORT double TNSCrashlyticsLoggerVersionNumber;
+
+//! Project version string for TNSCrashlyticsLogger.
+FOUNDATION_EXPORT const unsigned char TNSCrashlyticsLoggerVersionString[];

src/platforms/ios/TNSCrashlyticsLogger.framework/Headers/TNSCrashlyticsLoggerWrapper.h

@@ -0,0 +1,7 @@
+#import <UIKit/UIKit.h>
+
+@interface TNSCrashlyticsLoggerWrapper : NSObject
+
++ (void)log:(NSString*)string;
+
+@end

src/platforms/ios/TNSCrashlyticsLogger.framework/Info.plist

@@ -0,0 +1,6 @@
+framework module TNSCrashlyticsLogger {
+  umbrella header "TNSCrashlyticsLogger.h"
+
+  export *
+  module * { export * }
+}

src/platforms/ios/TNSCrashlyticsLogger.framework/Modules/module.modulemap

@@ -0,0 +1,12 @@
+declare var TNSCrashlyticsLoggerVersionNumber: number;
+
+declare var TNSCrashlyticsLoggerVersionString: interop.Reference<number>;
+
+declare class TNSCrashlyticsLoggerWrapper extends NSObject {
+
+  static alloc(): TNSCrashlyticsLoggerWrapper; // inherited from NSObject
+
+  static new(): TNSCrashlyticsLoggerWrapper; // inherited from NSObject
+
+  static log(string: string): void;
+}