Don't require the 'storageBucket' param for Firebase Storage #842

Author: EddyVerbruggen

demo/app/main-view-model.ts

@@ -58,9 +58,7 @@ export class HelloWorldModel extends Observable {
   }
 
   public doWebInit(): void {
-    firebaseWebApi.initializeApp({
-      storageBucket: 'gs://n-plugin-test.appspot.com',
-    });
+    firebaseWebApi.initializeApp();
   }
 
   public doWebLoginAnonymously(): void {
@@ -390,7 +388,7 @@ export class HelloWorldModel extends Observable {
 
   public doInit(): void {
     firebase.init({
-      storageBucket: 'gs://n-plugin-test.appspot.com',
+      // storageBucket: 'gs://n-plugin-test.appspot.com',
       persist: true, // optional, default false
       onAuthStateChanged: data => { // optional
         console.log((data.loggedIn ? "Logged in to firebase" : "Logged out from firebase") + " (init's onAuthStateChanged callback)");

demo/package.json

@@ -9,7 +9,7 @@
     }
   },
   "dependencies": {
-    "nativescript-plugin-firebase": "file:../publish/package/nativescript-plugin-firebase-6.4.1.tgz",
+    "nativescript-plugin-firebase": "file:../publish/package/nativescript-plugin-firebase-6.5.0.tgz",
     "nativescript-theme-core": "^1.0.4",
     "nativescript-unit-test-runner": "^0.3.4",
     "tns-core-modules": "~4.0.0"
@@ -48,4 +48,4 @@
     "build.plugin": "cd ../src && npm run build",
     "ci.tslint": "npm i && tslint --config '../tslint.json' 'app/**/*.ts' --exclude '**/node_modules/**' --exclude '**/typings/**'"
   }
-}
+}

src/storage/storage.android.ts

@@ -21,7 +21,13 @@ function getStorageRef(reject, arg) {
     return;
   }
 
-  return arg.bucket ? com.google.firebase.storage.FirebaseStorage.getInstance().getReferenceFromUrl(arg.bucket) : firebase.storageBucket;
+  if (arg.bucket) {
+    return com.google.firebase.storage.FirebaseStorage.getInstance().getReferenceFromUrl(arg.bucket);
+  } else if (firebase.storageBucket) {
+    return firebase.storageBucket;
+  } else {
+    return com.google.firebase.storage.FirebaseStorage.getInstance().getReference();
+  }
 }
 
 export function uploadFile(arg: UploadFileOptions): Promise<UploadFileResult> {

src/storage/storage.ios.ts

@@ -18,7 +18,13 @@ function getStorageRef(reject, arg): FIRStorageReference {
     return undefined;
   }
 
-  return arg.bucket ? FIRStorage.storage().referenceForURL(arg.bucket) : firebase.storageBucket;
+  if (arg.bucket) {
+    return FIRStorage.storage().referenceForURL(arg.bucket);
+  } else if (firebase.storageBucket) {
+    return firebase.storageBucket;
+  } else {
+    return FIRStorage.storage().reference();
+  }
 }
 
 export function uploadFile(arg: UploadFileOptions): Promise<UploadFileResult> {