Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit c0dd0c6

Browse files
committed
Added support for numbers for field values
1 parent 6d032c7 commit c0dd0c6

1 file changed

Lines changed: 13 additions & 3 deletions

File tree

src/firebase.android.ts

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2599,12 +2599,22 @@ firebase.firestore.endBefore = (collectionPath: string, snapshotOrFieldValue: Do
25992599
};
26002600

26012601
firebase.firestore._getSnapshotOrFieldValues = (snapshotOrFieldValue: DocumentSnapshot | any, fieldValues: any[]): any => {
2602-
if(snapshotOrFieldValue && snapshotOrFieldValue.android){
2602+
if(snapshotOrFieldValue && snapshotOrFieldValue.android) {
26032603
return snapshotOrFieldValue;
26042604
} else {
26052605
const AllFieldValues = [snapshotOrFieldValue, ...fieldValues];
2606-
const javaArray = Array.create('java.lang.Object',AllFieldValues.length);
2607-
AllFieldValues.forEach((item,index) => javaArray[index] = item);
2606+
const javaArray = Array.create('java.lang.Object', AllFieldValues.length);
2607+
AllFieldValues.forEach((value, index) => {
2608+
// support only Number and String type
2609+
// Not sure whether other types are supported by OrderBy
2610+
let javaValue: java.lang.String | java.lang.Double;
2611+
if (isNaN(value)) {
2612+
javaValue = new java.lang.String(value.toString());
2613+
} else {
2614+
javaValue = new java.lang.Double(value);
2615+
}
2616+
javaArray[index] = javaValue;
2617+
});
26082618
return javaArray;
26092619
}
26102620
}

0 commit comments

Comments
 (0)