ES2015 FTW!

Author: EddyVerbruggen

src/firebase.android.ts

@@ -282,7 +282,7 @@ firebase.toJsObject = javaObj => {
           node[item.getKey()] = firebase.toJsObject(item.getValue());
         }
       } catch (e) {
-        if (JSON.stringify(e).indexOf("Attempt to use cleared object reference") > -1) {
+        if (JSON.stringify(e).includes("Attempt to use cleared object reference")) {
           console.log("Error while transforming Java to Js: " + e);
         } else {
           console.log("PLEASE REPORT THIS AT https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues: Tried to serialize an unsupported type: " + javaObj.getClass().getName() + ", error: " + e);
@@ -983,7 +983,7 @@ firebase.login = arg => {
           onVerificationFailed: firebaseException => {
             firebase._verifyPhoneNumberInProgress = false;
             const errorMessage = firebaseException.getMessage();
-            if (errorMessage.indexOf("INVALID_APP_CREDENTIAL") > -1) {
+            if (errorMessage.includes("INVALID_APP_CREDENTIAL")) {
               this.reject("Please upload the SHA1 fingerprint of your debug and release keystores to the Firebase console, see https://github.com/EddyVerbruggen/nativescript-plugin-firebase/blob/master/docs/AUTHENTICATION.md#phone-verification");
             } else {
               this.reject(errorMessage);

src/mlkit/custommodel/custommodel-common.ts

@@ -48,7 +48,7 @@ export abstract class MLKitCustomModel extends MLKitCameraView {
 
   [labelsFileProperty.setNative](value: string) {
     this.labelsFile = value;
-    if (value.indexOf("~/") === 0) {
+    if (value.startsWith("~/")) {
       this.labels = getLabelsFromAppFolder(value);
     } else {
       // no dice loading from assets yet, let's advice users to use ~/ for now
@@ -91,4 +91,4 @@ export function getLabelsFromFile(labelsFile: string): Array<string> {
     lines.pop();
   }
   return lines;
-}
+}

src/mlkit/custommodel/index.android.ts

@@ -108,7 +108,7 @@ function getInterpreter(localModelFile?: string): any {
     } else {
       const firModelLocalBuilder = new com.google.firebase.ml.common.modeldownload.FirebaseLocalModel.Builder(localModelName);
 
-      if (localModelFile.indexOf("~/") === 0) {
+      if (localModelFile.startsWith("~/")) {
         firModelLocalBuilder.setFilePath(fs.knownFolders.currentApp().path + localModelFile.substring(1));
       } else {
         // note that this doesn't seem to work, let's advice users to use ~/ for now
@@ -143,7 +143,7 @@ export function useCustomModel(options: MLKitCustomModelOptions): Promise<MLKitC
       const interpreter = getInterpreter(options.localModelFile);
 
       let labels: Array<string>;
-      if (options.labelsFile.indexOf("~/") === 0) {
+      if (options.labelsFile.startsWith("~/")) {
         labels = getLabelsFromAppFolder(options.labelsFile);
       } else {
         // no dice loading from assets yet, let's advice users to use ~/ for now

src/mlkit/custommodel/index.ios.ts

@@ -113,7 +113,7 @@ function getInterpreter(localModelFile: string): FIRModelInterpreter {
       localModelRegistrationSuccess = true;
     } else {
       let localModelFilePath: string;
-      if (localModelFile.indexOf("~/") === 0) {
+      if (localModelFile.startsWith("~/")) {
         localModelFilePath = fs.knownFolders.currentApp().path + localModelFile.substring(1);
       } else {
         localModelFilePath = NSBundle.mainBundle.pathForResourceOfType(
@@ -184,7 +184,7 @@ export function useCustomModel(options: MLKitCustomModelOptions): Promise<MLKitC
       });
 
       let labels: Array<string>;
-      if (options.labelsFile.indexOf("~/") === 0) {
+      if (options.labelsFile.startsWith("~/")) {
         labels = getLabelsFromAppFolder(options.labelsFile);
       } else {
         const labelsFile = NSBundle.mainBundle.pathForResourceOfType(