fix(dbmanager): Drop database if you can't connect (sqlc-dev#3525)

kyleconroy · web-flow · commit 20ebc4ce68ab · 2024-08-05T12:32:47.000-07:00
If you create a database but can't connect to it, clean up after yourself
diff --git a/internal/dbmanager/client.go b/internal/dbmanager/client.go
@@ -106,6 +106,7 @@ func (m *ManagedClient) CreateDatabase(ctx context.Context, req *CreateDatabaseR
 
 		conn, err := pgx.Connect(ctx, uri.String())
 		if err != nil {
+			pool.Exec(ctx, fmt.Sprintf(`DROP DATABASE "%s" IF EXISTS WITH (FORCE)`, name))
 			return nil, fmt.Errorf("connect %s: %s", name, err)
 		}
 		defer conn.Close(ctx)

Original file line number	Diff line number	Diff line change
`@@ -106,6 +106,7 @@ func (m ManagedClient) CreateDatabase(ctx context.Context, req CreateDatabaseR`
`106`	`106`
`107`	`107`	`conn, err := pgx.Connect(ctx, uri.String())`
`108`	`108`	`if err != nil {`
	`109`	+ pool.Exec(ctx, fmt.Sprintf(`DROP DATABASE "%s" IF EXISTS WITH (FORCE)`, name))
`109`	`110`	`return nil, fmt.Errorf("connect %s: %s", name, err)`
`110`	`111`	`}`
`111`	`112`	`defer conn.Close(ctx)`