Merge pull request #675 from hanhainebula/master

Fix bugs in step0-generate_embedding.py

Author: staoxiao

C_MTEB/MKQA/dense_retrieval/step0-generate_embedding.py

@@ -5,7 +5,6 @@
 --max_passage_length 512 \
 --batch_size 256 \
 --fp16 \
---add_instruction False \
 --pooling_method cls \
 --normalize_embeddings True
 """
@@ -35,14 +34,6 @@ class ModelArgs:
         default=True,
         metadata={'help': 'Use fp16 in inference?'}
     )
-    add_instruction: bool = field(
-        default=False,
-        metadata={'help': 'Add instruction?'}
-    )
-    passage_instruction_for_retrieval: str = field(
-        default=None,
-        metadata={'help': 'passage instruction for retrieval'}
-    )
     pooling_method: str = field(
         default='cls',
         metadata={'help': "Pooling method. Avaliable methods: 'cls', 'mean'"}
@@ -78,8 +69,6 @@ def get_model(model_args: ModelArgs):
         model_args.encoder, 
         pooling_method=model_args.pooling_method,
         normalize_embeddings=model_args.normalize_embeddings,
-        # query_instruction_for_retrieval=model_args.query_instruction_for_retrieval if model_args.add_instruction else None,
-        passage_instruction_for_retrieval=model_args.passage_instruction_for_retrieval if model_args.add_instruction else None,
         use_fp16=model_args.fp16
     )
     return model

C_MTEB/MLDR/dense_retrieval/step0-generate_embedding.py

@@ -6,7 +6,6 @@
 --max_passage_length 8192 \
 --batch_size 4 \
 --fp16 \
---add_instruction False \
 --pooling_method cls \
 --normalize_embeddings True
 """
@@ -30,14 +29,6 @@ class ModelArgs:
         default=True,
         metadata={'help': 'Use fp16 in inference?'}
     )
-    add_instruction: bool = field(
-        default=False,
-        metadata={'help': 'Add instruction?'}
-    )
-    passage_instruction_for_retrieval: str = field(
-        default=None,
-        metadata={'help': 'passage instruction for retrieval'}
-    )
     pooling_method: str = field(
         default='cls',
         metadata={'help': "Pooling method. Avaliable methods: 'cls', 'mean'"}
@@ -78,8 +69,6 @@ def get_model(model_args: ModelArgs):
         model_args.encoder, 
         pooling_method=model_args.pooling_method,
         normalize_embeddings=model_args.normalize_embeddings,
-        # query_instruction_for_retrieval=model_args.query_instruction_for_retrieval if model_args.add_instruction else None,
-        passage_instruction_for_retrieval=model_args.passage_instruction_for_retrieval if model_args.add_instruction else None,
         use_fp16=model_args.fp16
     )
     return model