Skip to content

Commit 83f02f9

Browse files
committed
Increased timeout waiting for entity creation
1 parent 9291218 commit 83f02f9

3 files changed

Lines changed: 7 additions & 4 deletions

File tree

FROST-Server.Tests/src/test/java/de/fraunhofer/iosb/ilt/statests/f01auth/FineGrainedAuthTests.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import static de.fraunhofer.iosb.ilt.statests.f01auth.SensorThingsUserModel.EP_USERNAME;
2626
import static de.fraunhofer.iosb.ilt.statests.util.EntityUtils.filterForException;
2727
import static de.fraunhofer.iosb.ilt.statests.util.EntityUtils.testFilterResults;
28+
import static de.fraunhofer.iosb.ilt.statests.util.mqtt.MqttHelper2.MQTT_READ_RETRIES;
2829
import static org.junit.jupiter.api.Assertions.assertEquals;
2930
import static org.junit.jupiter.api.Assertions.assertTrue;
3031
import static org.junit.jupiter.api.Assertions.fail;
@@ -795,7 +796,7 @@ public static interface StringCreator {
795796

796797
private static class MqttCreateTester {
797798

798-
private static final int JOIN_TIMEOUT = 5000;
799+
private static final int JOIN_TIMEOUT = 500 + MqttHelper2.MQTT_READ_RETRIES * MqttHelper2.WAIT_AFTER_INSERT;
799800

800801
private final MqttHelper2 mh;
801802
private final EntityHelper2 eh;
@@ -848,7 +849,7 @@ private void executeTest() {
848849
Entity entity = entityCreator.create(name);
849850
String json = JsonWriter.writeEntity(entity);
850851
mh.publish(topic, json);
851-
createdEntity = eh.getEntityWithRetry(et, filterCreator.create(name), null, 15);
852+
createdEntity = eh.getEntityWithRetry(et, filterCreator.create(name), null, MQTT_READ_RETRIES);
852853
if (createdEntity == null && !expectSuccess) {
853854
success = true;
854855
message = "Success";

FROST-Server.Tests/src/test/java/de/fraunhofer/iosb/ilt/statests/util/EntityHelper2.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,7 @@ public Entity getEntityWithRetry(EntityType entityType, String filter, String ex
242242
}
243243
Entity entity = query.first();
244244
if (entity != null) {
245+
LOGGER.info("Found entity of type {} after {} tries with filter {}: {}", entityType, retry, filter, entity);
245246
return entity;
246247
}
247248
retry++;
@@ -259,7 +260,7 @@ public JsonNode getEntityJsonWithRetry(EntityType entityType, String expand, int
259260
public JsonNode getEntityJsonWithRetry(EntityType entityType, String filter, String expand, int retries) {
260261
int retry = 0;
261262
while (retry < retries) {
262-
JsonNode entity = EntityHelper2.this.getEntityJson(entityType, filter, expand);
263+
JsonNode entity = getEntityJson(entityType, filter, expand);
263264
if (entity != null) {
264265
return entity;
265266
}

FROST-Server.Tests/src/test/java/de/fraunhofer/iosb/ilt/statests/util/mqtt/MqttHelper2.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,9 @@
5656
*/
5757
public class MqttHelper2 {
5858

59-
public static final int WAIT_AFTER_INSERT = 100;
59+
public static final int WAIT_AFTER_INSERT = 150;
6060
public static final int WAIT_AFTER_CLEANUP = 1;
61+
public static final int MQTT_READ_RETRIES = 40;
6162
public static final int QOS = 2;
6263
public String clientId = "TS";
6364

0 commit comments

Comments
 (0)