Skip to content

Commit 8efdca0

Browse files
committed
document which server is saving / restoring state
1 parent bbb349b commit 8efdca0

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

src/main/state.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -595,6 +595,8 @@ void fr_state_discard(REQUEST *request, RADIUS_PACKET *original)
595595
entry = fr_state_find(request, state, request->server, original);
596596
if (entry) state_entry_free(state, entry);
597597
PTHREAD_MUTEX_UNLOCK(&state->mutex);
598+
599+
if (entry) RDEBUG2("session-state: Discarding attributes for server %s", request->server);
598600
}
599601

600602
/*
@@ -610,7 +612,7 @@ void fr_state_get_vps(REQUEST *request, RADIUS_PACKET *packet)
610612
* No State, don't do anything.
611613
*/
612614
if (!fr_pair_find_by_num(request->packet->vps, PW_STATE, 0, TAG_ANY)) {
613-
RDEBUG3("session-state: No State attribute");
615+
RDEBUG3("session-state: No State attribute for server %s", request->server);
614616
return;
615617
}
616618

@@ -624,7 +626,7 @@ void fr_state_get_vps(REQUEST *request, RADIUS_PACKET *packet)
624626
* isn't thread-safe.
625627
*/
626628
if (entry) {
627-
RDEBUG2("Restoring &session-state");
629+
RDEBUG2("session-state: Restoring attributes for server %s", request->server);
628630

629631
if (request->state_ctx) old_ctx = request->state_ctx;
630632

@@ -637,7 +639,7 @@ void fr_state_get_vps(REQUEST *request, RADIUS_PACKET *packet)
637639
rdebug_pair_list(L_DBG_LVL_2, request, request->state, "&session-state:");
638640

639641
} else {
640-
RDEBUG2("session-state: No cached attributes");
642+
RDEBUG2("session-state: No cached attributes for server %s", request->server);
641643
}
642644

643645
PTHREAD_MUTEX_UNLOCK(&state->mutex);
@@ -669,7 +671,7 @@ bool fr_state_put_vps(REQUEST *request, RADIUS_PACKET *original, RADIUS_PACKET *
669671
VALUE_PAIR *vp;
670672
uint8_t buffer[16];
671673

672-
RDEBUG3("session-state: Nothing to cache");
674+
RDEBUG3("session-state: Nothing to cache for server %s", request->server);
673675

674676
if (packet->code != PW_CODE_ACCESS_CHALLENGE) return true;
675677

@@ -691,7 +693,7 @@ bool fr_state_put_vps(REQUEST *request, RADIUS_PACKET *original, RADIUS_PACKET *
691693
return true;
692694
}
693695

694-
RDEBUG2("session-state: Saving cached attributes");
696+
RDEBUG2("session-state: Saving cached attributes for server %s", request->server);
695697
rdebug_pair_list(L_DBG_LVL_1, request, request->state, NULL);
696698

697699
PTHREAD_MUTEX_LOCK(&state->mutex);

0 commit comments

Comments
 (0)