Don't use strlen in talloced buffers

arr2036 · arr2036 · commit bc275f17e3a0 · 2025-11-06T17:35:18.000-08:00
diff --git a/src/modules/rlm_rest/rlm_rest.c b/src/modules/rlm_rest/rlm_rest.c
@@ -360,7 +360,7 @@ static int rest_uri_part_escape(fr_value_box_t *vb, UNUSED void *uctx)
 	}
 
 	str = talloc_typed_strdup(vb, escaped);
-	fr_value_box_strdup_shallow_replace(vb, str, strlen(str));
+	fr_value_box_strdup_shallow_replace(vb, str, talloc_strlen(str));
 
 	curl_free(escaped);
 

Original file line number	Diff line number	Diff line change
`@@ -360,7 +360,7 @@ static int rest_uri_part_escape(fr_value_box_t vb, UNUSED void uctx)`
`360`	`360`	`}`
`361`	`361`
`362`	`362`	`str = talloc_typed_strdup(vb, escaped);`
`363`		`- fr_value_box_strdup_shallow_replace(vb, str, strlen(str));`
	`363`	`+ fr_value_box_strdup_shallow_replace(vb, str, talloc_strlen(str));`
`364`	`364`
`365`	`365`	`curl_free(escaped);`
`366`	`366`