Use named parameters for the constraint constructors

Author: stof

src/Form/Type/ChangePasswordFormType.php

@@ -36,12 +36,10 @@ public function __construct($class)
 
     public function buildForm(FormBuilderInterface $builder, array $options): void
     {
-        $constraintsOptions = [
-            'message' => 'fos_user.current_password.invalid',
-        ];
+        $groups = null;
 
         if (!empty($options['validation_groups'])) {
-            $constraintsOptions['groups'] = [reset($options['validation_groups'])];
+            $groups = [reset($options['validation_groups'])];
         }
 
         $builder->add('current_password', PasswordType::class, [
@@ -50,7 +48,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
             'mapped' => false,
             'constraints' => [
                 new NotBlank(),
-                new UserPassword($constraintsOptions),
+                new UserPassword(message: 'fos_user.current_password.invalid', groups: $groups),
             ],
             'attr' => [
                 'autocomplete' => 'current-password',

src/Form/Type/ProfileFormType.php

@@ -38,12 +38,10 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
     {
         $this->buildUserForm($builder, $options);
 
-        $constraintsOptions = [
-            'message' => 'fos_user.current_password.invalid',
-        ];
+        $groups = null;
 
         if (!empty($options['validation_groups'])) {
-            $constraintsOptions['groups'] = [reset($options['validation_groups'])];
+            $groups = [reset($options['validation_groups'])];
         }
 
         $builder->add('current_password', PasswordType::class, [
@@ -52,7 +50,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
             'mapped' => false,
             'constraints' => [
                 new NotBlank(),
-                new UserPassword($constraintsOptions),
+                new UserPassword(message: 'fos_user.current_password.invalid', groups: $groups),
             ],
             'attr' => [
                 'autocomplete' => 'current-password',