bring config into deploy, revert commit

Author: cmhedrickREI

.github/workflows/commit.yml

@@ -114,54 +114,6 @@ jobs:
         if: always()
         run: make down
 
-  lighthouse:
-    runs-on: ubuntu-latest
-    name: Lighthouse CI Audit
-    continue-on-error: true
-    steps:
-      - name: Check out the code
-        uses: actions/checkout@v4
-
-      - name: Set up Node.js
-        uses: actions/setup-node@v4
-        with:
-          node-version: "20"
-
-      - name: Install Lighthouse CI
-        run: npm install -g @lhci/cli
-
-      - name: Collect Lighthouse results
-        run: |
-          lhci collect \
-            --url="https://catalog.data.gov" \
-            --url="https://catalog.data.gov/organization" \
-            --url="https://catalog.data.gov/organization/gsa" \
-            --url="https://catalog.data.gov/dataset/gsa-enterprise-data-inventory-edi" \
-            --numberOfRuns=1
-
-      - name: Upload to filesystem
-        run: |
-          lhci upload \
-            --target=filesystem \
-            --outputDir=./lighthouse-results
-
-      - name: Assert thresholds
-        run: |
-          output=$(lhci assert --config=lighthouserc.yml 2>&1) || {
-            echo "$output" | while IFS= read -r line; do
-              [[ -n "$line" ]] && echo "::error::$line"
-            done
-            exit 1
-          }
-
-      - name: Upload Lighthouse results
-        uses: actions/upload-artifact@v4
-        if: always()
-        with:
-          name: lighthouse-results
-          path: ./lighthouse-results/**/*.html
-          retention-days: 30
-
   deploy-development:
     name: deploy to development space
     if: github.ref == 'refs/heads/develop'

.github/workflows/deploy.yml

@@ -63,6 +63,7 @@ jobs:
     name: Lighthouse CI Audit
     needs: deploy-prod
     runs-on: ubuntu-latest
+    continue-on-error: true
     steps:
       - name: Check out the code
         uses: actions/checkout@v4
@@ -75,21 +76,34 @@ jobs:
       - name: Install Lighthouse CI
         run: npm install -g @lhci/cli
 
-      - name: Run Lighthouse CI
+      - name: Collect Lighthouse results
         run: |
-          lhci autorun \
-            --collect.url="https://catalog.data.gov" \
-            --collect.url="https://catalog.data.gov/organization" \
-            --collect.url="https://catalog.data.gov/organization/gsa" \
-            --collect.url="https://catalog.data.gov/dataset/gsa-enterprise-data-inventory-edi" \
-            --collect.numberOfRuns=1 \
-            --upload.target=filesystem \
-            --upload.outputDir=./lighthouse-results
+          lhci collect \
+            --url="https://catalog.data.gov" \
+            --url="https://catalog.data.gov/organization" \
+            --url="https://catalog.data.gov/organization/gsa" \
+            --url="https://catalog.data.gov/dataset/gsa-enterprise-data-inventory-edi" \
+            --numberOfRuns=1
+
+      - name: Upload to filesystem
+        run: |
+          lhci upload \
+            --target=filesystem \
+            --outputDir=./lighthouse-results
+
+      - name: Assert thresholds
+        run: |
+          output=$(lhci assert --config=lighthouserc.yml 2>&1) || {
+            echo "$output" | while IFS= read -r line; do
+              [[ -n "$line" ]] && echo "::error::$line"
+            done
+            exit 1
+          }
 
       - name: Upload Lighthouse results
         uses: actions/upload-artifact@v4
         if: always()
         with:
           name: lighthouse-results
-          path: ./lighthouse-results
+          path: ./lighthouse-results/**/*.html
           retention-days: 7