Skip to content

Commit 5107c81

Browse files
authored
Remove deploy.zip step of deployment (#3692)
* Remove deploy.zip * Remove from ignore files
1 parent 1a8586a commit 5107c81

4 files changed

Lines changed: 0 additions & 13 deletions

File tree

src/.gcloudignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,5 +43,4 @@ static/pdfs/*
4343
**/.DS_Store
4444
Dockerfile
4545
.dockerignore
46-
deployed.zip
4746
.coverage

src/.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,4 @@ templates/*/rss.xml
88
templates/sitemap.xml
99
static/html/
1010
static/js/web-vitals.js
11-
deployed.zip
1211
.coverage

src/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,6 @@ The deploy script will do the following:
376376
- Ask you to complete any local tests and confirm good to deploy
377377
- Ask for a version number (suggesing the last verision tagged and incrementing the patch)
378378
- Tag the release (after asking you for the version number to use)
379-
- Generate a `deploy.zip` file of what has been deployed
380379
- Deploy to GCP
381380
- Push changes to `production` branch on GitHub
382381
- Switch you back to the `main` branch.

src/tools/scripts/deploy.sh

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -167,15 +167,6 @@ LONG_DATE=$(date -u +%Y-%m-%d\ %H:%M:%S)
167167
git tag -a "${TAG_VERSION}" -m "Version ${TAG_VERSION} ${LONG_DATE}"
168168
echo "Tagged ${TAG_VERSION} with message 'Version ${TAG_VERSION} ${LONG_DATE}'"
169169

170-
if [[ -f deployed.zip ]]; then
171-
echo "Removing old deploy.zip"
172-
rm -f deployed.zip
173-
fi
174-
175-
echo "Zipping artifacts into deploy.zip"
176-
# Exclude chapter images as quite large and tracked in git anyway
177-
zip -q -r deployed . --exclude @.gcloudignore static/images/*/*/* static/pdfs/*
178-
179170
echo "Deploying to GCP"
180171
echo "Y" | gcloud app deploy --project webalmanac --stop-previous-version
181172

@@ -207,7 +198,6 @@ echo -e "${GREEN}Successfully deployed!${RESET_COLOR}"
207198
echo
208199
echo -e "${AMBER}Please update release on GitHub: https://github.com/HTTPArchive/almanac.httparchive.org/releases${RESET_COLOR}"
209200
echo -e "${AMBER}Using tag ${TAG_VERSION}@production${RESET_COLOR}"
210-
echo -e "${AMBER}Please upload deploy.zip as the release artifact${RESET_COLOR}"
211201
echo
212202
echo "Have a good one!"
213203
echo

0 commit comments

Comments
 (0)