Node16 + stages for docker container (#3430)

* linter slim

* dockerfile stages

* revert worspace folder

* node version update

* super-linter readme update

Author: max-ostapenko

.devcontainer/devcontainer.json

@@ -2,9 +2,9 @@
     "name": "Dev Container",
     "build": {
         "dockerfile": "../src/Dockerfile",
-        "context": "../src/",
+        "target": "base",
+        "context": "../",
         "args": {
-            "IS_DEV_CONTAINER": "true",
             "SKIPGC": "false"
         }
     },
@@ -28,5 +28,6 @@
                 "src/README.md"
             ]
         }
-    }
+    },
+    "onCreateCommand": "cd src && pip install -r requirements.txt && npm install"
 }

src/Dockerfile

@@ -1,22 +1,22 @@
 ARG     PYVER=3.8
-FROM    python:${PYVER}
+FROM    python:${PYVER} as base
 
 # Enable unbuffered STDOUT logging
 ENV     PYTHONUNBUFFERED=1
 
-ARG     NODEVER=12.x
+ARG     NODEVER=16.x
 RUN     curl -sL https://deb.nodesource.com/setup_${NODEVER} | bash -
 
-RUN     apt update && apt install -y \
-          nodejs \
-        && rm -rf /var/lib/apt/lists/*
+RUN     apt update && apt install -y nodejs && rm -rf /var/lib/apt/lists/* \
+        && /usr/local/bin/python -m pip install --upgrade pip
 
 # Add Google Cloud SDK only if image is built with `--build-arg SKIPGC=false`
 ARG     SKIPGC=true
 RUN     $SKIPGC || (echo "deb [signed-by=/usr/share/keyrings/cloud.google.gpg] https://packages.cloud.google.com/apt cloud-sdk main" > /etc/apt/sources.list.d/google-cloud-sdk.list \
         && curl -s https://packages.cloud.google.com/apt/doc/apt-key.gpg | apt-key --keyring /usr/share/keyrings/cloud.google.gpg add - \
         && apt update && apt install -y google-cloud-sdk && rm -rf /var/lib/apt/lists/*)
 
+FROM base
 WORKDIR /app
 COPY    requirements.txt package*.json ./
 RUN     pip install -r requirements.txt

src/README.md

@@ -1,6 +1,6 @@
 # Developing the Web Almanac
 
-The Web Almanac can be developed on macOS, Windows or Linux. It requires Node v12, Python v3.8 and pip to be installed. You can use Docker to avoid manually configuring the development environment.
+The Web Almanac can be developed on macOS, Windows or Linux. It requires Node v16, Python v3.8 and pip to be installed. You can use Docker to avoid manually configuring the development environment.
 It can be quickly deployed as a development container in GitHub Codespaces to develop in cloud:
 [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/HTTPArchive/almanac.httparchive.org?quickstart=1)
 
@@ -14,7 +14,7 @@ An `.editorconfig` file exists for those using [EditorConfig](https://editorconf
 
 Make sure you run the following commands from within the `src` directory by executing `cd src` first.
 
-Make sure Python (3.8 or above), pip and NodeJS (v12 or above) are installed on your machine.
+Make sure Python (3.8 or above), pip and NodeJS (v16 or above) are installed on your machine.
 
 1. If you don't have virtualenv, install it using pip.
 
@@ -413,7 +413,6 @@ docker container run --rm -it -v "$PWD":/app webalmanac npm run pytest
 ```
 docker container run --rm -it -v "$PWD":/app -v /app/node_modules -p 8080:8080 webalmanac bash
 root@[CID]:/app# python main.py
-^C
 root@[CID]:/app# npm run generate
 root@[CID]:/app# npm run pytest
 root@[CID]:/app# exit
@@ -430,11 +429,11 @@ docker image build --build-arg PYVER=3.8 --build-arg NODEVER=14.x --build-arg SK
 This will depend on your operating system but for MacOS/Linux this would be:
 
 ```
-docker container run -it --rm -v /app/node_modules -v "$PWD/..":/app -w /app/src --entrypoint=./tools/scripts/run_linter_locally.sh github/super-linter
+docker container run -it --rm -v /app/node_modules -v "$PWD/..":/app -w /app/src --entrypoint=./tools/scripts/run_linter_locally.sh github/super-linter:slim-latest
 ```
 
 And for Windows:
 
 ```
-docker container run --rm -v /app/node_modules -v %cd%\\..:/app -w /app/src --entrypoint=./tools/scripts/run_linter_locally.sh github/super-linter
+docker container run --rm -v /app/node_modules -v %cd%\\..:/app -w /app/src --entrypoint=./tools/scripts/run_linter_locally.sh github/super-linter:slim-latest
 ```

src/package.json

@@ -21,8 +21,8 @@
     "ebooks": "node ./tools/generate/generate_ebook_pdfs",
     "deploy": "./tools/scripts/deploy.sh",
     "lint": "run-script-os",
-    "lint:darwin:linux": "docker container run -it --rm -v \"$PWD/..\":/app -w /app/src --entrypoint=./tools/scripts/run_linter_locally.sh github/super-linter",
-    "lint:win32": "docker container run --rm -v \"%cd%\\..\":/app -w /app/src --entrypoint=./tools/scripts/run_linter_locally.sh github/super-linter",
+    "lint:darwin:linux": "docker container run -it --rm -v \"$PWD/..\":/app -w /app/src --entrypoint=./tools/scripts/run_linter_locally.sh github/super-linter:slim-latest",
+    "lint:win32": "docker container run --rm -v \"%cd%\\..\":/app -w /app/src --entrypoint=./tools/scripts/run_linter_locally.sh github/super-linter:slim-latest",
     "pytest": "pytest --cov server --cov-fail-under=100 --cov-report=term-missing -s",
     "stage": "./tools/scripts/deploy.sh -n",
     "start": "run-script-os",