Skip to content

Commit 8412f03

Browse files
authored
Fix some Lighthouse errors (#3879)
1 parent e555057 commit 8412f03

7 files changed

Lines changed: 22 additions & 7 deletions

File tree

.github/lighthouse/lighthouse-config-dev.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
"th-has-data-cells": "off",
1616
"identical-links-same-purpose": "off",
1717
"image-redundant-alt": "off",
18+
"image-size-responsive": "off",
1819
"inspector-issues": "off",
1920
"installable-manifest": "off",
2021
"interactive": "off",

.github/lighthouse/lighthouse-config-prod.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
"th-has-data-cells": "off",
1818
"identical-links-same-purpose": "off",
1919
"image-redundant-alt": "off",
20+
"image-size-responsive": "off",
2021
"inspector-issues": "off",
2122
"installable-manifest": "off",
2223
"interactive": "off",

src/server/csp.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,12 @@
1717
"www.googletagmanager.com",
1818
],
1919
"img-src": ["'self'", "https:", "data:"],
20-
"frame-src": ["'self'", "docs.google.com", "www.youtube.com"],
20+
"frame-src": [
21+
"'self'",
22+
"docs.google.com",
23+
"www.youtube.com",
24+
"www.googletagmanager.com",
25+
],
2126
"object-src": ["'self'"],
2227
"base-uri": ["'none'"],
2328
}

src/server/embeds_csp.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,12 @@
1717
"www.googletagmanager.com",
1818
],
1919
"img-src": ["'self'", "https:", "data:"],
20-
"frame-src": ["'self'", "docs.google.com", "www.youtube.com"],
20+
"frame-src": [
21+
"'self'",
22+
"docs.google.com",
23+
"www.youtube.com",
24+
"www.googletagmanager.com",
25+
],
2126
"object-src": ["'self'"],
2227
"base-uri": ["'none'"],
2328
}

src/server/search_csp.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"ssl.gstatic.com",
2323
"data:",
2424
],
25-
"frame-src": ["'self'", "cse.google.com"],
25+
"frame-src": ["'self'", "cse.google.com", "www.googletagmanager.com"],
2626
"object-src": ["'none'"],
2727
"base-uri": ["'none'"],
2828
}

src/server/stories_csp.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,12 @@
1616
"cdn.ampproject.org",
1717
],
1818
"img-src": ["'self'", "https:", "data:"],
19-
"frame-src": ["'self'", "docs.google.com", "www.youtube.com"],
19+
"frame-src": [
20+
"'self'",
21+
"docs.google.com",
22+
"www.youtube.com",
23+
"www.googletagmanager.com"
24+
],
2025
"frame-ancestors": ["*"],
2126
"object-src": ["'none'"],
2227
"base-uri": ["'none'"],

src/templates/base/base.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -691,9 +691,7 @@
691691
</option>
692692
{% endif %}
693693
{% endfor %}
694-
<option disabled="disabled" aria-hidden="true">
695-
────
696-
</option>
694+
<hr>
697695
<option value="https://github.com/HTTPArchive/almanac.httparchive.org/wiki/Translators'-Guide">
698696
{{ self.help_translate() }}
699697
</option>

0 commit comments

Comments
 (0)