Merge pull request #23 from browniebroke/package-lock

Add `--lock` option to update the `package-lock.json` file in addition to manifest files

Author: JamesMessinger

CHANGELOG.md

@@ -2,6 +2,9 @@
 All notable changes will be documented in this file.
 `version-bump-prompt` adheres to [Semantic Versioning](http://semver.org/).
 
+## Unreleased
+
+- Added `--lock` option to update the package-json.lock file
 
 ## [v4.0.0](https://github.com/BigstickCarpet/version-bump-prompt/tree/v4.0.0) (2017-11-15)
 

bin/bump.js

@@ -23,6 +23,7 @@ program
   .option('--push', 'Push the Git commit')
   .option('--all', 'Commit/tag/push ALL pending files, not just the ones changed by bump')
   .option('--grep <filespec...>', 'Files and/or globs to do a text-replace of the old version number with the new one')
+  .option('--lock', 'Also update the package-lock.json')
   .on('--help', () => {
     console.log(
       '  Examples:\n' +
@@ -52,7 +53,7 @@ else {
     options.commit = true;
   }
 
-  let manifests = api.manifests();
+  let manifests = api.manifests(options.lock);
   bumpManifests(manifests, options)
     .then(() => {
       api.grep(manifests, options);

lib/index.js

@@ -27,8 +27,12 @@ module.exports = {
  *
  * @returns {string[]}
  */
-function getManifests () {
-  return ['package.json', 'bower.json', 'component.json'].filter((manifest) => {
+function getManifests (withLockfile) {
+  let candidates = ['package.json', 'bower.json', 'component.json'];
+  if (withLockfile) {
+    candidates.push('package-lock.json');
+  }
+  return candidates.filter((manifest) => {
     let pkgPath = path.join(cwd, manifest);
     try {
       const pkg = require(pkgPath);

readme.md

@@ -63,6 +63,7 @@ Options:
   --push                Push the Git commit
   --all                 Commit/tag/push ALL pending files, not just the ones changed by bump
   --grep <filespec...>  Files and/or globs to do a text-replace of the old version number with the new one
+  --lock                Update the package-lock.json file as well
 
 Examples:
 

test/specs/lock.spec.js

@@ -0,0 +1,37 @@
+'use strict';
+
+const cli = require('../fixtures/cli');
+const files = require('../fixtures/files');
+const check = require('../fixtures/check');
+const chai = require('chai');
+
+chai.should();
+
+describe('bump --lock', () => {
+  it('should not increment lock file by default', () => {
+    files.create('package-lock.json', { version: '1.0.0' });
+
+    let output = cli.exec('--patch');
+
+    output.stderr.should.be.empty;
+    output.stdout.should.be.empty;
+    output.status.should.equal(0);
+
+    files.json('package-lock.json').should.deep.equal({ version: '1.0.0' });
+  });
+
+  it('should increment version when lock option is provided', () => {
+    files.create('package-lock.json', { version: '0.0.0' });
+
+    let output = cli.exec('--patch --lock');
+
+    output.stderr.should.be.empty;
+    output.status.should.equal(0);
+
+    output.lines.should.deep.equal([
+      `${check} Updated package-lock.json to 0.0.1`,
+    ]);
+
+    files.json('package-lock.json').should.deep.equal({ version: '0.0.1' });
+  });
+});