ESLint fixes

Author: JamesMessinger

src/cli/index.ts

@@ -1,4 +1,3 @@
-// tslint:disable: no-console
 import { info, success } from "log-symbols";
 import { manifest } from "../manifest";
 import { ProgressEvent, VersionBumpProgress } from "../types/version-bump-progress";
@@ -45,7 +44,6 @@ export async function main(args: string[]): Promise<void> {
 }
 
 function progress({ event, script, updatedFiles, skippedFiles, newVersion }: VersionBumpProgress): void {
-  // tslint:disable-next-line: switch-default
   switch (event) {
     case ProgressEvent.FileUpdated:
       console.log(success, `Updated ${updatedFiles.pop()} to ${newVersion}`);

src/cli/parse-args.ts

@@ -1,4 +1,3 @@
-// tslint:disable: no-console
 import * as commandLineArgs from "command-line-args";
 import * as semver from "semver";
 import { isReleaseType } from "../release-type";
@@ -55,7 +54,7 @@ export function parseArgs(argv: string[]): ParsedArgs {
     // If --preid is used without an argument, then throw an error, since it's probably a mistake.
     // If they want to use the default value ("beta"), then they should not pass the argument at all
     if (args.preid === null) {
-      throw new Error(`The --preid option requires a value, such as "alpha", "beta", etc.`);
+      throw new Error("The --preid option requires a value, such as \"alpha\", \"beta\", etc.");
     }
 
     // If --commit is used without an argument, then treat it as a boolean flag

src/fs.ts

@@ -49,11 +49,10 @@ export async function writeJsonFile(file: JsonFile): Promise<void> {
 /**
  * Reads a text file and returns its contents.
  */
-export function readTextFile(name: string, cwd: string): Promise<TextFile> { // tslint:disable-line: promise-function-async
+export function readTextFile(name: string, cwd: string): Promise<TextFile> {
   return new Promise((resolve, reject) => {
     let filePath = path.join(cwd, name);
 
-    // tslint:disable-next-line ban
     fs.readFile(filePath, "utf8", (err, text) => {
       if (err) {
         reject(err);
@@ -71,9 +70,8 @@ export function readTextFile(name: string, cwd: string): Promise<TextFile> { //
 /**
  * Writes the given text to the specified file.
  */
-export function writeTextFile(file: TextFile): Promise<void> { // tslint:disable-line: promise-function-async
+export function writeTextFile(file: TextFile): Promise<void> {
   return new Promise((resolve, reject) => {
-    // tslint:disable-next-line ban
     fs.writeFile(file.path, file.data, (err) => {
       if (err) {
         reject(err);

src/get-new-version.ts

@@ -1,6 +1,6 @@
 import * as inquirer from "inquirer";
 import * as semver from "semver";
-import { ReleaseType, SemVer } from "semver"; // tslint:disable-line: no-duplicate-imports
+import { ReleaseType, SemVer } from "semver";
 import { BumpRelease, PromptRelease } from "./normalize-options";
 import { Operation } from "./operation";
 import { isPrerelease, releaseTypes } from "./release-type";
@@ -46,7 +46,7 @@ function getNextVersion(oldVersion: string, bump: BumpRelease): string {
     // This is a special case when going from a non-prerelease version to a prerelease version.
     // SemVer sets the prerelease version to zero (e.g. "1.23.456" => "1.23.456-beta.0").
     // But the user probably expected it to be "1.23.456-beta.1" instead.
-    // @ts-ignore
+    // @ts-expect-error - TypeScript thinks this array is read-only
     newSemVer.prerelease[1] = "1";
     newSemVer.format();
   }

src/index.ts

@@ -1,4 +1,3 @@
-// tslint:disable: no-default-export
 import { versionBump } from "./version-bump";
 
 // Exprot the external type definitions as named exports
@@ -13,5 +12,5 @@ export default versionBump;
 
 // CommonJS default export hack
 if (typeof module === "object" && typeof module.exports === "object") {
-  module.exports = Object.assign(module.exports.default, module.exports);  // tslint:disable-line: no-unsafe-any
+  module.exports = Object.assign(module.exports.default, module.exports);
 }

src/manifest.ts

@@ -1,5 +1,5 @@
 // NOTE: We can't `import` the package.json file because it's outside of the "src" directory.
-// tslint:disable-next-line: no-var-requires no-require-imports
+// eslint-disable-next-line @typescript-eslint/no-require-imports, @typescript-eslint/no-var-requires
 const manifest = require("../package.json") as Manifest;
 
 export { manifest };
@@ -14,7 +14,6 @@ export interface Manifest {
   [key: string]: unknown;
 }
 
-// tslint:disable: no-any no-unsafe-any
 
 /**
  * Determines whether the specified value is a package manifest.

src/normalize-options.ts

@@ -1,4 +1,4 @@
-import globby = require("globby"); // tslint:disable-line: no-require-imports
+import * as globby from "globby";
 import { hasMagic } from "globby";
 import { isReleaseType, ReleaseType } from "./release-type";
 import { VersionBumpOptions } from "./types/version-bump-options";
@@ -128,7 +128,7 @@ export async function normalizeOptions(raw: VersionBumpOptions): Promise<Normali
   }
 
   if (release.type === "prompt" && !(ui.input && ui.output)) {
-    throw new Error(`Cannot prompt for the version number because input or output has been disabled.`);
+    throw new Error("Cannot prompt for the version number because input or output has been disabled.");
   }
 
   return { release, commit, tag, push, files, cwd, interface: ui };

src/operation.ts

@@ -83,7 +83,6 @@ export class Operation {
     // Validate and normalize the options
     let options = await normalizeOptions(input);
 
-    // tslint:disable-next-line: no-unbound-method
     return new Operation(options, input.progress);
   }
 

src/release-type.ts

@@ -12,7 +12,6 @@ export const prereleaseTypes: ReleaseType[] = ["premajor", "preminor", "prepatch
  */
 export const releaseTypes: ReleaseType[] = prereleaseTypes.concat(["major", "minor", "patch"]);
 
-// tslint:disable: no-any no-unsafe-any
 
 /**
  * Determines whether the specified value is a pre-release.

test/specs/api.spec.js

@@ -34,8 +34,8 @@ describe("versionBup() API", () => {
     expect(files.json("package.json")).to.deep.equal({ version: "2.34.567" });
 
     // Git and NPM should NOT have been called
-    expect(mocks.git()).to.be.empty;
-    expect(mocks.npm()).to.be.empty;
+    expect(mocks.git()).to.have.lengthOf(0);
+    expect(mocks.npm()).to.have.lengthOf(0);
   });
 
   it("should accept a bump type", async () => {
@@ -60,8 +60,8 @@ describe("versionBup() API", () => {
     expect(files.json("package.json")).to.deep.equal({ version: "1.1.0" });
 
     // Git and NPM should NOT have been called
-    expect(mocks.git()).to.be.empty;
-    expect(mocks.npm()).to.be.empty;
+    expect(mocks.git()).to.have.lengthOf(0);
+    expect(mocks.npm()).to.have.lengthOf(0);
   });
 
   it("should accept options", async () => {
@@ -124,7 +124,7 @@ describe("versionBup() API", () => {
     ]);
 
     // NPM should NOT have been called
-    expect(mocks.npm()).to.be.empty;
+    expect(mocks.npm()).to.have.lengthOf(0);
   });
 
   it("should throw an error if the options are invalid", async () => {
@@ -168,8 +168,8 @@ describe("versionBup() API", () => {
       expect(files.json("package.json")).to.deep.equal({ version: "hello world" });
 
       // Git and NPM should NOT have been called
-      expect(mocks.git()).to.be.empty;
-      expect(mocks.npm()).to.be.empty;
+      expect(mocks.git()).to.have.lengthOf(0);
+      expect(mocks.npm()).to.have.lengthOf(0);
     }
   });