Skip to content

Commit e95f237

Browse files
committed
fix: fix and move test to relevant file.
1 parent 94b2961 commit e95f237

File tree

2 files changed

+24
-27
lines changed

2 files changed

+24
-27
lines changed

test/specs/files.spec.js

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -202,31 +202,4 @@ describe("bump [files...]", () => {
202202

203203
expect(files.json("package.json")).to.deep.equal({ version: "1.2.3" });
204204
});
205-
206-
it("should skip specified version scripts if present", () => {
207-
files.create("package.json", {
208-
version: "1.2.3",
209-
scripts: {
210-
preversion: "echo preversion",
211-
version: "echo version",
212-
}
213-
});
214-
files.create("package-lock.json", { version: "1.2.3" });
215-
216-
let cli = bump("major --skip-version-scripts preversion postversion");
217-
218-
expect(cli).to.have.stderr("");
219-
expect(cli).to.have.exitCode(0);
220-
221-
expect(cli).to.have.stdout(
222-
`${check} Script skipped preversion\n` +
223-
`${check} Updated package.json to 2.0.0\n` +
224-
`${check} Updated package-lock.json to 2.0.0\n` +
225-
`${check} Npm run version\n`
226-
);
227-
228-
expect(files.json("package.json")).to.deep.equal({ version: "2.0.0", scripts: { preversion: "echo preversion", version: "echo version", }});
229-
expect(files.json("package-lock.json")).to.deep.equal({ version: "2.0.0" });
230-
});
231-
232205
});

test/specs/npm.spec.js

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,4 +136,28 @@ describe("npm version hooks", () => {
136136
expect(bin[6].version).to.equal("2.0.0");
137137
});
138138

139+
it("should skip whichever version scripts present", () => {
140+
files.create("package.json", {
141+
version: "1.2.3",
142+
scripts: {
143+
preversion: "echo preversion",
144+
version: "echo version",
145+
}
146+
});
147+
files.create("package-lock.json", { version: "1.2.3" });
148+
149+
let cli = bump("major --ignore-scripts");
150+
151+
expect(cli).to.have.stderr("");
152+
expect(cli).to.have.exitCode(0);
153+
154+
expect(cli).to.have.stdout(
155+
`${check} Updated package.json to 2.0.0\n` +
156+
`${check} Updated package-lock.json to 2.0.0\n`
157+
);
158+
159+
expect(files.json("package.json")).to.deep.equal({ version: "2.0.0", scripts: { preversion: "echo preversion", version: "echo version", }});
160+
expect(files.json("package-lock.json")).to.deep.equal({ version: "2.0.0" });
161+
});
162+
139163
});

0 commit comments

Comments
 (0)