Improve coverage

Author: gdalle

DifferentiationInterface/ext/DifferentiationInterfaceFiniteDiffExt/DifferentiationInterfaceFiniteDiffExt.jl

@@ -21,6 +21,7 @@ using FiniteDiff:
 using LinearAlgebra: dot, mul!
 
 DI.check_available(::AutoFiniteDiff) = true
+DI.inner_preparation_behavior(::AutoFiniteDiff) = DI.PrepareInnerSimple()
 
 # see https://github.com/SciML/ADTypes.jl/issues/33
 

DifferentiationInterface/ext/DifferentiationInterfaceFiniteDifferencesExt/DifferentiationInterfaceFiniteDifferencesExt.jl

@@ -7,6 +7,7 @@ using LinearAlgebra: dot
 
 DI.check_available(::AutoFiniteDifferences) = true
 DI.inplace_support(::AutoFiniteDifferences) = DI.InPlaceNotSupported()
+DI.inner_preparation_behavior(::AutoFiniteDifferences) = DI.PrepareInnerSimple()
 
 ## Pushforward
 

DifferentiationInterface/test/Back/FiniteDiff/test.jl

@@ -15,6 +15,8 @@ LOGGING = get(ENV, "CI", "false") == "false"
 for backend in [AutoFiniteDiff()]
     @test check_available(backend)
     @test check_inplace(backend)
+    @test DifferentiationInterface.inner_preparation_behavior(backend) isa
+        DifferentiationInterface.PrepareInnerSimple
 end
 
 @testset "Dense" begin
@@ -25,6 +27,13 @@ end
         logging=LOGGING,
     )
 
+    test_differentiation(
+        SecondOrder(AutoFiniteDiff(; relstep=1e-5, absstep=1e-5), AutoFiniteDiff()),
+        default_scenarios();
+        logging=LOGGING,
+        rtol=1e-2,
+    )
+
     test_differentiation(
         [
             AutoFiniteDiff(; relstep=cbrt(eps(Float64))),

DifferentiationInterface/test/Back/FiniteDifferences/test.jl

@@ -13,6 +13,8 @@ LOGGING = get(ENV, "CI", "false") == "false"
 for backend in [AutoFiniteDifferences(; fdm=FiniteDifferences.central_fdm(3, 1))]
     @test check_available(backend)
     @test !check_inplace(backend)
+    @test DifferentiationInterface.inner_preparation_behavior(backend) isa
+        DifferentiationInterface.PrepareInnerSimple
 end
 
 test_differentiation(

DifferentiationInterface/test/Back/PolyesterForwardDiff/test.jl

@@ -22,6 +22,8 @@ backends = [
 for backend in backends
     @test check_available(backend)
     @test check_inplace(backend)
+    @test DifferentiationInterface.inner_preparation_behavior(backend) isa
+        DifferentiationInterface.PrepareInnerOverload
 end
 
 test_differentiation(
@@ -31,6 +33,12 @@ test_differentiation(
     excluded=SECOND_ORDER,
 );
 
+test_differentiation(
+    SecondOrder(AutoPolyesterForwardDiff(), AutoPolyesterForwardDiff()),
+    default_scenarios();
+    logging=LOGGING,
+);
+
 @testset "Batch size" begin
     @test DI.pick_batchsize(AutoPolyesterForwardDiff(), 10) ==
         DI.pick_batchsize(AutoForwardDiff(), 10)

DifferentiationInterface/test/Core/SimpleFiniteDiff/test.jl

@@ -16,12 +16,12 @@ backends = [ #
 
 second_order_backends = [ #
     SecondOrder(
-        AutoSimpleFiniteDiff(; chunksize=5),
+        AutoForwardFromPrimitive(AutoSimpleFiniteDiff(; chunksize=5)),
         AutoReverseFromPrimitive(AutoSimpleFiniteDiff(; chunksize=4)),
     ),
     SecondOrder(
         AutoReverseFromPrimitive(AutoSimpleFiniteDiff(; chunksize=5)),
-        AutoSimpleFiniteDiff(; chunksize=4),
+        AutoForwardFromPrimitive(AutoSimpleFiniteDiff(; chunksize=4)),
     ),
 ]