Correct map

Author: gdalle

DifferentiationInterface/src/first_order/pullback.jl

@@ -168,7 +168,7 @@ function _pullback_via_pushforward(
     dy,
     contexts::Vararg{Context,C},
 ) where {F,C}
-    dx = map(CartesianIndices(x)) do j
+    dx = map(CartesianIndices(x)) do xj, j
         t1 = pushforward(f, pushforward_prep, backend, x, (basis(x, j),), contexts...)
         convert(eltype(x), dot(only(t1), dy))
     end
@@ -254,7 +254,7 @@ function _pullback_via_pushforward(
     dy,
     contexts::Vararg{Context,C},
 ) where {F,C}
-    dx = map(CartesianIndices(x)) do j  # preserve shape
+    dx = map(CartesianIndices(x)) do xj, j  # preserve shape
         t1 = pushforward(f!, y, pushforward_prep, backend, x, (basis(x, j),), contexts...)
         convert(eltype(x), dot(only(t1), dy))
     end

DifferentiationInterface/src/first_order/pushforward.jl

@@ -171,7 +171,7 @@ function _pushforward_via_pullback(
     dx,
     contexts::Vararg{Context,C},
 ) where {F,C}
-    dy = map(y, CartesianIndices(y)) do i
+    dy = map(y, CartesianIndices(y)) do yi, i
         t1 = pullback(f, pullback_prep, backend, x, (basis(y, i),), contexts...)
         convert(eltype(y), dot(only(t1), dx))
     end
@@ -243,7 +243,7 @@ function _pushforward_via_pullback(
     dx,
     contexts::Vararg{Context,C},
 ) where {F,C}
-    dy = map(CartesianIndices(y)) do i  # preserve shape
+    dy = map(CartesianIndices(y)) do yi, i  # preserve shape
         t1 = pullback(f!, y, pullback_prep, backend, x, (basis(y, i),), contexts...)
         convert(eltype(y), dot(only(t1), dx))
     end