Skip to content

Commit 3dbc974

Browse files
committed
test_io_shared: Test again
1 parent c9c8fff commit 3dbc974

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

.github/workflows/UnitTests.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -556,6 +556,8 @@ jobs:
556556
MV2_SMP_USE_CMA: 0
557557
# Work around issue with affinity not set. Ref:
558558
# https://github.com/JuliaParallel/MPI.jl/pull/810#issuecomment-1920255386
559+
# MVAPICH 2 and 3 use different environment variables; set both.
560+
MV2_ENABLE_AFFINITY: 0
559561
MVP_ENABLE_AFFINITY: 0
560562

561563
steps:

test/test_io_shared.jl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ sync()
4848
#TODO # https://github.com/JuliaParallel/MPI.jl/issues/555,
4949
#TODO # https://github.com/JuliaParallel/MPI.jl/issues/579
5050
#TODO @test MPI.File.get_position_shared(fh) == sum(1:sz) skip = Sys.isapple() || Sys.iswindows()
51-
# TODO: still broken on Apple
51+
# TODO: still broken on Apple with MPICH
5252
@test MPI.File.get_position_shared(fh) == sum(1:sz)
5353

5454
MPI.File.seek_shared(fh, 0)
@@ -63,6 +63,7 @@ sync()
6363
#TODO # TODO: this has to be fixed:
6464
#TODO # https://github.com/JuliaParallel/MPI.jl/issues/555
6565
#TODO @test MPI.File.get_position_shared(fh) == sum(1:sz) skip = Sys.iswindows()
66+
# TODO: still broken on Windows with MPICH
6667
@test MPI.File.get_position_shared(fh) == sum(1:sz)
6768

6869
MPI.File.set_view!(fh, 0, MPI.Datatype(UInt8), MPI.Datatype(UInt8))

0 commit comments

Comments
 (0)