Skip to content

Commit 7390a5b

Browse files
committed
test: Clean up test skipping
1 parent 73bbdd7 commit 7390a5b

1 file changed

Lines changed: 4 additions & 12 deletions

File tree

test/test_io_shared.jl

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,8 @@ MPI.File.sync(fh)
4848
MPI.File.write_ordered(fh, fill(Int64(rank), rank+1))
4949
MPI.Barrier(comm)
5050
MPI.File.sync(fh)
51-
if Sys.isapple()
52-
# TODO: this has to be fixed: https://github.com/JuliaParallel/MPI.jl/issues/555
53-
@test_skip MPI.File.get_position_shared(fh) == sum(1:sz)
54-
else
55-
@test MPI.File.get_position_shared(fh) == sum(1:sz)
56-
end
51+
# TODO: this has to be fixed: https://github.com/JuliaParallel/MPI.jl/issues/555
52+
@test MPI.File.get_position_shared(fh) == sum(1:sz) skip=Sys.isapple()
5753

5854
MPI.File.seek_shared(fh, 0)
5955
@test MPI.File.get_position_shared(fh) == 0
@@ -68,12 +64,8 @@ MPI.File.read_ordered!(fh, buf)
6864
MPI.Barrier(comm)
6965
MPI.File.sync(fh)
7066
MPI.Barrier(comm)
71-
#TODO if Sys.iswindows()
72-
#TODO # TODO: this has to be fixed: https://github.com/JuliaParallel/MPI.jl/issues/555
73-
#TODO @test_skip MPI.File.get_position_shared(fh) == sum(1:sz)
74-
#TODO else
75-
@test MPI.File.get_position_shared(fh) == sum(1:sz)
76-
#TODO end
67+
# TODO: this has to be fixed: https://github.com/JuliaParallel/MPI.jl/issues/555
68+
@test MPI.File.get_position_shared(fh) == sum(1:sz) skip=Sys.iswindows()
7769

7870
MPI.File.set_view!(fh, 0, MPI.Datatype(UInt8), MPI.Datatype(UInt8))
7971
MPI.Barrier(comm)

0 commit comments

Comments
 (0)