Skip to content

Commit 6c53f26

Browse files
leonhsldavid-risneyoldnewthing
authored
Apply suggestions from code review
Co-authored-by: David Risney <dave@deletethis.net> Co-authored-by: Raymond Chen <oldnewthing@users.noreply.github.com>
1 parent e48e00d commit 6c53f26

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

specs/MultiProfile.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ API spec for multiple profile support
44
# Background
55

66
Previously, all WebView2s can only use one fixed Edge profile in the browser process, which is
7-
normally the **Default** profile or the profile specified by the **--profile-directory** command
7+
normally the **Default** profile by not specifying a profile path, or the profile specified by the **--profile-directory** command
88
line switch. It means different WebView2s share a single profile directory on disk for data storage,
99
which might bring security concerns over cookies, autofill data, and password management etc.. Also,
1010
they might also interfere with each other in terms of user preference settings.
@@ -123,7 +123,7 @@ HRESULT AppWindow::OnCreateCoreWebView2ControllerCompleted(HRESULT result, ICore
123123
124124
```csharp
125125
CoreWebView2Environment _webViewEnvironment;
126-
public CreateWebView2ControllerWithOptions(IntPtr parentHWND, string profileName, bool isInPrivate)
126+
public CreateWebView2ControllerWithOptions(IntPtr parentWindow, string profileName, bool isInPrivate)
127127
{
128128
CoreWebView2ControllerOptions options = _webViewEnvironment.CreateCoreWebView2ControllerOptions(profileName, isInPrivate);
129129
CoreWebView2Controller webView2Controller = await _webViewEnvironment.CreateCoreWebView2ControllerWithOptionsAsync(parentHWND, options);

0 commit comments

Comments
 (0)