API spec review for password-autosave and general-autofill in Profile (#3285)

* Add multiprofile password-autosave and general-autofill interfaces.

* only general-autofill can work immediately while password-autosave can only work after next navigation.

* comments fix

* API Review: cookieManager for multiprofile (#1844)

* API documentation: cookieManager for multiprofile

* update comments.

* typo

* fix grammatical errors

* typo

* typo

* update cookie manager description in prologue

* update runtimeclass CoreWebView2Profile

* Update MultiProfile.md

* Update specs/MultiProfile.md

Co-authored-by: David Risney <dave@deletethis.net>

* Update specs/MultiProfile.md

Co-authored-by: David Risney <dave@deletethis.net>

* Update specs/MultiProfile.md

Co-authored-by: David Risney <dave@deletethis.net>

* Update specs/MultiProfile.md

Co-authored-by: David Risney <dave@deletethis.net>

* Update specs/MultiProfile.md

Co-authored-by: David Risney <dave@deletethis.net>

* Update specs/MultiProfile.md

Co-authored-by: David Risney <dave@deletethis.net>

* Update specs/MultiProfile.md

Co-authored-by: David Risney <dave@deletethis.net>

* Update specs/MultiProfile.md

Co-authored-by: David Risney <dave@deletethis.net>

* Update specs/MultiProfile.md

Co-authored-by: David Risney <dave@deletethis.net>

* Update MultiProfile.md

* Update MultiProfile.md

* Update MultiProfile.md

---------

Co-authored-by: zhuhaichao518 <54018092+zhuhaichao518@users.noreply.github.com>
Co-authored-by: David Risney <dave@deletethis.net>

Author: 3 people

specs/MultiProfile.md

@@ -29,6 +29,21 @@ Users can use this interface to get the cookie manager, which is shared by all W
 with this profile. The cookie manager got from profile (CoreWebView2.Profile.CookieManager) is the
 same as that got from CoreWebView2 (CoreWebView2.CookieManager).
 
+Currently, we already have **CoreWebView2Settings** interface to manage password-autosave and 
+general-autofill, and these two properties are different from other properties in
+**CoreWebView2Settings** because they will take effect immediately and apply for all WebView2s
+that created from the same profile. By adding password-autosave and general-autofill management
+interfaces in profile, we can manage the properties and they will apply immediately if we set a
+new value, and all WebView2s that created with the same profile can share the settings, which
+means if we change password-autosave or general-autofill property in one WebView2, the others
+with the same profile will also take effect. And these two properties are linked with their
+corresponding properties in ICoreWebView2Settings, so changing one will change the other.
+it will take effect immediately no matter setting the properties in **CoreWebView2Settings** or
+**CoreWebView2Profile**, and when the property is changed in one interface, the same property
+in the other interface is changed as well immediately. So for the WebView2s with the same profile,
+their **IsPasswordAutosaveEnabled** or **IsGeneralAutofillEnabled** property in
+**CoreWebView2Settings** and **CoreWebView2Profile** should always keep in sync.
+
 # Examples
 
 ## Win32 C++
@@ -217,6 +232,80 @@ HRESULT AppWindow::OnCreateCoreWebView2ControllerCompleted(
 }
 ```
 
+### Manage password-autosave and general-autofill settings in profile
+
+```cpp
+HRESULT AppWindow::TogglePasswordAutosaveInProfile(ICoreWebView2Controller* controller)
+{
+    // ...
+
+    // Get the profile object.
+    wil::com_ptr<ICoreWebView2> coreWebView2;
+    CHECK_FAILURE(controller->get_CoreWebView2(&coreWebView2));
+    Microsoft::WRL::ComPtr<ICoreWebView2Profile> webView2Profile;
+    CHECK_FAILURE(coreWebView2->get_Profile(&webView2Profile));
+    Microsoft::WRL::ComPtr<ICoreWebView2Profile3> webView2Profile3;
+    CHECK_FAILURE(webView2Profile.As(&webView2Profile3));
+    
+    // Get current value of password-autosave property.
+    BOOL enabled;
+    CHECK_FAILURE(webView2Profile3->get_IsPasswordAutosaveEnabled(&enabled));
+
+    // Set password-autosave property to the opposite value to current value.
+    if (enabled)
+    {
+        CHECK_FAILURE(webView2Profile3->put_IsPasswordAutosaveEnabled(FALSE));
+        MessageBox(
+            hWnd, L"Password autosave will be disabled immediately in all WebView2 with the same profile.",
+            L"Profile settings change", MB_OK);
+    }
+    else
+    {
+        CHECK_FAILURE(webView2Profile3->put_IsPasswordAutosaveEnabled(TRUE));
+        MessageBox(
+            hWnd, L"Password autosave will be enabled immediately in all WebView2 with the same profile.",
+            L"Profile settings change", MB_OK);
+    }
+  
+    // ...
+}
+
+HRESULT AppWindow::ToggleGeneralAutofillInProfile(ICoreWebView2Controller* controller)
+{
+    // ...
+
+    // Get the profile object.
+    wil::com_ptr<ICoreWebView2> coreWebView2;
+    CHECK_FAILURE(controller->get_CoreWebView2(&coreWebView2));
+    Microsoft::WRL::ComPtr<ICoreWebView2Profile> webView2Profile;
+    CHECK_FAILURE(coreWebView2->get_Profile(&webView2Profile));
+    Microsoft::WRL::ComPtr<ICoreWebView2Profile3> webView2Profile3;
+    CHECK_FAILURE(webView2Profile.As(&webView2Profile3));
+    
+    // Get current value of general-autofill property.
+    BOOL enabled;
+    CHECK_FAILURE(webView2Profile3->get_IsGeneralAutofillsaveEnabled(&enabled));
+
+    // Set general-autofill property to the opposite value to current value.
+    if (enabled)
+    {
+        CHECK_FAILURE(webView2Profile3->put_IsGeneralAutofillEnabled(FALSE));
+        MessageBox(
+            hWnd, L"General autofill will be disabled immediately in all WebView2 with the same profile.",
+            L"Profile settings change", MB_OK);
+    }
+    else
+    {
+        CHECK_FAILURE(webView2Profile3->put_IsGeneralAutofillEnabled(TRUE));
+        MessageBox(
+            hWnd, L"General autofill will be enabled immediately in all WebView2 with the same profile.",
+            L"Profile settings change", MB_OK);
+    }
+  
+    // ...
+}
+```
+
 ## .NET and WinRT
 
 ### Create WebView2 with a specific profile, then access the profile property of WebView2
@@ -314,6 +403,32 @@ private void WebViewProfile_Deleted(object sender, object e)
         Close();
     });
 }
+### Manage password-autosave and general-autofill settings in profile
+
+```csharp
+public TogglePasswordAutosaveInProfile(CoreWebView2Controller controller)
+{
+    // Get the profile object.
+    CoreWebView2Profile profile = controller.CoreWebView2.Profile;
+
+    // Get current value of password-autosave property.
+    bool enabled = profile.IsPasswordAutosaveEnabled;
+
+    // Set password-autosave property to the opposite value to current value.
+    profile.IsPasswordAutosaveEnabled = !enabled;
+}
+
+public ToggleGeneralAutofillInProfile(CoreWebView2Controller controller)
+{
+    // Get the profile object.
+    CoreWebView2Profile profile = controller.CoreWebView2.Profile;
+
+    // Get current value of general-autofill property.
+    bool enabled = profile.IsGeneralAutofillEnabled;
+
+    // Set general-autofill property to the opposite value to current value.
+    profile.IsGeneralAutofillEnabled = !enabled;
+}
 ```
 
 # API Details
@@ -459,6 +574,45 @@ interface ICoreWebView2StagingProfileDeletedEventHandler: IUnknown {
       [in] ICoreWebView2Profile* sender,
       [in] IUnknown* args);
 }
+
+[uuid(e2e8dce3-8213-4a32-b3b0-c80a8d154b61), object, pointer_default(unique)]
+interface ICoreWebView2Profile3 : ICoreWebView2Profile2 {
+  /// IsPasswordAutosaveEnabled controls whether autosave for password
+  /// information is enabled. The IsPasswordAutosaveEnabled property behaves
+  /// independently of the IsGeneralAutofillEnabled property. When IsPasswordAutosaveEnabled is
+  /// false, no new password data is saved and no Save/Update Password prompts are displayed.
+  /// However, if there was password data already saved before disabling this setting,
+  /// then that password information is auto-populated, suggestions are shown and clicking on
+  /// one will populate the fields.
+  /// When IsPasswordAutosaveEnabled is true, password information is auto-populated,
+  /// suggestions are shown and clicking on one will populate the fields, new data
+  /// is saved, and a Save/Update Password prompt is displayed.
+  /// The default value is `FALSE`.
+  /// This property has the same value as `CoreWebView2Settings.IsPasswordAutosaveEnabled`, and
+  /// changing one will change the other. All `CoreWebView2`s with the same
+  /// `CoreWebView2Profile` will share the same value for this property, so for the `CoreWebView2`s with the same
+  /// profile, their `CoreWebView2Settings.IsPasswordAutosaveEnabled` and 
+  /// `CoreWebView2Profile.IsPasswordAutosaveEnabled` will always have the same value.
+  [propget] HRESULT IsPasswordAutosaveEnabled([out, retval] BOOL* value);
+  /// Set the IsPasswordAutosaveEnabled property.
+  [propput] HRESULT IsPasswordAutosaveEnabled([in] BOOL value);
+
+  /// IsGeneralAutofillEnabled controls whether autofill for information
+  /// like names, street and email addresses, phone numbers, and arbitrary input
+  /// is enabled. This excludes password and credit card information. When
+  /// IsGeneralAutofillEnabled is false, no suggestions appear, and no new information
+  /// is saved. When IsGeneralAutofillEnabled is true, information is saved, suggestions
+  /// appear and clicking on one will populate the form fields.
+  /// The default value is `TRUE`.
+  /// This property has the same value as `CoreWebView2Settings.IsGeneralAutofillEnabled`, and
+  /// changing one will change the other. All `CoreWebView2`s with the same
+  /// `CoreWebView2Profile` will share the same value for this property, so for the `CoreWebView2`s with the same
+  /// profile, their `CoreWebView2Settings.IsGeneralAutofillEnabled` and 
+  /// `CoreWebView2Profile.IsGeneralAutofillEnabled` will always have the same value.
+  [propget] HRESULT IsGeneralAutofillEnabled([out, retval] BOOL* value);
+  /// Set the IsGeneralAutofillEnabled property.
+  [propput] HRESULT IsGeneralAutofillEnabled([in] BOOL value);
+}
 ```
 
 ## .NET and WinRT
@@ -516,6 +670,13 @@ namespace Microsoft.Web.WebView2.Core
             void Delete();
             event Windows.Foundation.TypedEventHandler<CoreWebView2Profile, Object> Deleted;
         }
+
+        [interface_name("Microsoft.Web.WebView2.Core.ICoreWebView2Profile3")]
+        {
+            Boolean IsPasswordAutosaveEnabled { get; set; };
+
+            Boolean IsGeneralAutofillEnabled { get; set; };
+        }
     }
 }
 ```