change name of addresses autofill to general

Author: Maura Winstanley

specs/Autofill.md

@@ -1,15 +1,15 @@
 # Background
-The WebView2 team has been asked for an API to allow end developers to set the autofill preferences.  We are exposing two of the autofill preferences that will allow enabling and disabling autofill for addresses and passwords.  Addresses includes things like email addresses, shipping addresses, phone numbers, and names.  Passwords includes things like usernames and passwords for login. 
+The WebView2 team has been asked for an API to allow end developers to set the autofill preferences.  We are exposing two of the autofill preferences that will allow enabling and disabling general and password autofill.  General autofill includes things like email addresses, shipping addresses, phone numbers, and names.  Password autofill includes things like usernames and passwords for login. 
 
 In this document we describe the updated API. We'd appreciate your feedback.
 
 
 # Description
 
 Autofilling has three components
-* Autostuffing - Filling the corresponding form fields automatically on page load.
-* Suggesting - When the user clicks on the form field, drop down suggestions of previously saved forms will be displayed.  
-* Populating - When clicking on one of the suggestions, the form data will populate the respective fields. 
+* Autostuffing - Filling the corresponding form fields automatically on page load
+* Suggesting - When the user clicks on the form field, drop down suggestions of previously saved forms will be displayed  
+* Populating - When clicking on one of the suggestions, the form data will populate the respective fields 
 
 
 # Examples
@@ -24,12 +24,12 @@ void SettingsComponent::TogglePasswordAutofill() {
     settings->put_IsPasswordAutofillEnabled(!enabled);
 }
 
-void SettingsComponent::ToggleAddressAutofill() {
+void SettingsComponent::ToggleGeneralAutofill() {
     wil::com_ptr<ICoreWebView2Settings2_2> settings;
     webView->get_Settings(&settings);
     bool enabled;
-    settings->get_IsAddressAutofillEnabled(&enabled)
-    settings->put_IsAddressAutofillEnabled(!enabled);
+    settings->get_IsGeneralAutofillEnabled(&enabled)
+    settings->put_IsGeneralAutofillEnabled(!enabled);
 }
 ```
 
@@ -43,39 +43,39 @@ private void TogglePasswordAutofill(CoreWebView2 sender, CoreWebView2NavigationS
     settings.IsPasswordAutofillEnabled = !settings.IsPasswordAutofillEnabled;
 }
 
-webView2Control.NavigationStarting += ToggleAddressAutofill;
+webView2Control.NavigationStarting += ToggleGeneralAutofill;
 
-private void ToggleAddressAutofill(CoreWebView2 sender, CoreWebView2NavigationStartingEventArgs e)
+private void ToggleGeneralAutofill(CoreWebView2 sender, CoreWebView2NavigationStartingEventArgs e)
 {
     var settings = webView2Control.CoreWebView2.Settings;
-    settings.IsAddressAutofillEnabled = !settings.IsAddressAutofillEnabled;
+    settings.IsGeneralAutofillEnabled = !settings.IsGeneralAutofillEnabled;
 }
 
 ```
 
 
 # Remarks
-The behaviour of the two types of autofill preferences behaves differently when toggling between enable and disable.  
-If address autofill is enabled:
-* Address data will be saved
-* Upon clicking on the form field, suggestions will appear
-* Clicking on one of the suggestions will populate the corresponding fields
+The two types of autofill preferences behave differently when toggling between enable and disable.  
+If general autofill is enabled:
+* General data will be saved
+* Upon clicking on the form field, suggestions will appear.
+* Clicking on one of the suggestions will populate the corresponding fields.
 
-If address autofill is disabled
-* No new address data will be saved
-* Upon clicking on the form field, suggestions will not appear
+If general autofill is disabled
+* No new general data will be saved.
+* Upon clicking on the form field, suggestions will not appear.
 
 If password autofill is enabled
-* Password data will be autostuffed
-* Upon clicking on the form field, suggestions will appear
-* Clicking on one of the suggestions will populate the corresponding fields
-* Upon submitting the password data, a save password prompt will be displayed that will give the user the option to save or update the password data. If the user selects `Yes`, the new password data will be saved or updated depending on if they have previously entered password data while password autofill is enabled  
+* Password data will be autostuffed.
+* Upon clicking on the form field, suggestions will appear.
+* Clicking on one of the suggestions will populate the corresponding fields.
+* Upon submitting the password data, a save password prompt will be displayed that will give the user the option to save or update the password data. If the user selects `Yes`, the new password data will be saved or updated depending on if they have previously entered password data while password autofill is enabled.  
 
 If password autofill is disabled
-* The password data will be autostuffed
-* Upon clicking on the form field, suggestions will appear
-* Clicking on one of the suggestions will populate the corresponding fields 
-* Upon submitting the password data, no save password prompt will be displayed and no password information is saved or updated
+* The password data will be autostuffed.
+* Upon clicking on the form field, suggestions will appear.
+* Clicking on one of the suggestions will populate the corresponding fields.
+* Upon submitting the password data, no save password prompt will be displayed and no password information is saved or updated.
 
 
 # API Notes
@@ -94,11 +94,11 @@ interface ICoreWebView2Settings2_2 : ICoreWebView2Settings2 {
   // Set the IsPasswordAutofillEnabled property.
   [propput] HRESULT IsPasswordAutofillEnabled([in] BOOL isPasswordAutofillEnabled);
 
-  /// IsAddressAutofillEnabled controls whether autofill for addresses is enabled.
+  /// IsGeneralAutofillEnabled controls whether general autofill is enabled.
   /// The default value is `TRUE`.
-  [propget] HRESULT IsAddressAutofillEnabled([out, retval] BOOL* isAddressAutofillEnabled);
-  /// Set the IsAddressAutofillEnabled property.
-  [propput] HRESULT IsAddressAutofillEnabled([in] BOOL isAddressAutofillEnabled);
+  [propget] HRESULT IsGeneralAutofillEnabled([out, retval] BOOL* isGeneralAutofillEnabled);
+  /// Set the IsGeneralAutofillEnabled property.
+  [propput] HRESULT IsGeneralAutofillEnabled([in] BOOL isGeneralAutofillEnabled);
 }
 ```
 ## .NET and WinRT
@@ -108,7 +108,7 @@ namespace Microsoft.Web.WebView2.Core
     public partial class CoreWebView2Settings
     {
         public bool IsPasswordAutofillEnabled { get; set; };
-        public bool IsAddressAutofillEnabled {get; set; };
+        public bool IsGeneralAutofillEnabled {get; set; };
     }
 }