Skip to content

Commit b8df5c5

Browse files
Got great feedback on wording and clarifications
Co-authored-by: David Risney <dave@deletethis.net>
1 parent 971fd1c commit b8df5c5

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

specs/GetFavicon.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,11 @@ webView.CoreWebView2.FaviconChanged += (CoreWebView2 sender, Object arg) =>
5050
};
5151
```
5252
# API Notes
53-
If a Web page does not have a Favicon, then the FaviconChanged event
54-
is fired when the page is navigated to. The Favicon would be an
55-
empty image and empty Uri. The user is expected to handle this scenario.
56-
Otherwise we fire the FaviconChanged with an observed change to the
57-
Favicon. In that scenario, we would provide the Uri of the Favicon we
53+
Note that even if a web page does not have a Favicon, the FaviconChanged event
54+
is raised when the page is navigated to. The Favicon would be an
55+
empty image stream and empty Uri for the lack of a favicon. The end developer is expected to handle this scenario.
56+
Otherwise, we raise the FaviconChanged with an observed change to the
57+
Favicon. In that scenario, the CoreWebView2 has an updated value for the FaviconUri property, and the GetFavicon method to match the updated favicon.
5858
observed and a copy of the image.
5959
See [API Details](#api-details) Section below for API reference
6060
# API Details
@@ -104,7 +104,7 @@ interface ICoreWebView2_10 : ICoreWebView2_9 {
104104
[in] EventRegistrationToken token);
105105

106106
/// Get the current Uri of the favicon as a string.
107-
/// If value is null, the `HRESULT` `E_POINTER`, otherwise it is `S_OK`.
107+
/// If value is null, then the return value is `E_POINTER`, otherwise it is `S_OK`.
108108
/// If a page has no favicon then value is an empty string.
109109
[propget] HRESULT FaviconUri([out, retval] LPWSTR* value);
110110

0 commit comments

Comments
 (0)