Skip to content

Commit e501b5b

Browse files
committed
Review Feedback 3
1 parent 4b9cf65 commit e501b5b

1 file changed

Lines changed: 11 additions & 9 deletions

File tree

specs/CookieManagement.md

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,8 @@ interface ICoreWebView2Cookie : IUnknown {
255255
/// The default is the host that this cookie has been received from.
256256
[propget] HRESULT Domain([out, retval] LPWSTR* domain);
257257
258-
/// The path for which the cookie is valid. If not specified, this cookie
259-
/// will be sent to all pages on the Domain.
258+
/// The path for which the cookie is valid. The default is "/", which means
259+
/// this cookie will be sent to all pages on the Domain.
260260
[propget] HRESULT Path([out, retval] LPWSTR* path);
261261
262262
/// The expiration date and time for the cookie as the number of seconds since the UNIX epoch.
@@ -320,10 +320,11 @@ interface ICoreWebView2CookieManager : IUnknown {
320320
[in] ICoreWebView2GetCookiesCompletedHandler* handler);
321321
322322
/// Adds or updates a cookie with the given cookie data; may overwrite
323-
/// equivalent cookies if they exist.
323+
/// cookies with matching name, domain, and path if they exist.
324324
HRESULT AddOrUpdateCookie([in] ICoreWebView2Cookie* cookie);
325325
326-
/// Deletes a cookie whose params matches those of the specified cookie.
326+
/// Deletes a cookie whose name and domain/path pair
327+
/// match those of the specified cookie.
327328
HRESULT DeleteCookie([in] ICoreWebView2Cookie* cookie);
328329
329330
/// Deletes cookies with matching name and uri.
@@ -410,13 +411,14 @@ namespace Microsoft.Web.WebView2.Core
410411
/// You can modify the cookie objects, call
411412
/// CoreWebView2CookieManager.AddOrUpdateCookie, and the changes
412413
/// will be applied to the webview.
413-
Windows.Foundation.IAsyncOperation<CoreWebView2CookieList> GetCookiesAsync(String uri);
414+
Windows.Foundation.IAsyncOperation<IVectorView> GetCookiesAsync(String uri);
414415

415416
/// Adds or updates a cookie with the given cookie data; may overwrite
416-
/// equivalent cookies if they exist.
417+
/// cookies with matching name, domain, and path if they exist.
417418
void AddOrUpdateCookie(CoreWebView2Cookie cookie);
418419

419-
/// Deletes a cookie whose params matches those of the specified cookie.
420+
/// Deletes a cookie whose name and domain/path pair
421+
/// match those of the specified cookie.
420422
void DeleteCookie(CoreWebView2Cookie cookie);
421423

422424
/// Deletes cookies with matching name and uri.
@@ -459,8 +461,8 @@ namespace Microsoft.Web.WebView2.Core
459461
/// The default is the host that this cookie has been received from.
460462
String Domain { get; };
461463

462-
/// The path for which the cookie is valid. If not specified, this cookie
463-
/// will be sent to all pages on the Domain.
464+
/// The path for which the cookie is valid. The default is "/", which means
465+
/// this cookie will be sent to all pages on the Domain.
464466
String Path { get; };
465467

466468
/// The expiration date and time for the cookie as the number of seconds since the UNIX epoch.

0 commit comments

Comments
 (0)