Skip to content

Commit f37516e

Browse files
Apply suggestions from code review
Co-authored-by: Raymond Chen <oldnewthing@users.noreply.github.com>
1 parent a571ea9 commit f37516e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

specs/IsSmartScreenRequired

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
[Edge SmartScreen](https://docs.microsoft.com/en-us/deployedge/microsoft-edge-security-smartscreen) helps you identify reported phishing and malware websites, and also helps you make informed decisions about downloads.
44

5-
Currently, end developers can use `options->put_AdditionalBrowserArguments(L"--disable-features=msSmartScreenProtection")` to control SmartScreen in the WebView2 application. It is essentially a startup parameter of the browser process. It must be determined when the WebView2Environment is created. And and cannot be modified at runtime.
5+
Currently, developers can use `options->put_AdditionalBrowserArguments(L"--disable-features=msSmartScreenProtection")` to disable SmartScreen in the WebView2 application. It is essentially a startup parameter of the browser process and applies to all WebView2 instances associated with that WebView2Environment. It must be determined when the WebView2Environment is created, and it cannot be modified at runtime.
66

77
To support more flexibility we introduce a new API.
88
We initially considered an API like `CoreWebView2Environment.IsSmartScreenEnabled` that would directly change the value for all the processes. The problem is this is not easy to do for apps like Office who have multiple apps connected to the same browser process. In their case each app has IsSmartScreenEnabled and its hard for the browser process to know which change to the property should win.
@@ -14,7 +14,7 @@ In this document we describe the new setting. We'd appreciate your feedback.
1414

1515

1616
# Description
17-
You can use CoreWebView2Settings.IsSmartScreen to control SmartScreen. SmartScreen is enabled or disabled per browser process, so all WebView2 applications sharing the same user data folder path also share SmartScreen being enabled or disabled.
17+
You can use CoreWebView2Settings.IsSmartScreenRequired to control SmartScreen. SmartScreen is enabled or disabled per browser process, so all WebView2 applications sharing the same user data folder path also share SmartScreen being enabled or disabled.
1818
If CoreWebView2Setting.IsSmartScreenRequired is true for any CoreWebView2 in its associated CoreWebView2Environment, then SmartScreen is enabled. If CoreWebView2Setting.IsSmartScreenRequired is false for all CoreWebView2s in their CoreWebView2Environment, then SmartScreen is disabled.
1919
The default value for `IsSmartScreenRequired` is true if SmartScreen is enabled when the CoreWebView2 is created and false if SmartScreen is disabled when the CoreWebView2 is created. The value doesn't change if SmartScreen is enabled or disabled later.
2020

@@ -62,7 +62,7 @@ interface ICoreWebView2Settings11 : ICoreWebView2Settings10 {
6262
/// and also helps you make informed decisions about downloads.
6363
/// `IsSmartScreenRequired` is used to control whether SmartScreen enabled or not.
6464
/// SmartScreen is enabled or disabled for all CoreWebView2s in a CoreWebView2Environment.
65-
/// If CoreWebView2Setting.IsSmartScreenRequired is true for any CoreWebView2 in its associated
65+
/// If CoreWebView2Setting.IsSmartScreenRequired is true for any CoreWebView2 associated to the same
6666
/// CoreWebView2Environment, then SmartScreen is enabled. If CoreWebView2Setting.IsSmartScreenRequired
6767
/// is false for all CoreWebView2s in the associated CoreWebView2Environment, then SmartScreen is disabled.
6868
/// When it is changed, the change will be applied to all WebViews using the

0 commit comments

Comments
 (0)