fix(Battleship): errors in utils, game, and board

utils - fixed circular import

game - fixed place_ships duplicated code

board - fixed and added checks for hit or missed

Author: ca20110820

projects/Battleship/board.py

@@ -222,6 +222,12 @@ def which_ship(self, row: int, col: int) -> None | Ship:
 
     def enemy_move(self, row: int, col: int) -> None:
         """Performs an enemy's move."""
+
+        # Check if the coordinate is already a hit or missed.
+        board = self.get_board_for_enemy()
+        if board[row][col] in [self._enemy_pov_labels.hit, self._enemy_pov_labels.missed]:
+            raise BoardException(f"The given coordinate ({row}, {col}) already has {board[row][col]}.")
+
         ship: None | Ship = self.which_ship(row, col)
 
         if isinstance(ship, Ship):

projects/Battleship/game.py

@@ -291,5 +291,3 @@ def place_ships(self):
         """Randomly place ships for both players."""
         self.player_1.generate_random_ship_arrangements()
         self.player_2.generate_random_ship_arrangements()
-        self.player_1.generate_random_ship_arrangements()
-        self.player_2.generate_random_ship_arrangements()

projects/Battleship/utils.py

@@ -2,7 +2,6 @@
 import random
 
 from ship import Ship
-from player import Player
 from board import Board
 
 
@@ -239,7 +238,7 @@ def attack_prompt(board_size: int,
 
 class PrintMixin:
     @staticmethod
-    def print_player_board(player: Player, other_player: Player) -> None:
+    def print_player_board(player, other_player) -> None:
         """
         Print the current battlefield situation and targets for the specified player.