Skip to content

Commit 110bcbe

Browse files
ci(merge-queue): run essential checks on merge groups (#638)
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
1 parent 967f808 commit 110bcbe

10 files changed

Lines changed: 30 additions & 3 deletions

File tree

‎.github/workflows/codeql.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
name: "CodeQL"
1313

1414
on:
15+
merge_group:
16+
types: [checks_requested]
1517
push:
1618
branches: [ "main", "[rv][0-9]*", "pull-request/**"]
1719
schedule:

‎.github/workflows/copyright-check.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
name: Copyright check
1616

1717
on:
18+
merge_group:
19+
types: [checks_requested]
1820
push:
1921
branches: ["pull-request/**"]
2022
workflow_dispatch:

‎.github/workflows/detect-secrets.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414
name: Secrets detector
1515

1616
on:
17+
merge_group:
18+
types: [checks_requested]
1719
push:
1820
branches: ["pull-request/**"]
1921

‎.github/workflows/install.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
name: Run install
22

33
on:
4+
merge_group:
5+
types: [checks_requested]
46
workflow_dispatch:
57
workflow_call:
68
push:

‎.github/workflows/release.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414
name: "Build, validate, and release NeMo Run"
1515

1616
on:
17+
merge_group:
18+
types: [checks_requested]
1719
push:
1820
branches:
1921
- "main"

‎.github/workflows/ruff-format.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
name: Ruff format
22

33
on:
4+
merge_group:
5+
types: [checks_requested]
46
workflow_dispatch:
57
workflow_call:
68
push:

‎.github/workflows/ruff-lint.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
name: Ruff lint
22

33
on:
4+
merge_group:
5+
types: [checks_requested]
46
workflow_dispatch:
57
workflow_call:
68
push:

‎.github/workflows/spelling.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
name: Spelling
22

33
on:
4+
merge_group:
5+
types: [checks_requested]
46
workflow_dispatch:
57
push:
68
branches: [main, "pull-request/**"]

‎.github/workflows/test.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
name: Run tests
22

33
on:
4+
merge_group:
5+
types: [checks_requested]
46
workflow_dispatch:
57
workflow_call:
68
push:

‎CONTRIBUTING.md‎

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,18 @@ does not define a trustee override.
9999
The NVIDIA copy-pr-bot GitHub App must be installed and enabled for this repository.
100100

101101
Tests, installation, lint, formatting, spelling, copyright, secret detection,
102-
CodeQL, and release validation run on the mirror push. Release publishing still
103-
requires manual dispatch. Maintainers should verify checks on the mirror commit
104-
before merging.
102+
CodeQL, and release validation run on the mirror push and on
103+
`merge_group` events with type `checks_requested`. Merge-queue runs check the
104+
queue's temporary merge commit using the same jobs and check names as push CI;
105+
the unit tests, example notebooks/scripts, and full installation matrix are
106+
included. Release publishing still requires manual dispatch.
107+
108+
After these workflows are available on the target branch, a repository admin
109+
must enable **Require merge queue** in that branch's protection rule or ruleset.
110+
Keep the essential CI checks required so the queue waits for their results on
111+
the merge-group commit. Workflow changes alone do not enable the repository
112+
setting. Maintainers should verify checks on the mirror commit before enqueueing
113+
and on the merge-group commit before merging.
105114

106115
## Sign Your Work
107116

0 commit comments

Comments
 (0)