Skip to content

Commit 73f64b4

Browse files
committed
Corrected comments regarding the error estimator in MPRK22
1 parent b74059b commit 73f64b4

1 file changed

Lines changed: 6 additions & 9 deletions

File tree

src/mprk.jl

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -494,9 +494,8 @@ function perform_step!(integrator, cache::MPRK22ConstantCache, repeat_step = fal
494494
u = sol.u
495495
integrator.stats.nsolve += 1
496496

497-
# If a21 = 1.0, then σ is the MPE approximation, i.e. a first order approximation
498-
# of the solution, and can be used for error estimation. Moreover, MPE is suited for stiff problems.
499-
# TODO: Find first order approximation if a21≠ 1.0.
497+
# If a21 = 1, then σ is the MPE approximation, i.e. suited for stiff problems.
498+
# Otherwise, this is not clear.
500499
tmp = u - σ
501500
atmp = calculate_residuals(tmp, uprev, u, integrator.opts.abstol,
502501
integrator.opts.reltol, integrator.opts.internalnorm, t)
@@ -634,9 +633,8 @@ function perform_step!(integrator, cache::MPRK22Cache, repeat_step = false)
634633
integrator.stats.nsolve += 1
635634

636635
# Now σ stores the error estimate
637-
# If a21 = 1.0, then σ is the MPE approximation, i.e. a first order approximation
638-
# of the solution, and can be used for error estimation. Moreover, MPE is suited for stiff problems.
639-
# TODO: Find first order approximation if a21≠ 1.0.
636+
# If a21 = 1, then σ is the MPE approximation, i.e. suited for stiff problems.
637+
# Otherwise, this is not clear.
640638
@.. broadcast=false σ=u - σ
641639

642640
# Now tmp stores error residuals
@@ -694,9 +692,8 @@ function perform_step!(integrator, cache::MPRK22ConservativeCache, repeat_step =
694692
integrator.stats.nsolve += 1
695693

696694
# Now σ stores the error estimate
697-
# If a21 = 1.0, then σ is the MPE approximation, i.e. a first order approximation
698-
# of the solution, and can be used for error estimation. Moreover, MPE is suited for stiff problems.
699-
# TODO: Find first order approximation if a21≠ 1.0.
695+
# If a21 = 1, then σ is the MPE approximation, i.e. suited for stiff problems.
696+
# Otherwise, this is not clear.
700697
@.. broadcast=false σ=u - σ
701698

702699
# Now tmp stores error residuals

0 commit comments

Comments
 (0)