Skip to content

Commit 1f2d5a3

Browse files
authored
Update fp-007-relations.md
Added the 'what to do, when' list discussed and approved by the Ops committee. Note that Examples and Counter-Examples still need to be added (will be done under a separate PR)
1 parent 0ebddb3 commit 1f2d5a3

1 file changed

Lines changed: 19 additions & 1 deletion

File tree

principles/fp-007-relations.md

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,26 @@ submitted to the [RO tracker](https://github.com/oborel/obo-relations/issues).
3030

3131
Reuse means that the actual relations PURLs are used. Ontology developers should be aware that RO relations (in rare instances) can evolve over time and previous relations might become obsolete. This means developers should monitor the state of the RO relations they use.
3232

33+
- If the domain of the proposed relation is a class in the same ontology as that relation, it is fine to keep in the ontology; if a suitable RO parent exists, the new relation MUST be declared a sub-property of that parent.
34+
- If the domain of the proposed relation is a class outside of the ontology defining that relation, the relation MUST be added to RO.
35+
- If the relation seems generally usable (that is, could potentially be used by other ontologies), the relation MUST be added to RO.
36+
- If there are any doubts about how to proceed based on the above, there SHOULD be an attempt to add to RO.
37+
- It is never a bad idea to add to RO, even for those relations that are 'self-contained' (as described in the first bullet point).
38+
39+
Note regarding property chains: If a proposed property chain makes use of relations that are themselves in RO, the property chain SHOULD be submitted to RO.
40+
3341
## Examples
3442

3543
## Counter-Examples
3644

37-
<Category:Principles> <Category:Accepted> <Category:Definitions>
45+
## Criteria for Review
46+
47+
Each relation in the ontology that does not use an RO IRI will be checked to see if there is an exact label match in RO. If so, this will be flagged as an ERROR. Any other non-RO properties will be flagged with an INFO message.
48+
49+
[This check is automatically validated.](checks/fp_007)
50+
51+
## Feedback and Discussion
52+
53+
To suggest revisions or begin a discussion pertaining to this principle, please [create an issue on GitHub](https://github.com/OBOFoundry/OBOFoundry.github.io/issues/new?labels=attn%3A+Editorial+WG,principles&title=Principle+%237+%22Relations%22+%3CENTER+ISSUE+TITLE%3E).
54+
55+
To suggest revisions or begin a discussion pertaining to the automated validation of this principle, please [create an issue on GitHub](https://github.com/OBOFoundry/OBOFoundry.github.io/issues/new?labels=attn%3A+Technical+WG,automated+validation+of+principles&title=Principle+%237+%22Relations%22+-+automated+validation+%3CENTER+ISSUE+TITLE%3E).

0 commit comments

Comments
 (0)