Skip to content

Commit 4102b03

Browse files
authored
Merge branch 'master' into nataled-patch-2
2 parents c9fddd2 + bcb6b77 commit 4102b03

7 files changed

Lines changed: 1239 additions & 1091 deletions

File tree

_config.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4486,11 +4486,12 @@ ontologies:
44864486
- description: OBA terms are used by the NHGRI-EBI GWAS Catalog for phenotypic trait
44874487
annotation.
44884488
examples:
4489-
- description: age of onset of depressive disorder
4490-
url: https://www.ebi.ac.uk/gwas/efotraits/OBA_2040166
4489+
- description: hip circumference
4490+
url: https://www.ebi.ac.uk/gwas/efotraits/OBA_1000032
44914491
publications:
4492-
- id: https://doi.org/10.1093/nar/gkac1010
4493-
title: 'The NHGRI-EBI GWAS Catalog: knowledgebase and deposition resource'
4492+
- id: https://doi.org/10.1093/nar/gkae1070
4493+
title: 'The NHGRI-EBI GWAS Catalog: standards for reusability, sustainability
4494+
and diversity'
44944495
type: annotation
44954496
user: https://www.ebi.ac.uk/gwas/
44964497
- description: OBA trait terms facilitate computational drug target identification

_data/operations.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ members:
198198
orcid: 0000-0002-8688-6599
199199
wikidata: Q37649212
200200
- affiliation:
201-
name: National Institutes of Health (NIH)
201+
name: Independent Volunteer
202202
ror: 01cwqze88
203203
country: USA
204204
github: LK112019

ontology/oba.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@ tracker: https://github.com/obophenotype/bio-attribute-ontology/issues
2727
usages:
2828
- description: OBA terms are used by the NHGRI-EBI GWAS Catalog for phenotypic trait annotation.
2929
examples:
30-
- description: age of onset of depressive disorder
31-
url: https://www.ebi.ac.uk/gwas/efotraits/OBA_2040166
30+
- description: hip circumference
31+
url: https://www.ebi.ac.uk/gwas/efotraits/OBA_1000032
3232
publications:
33-
- id: https://doi.org/10.1093/nar/gkac1010
34-
title: 'The NHGRI-EBI GWAS Catalog: knowledgebase and deposition resource'
33+
- id: https://doi.org/10.1093/nar/gkae1070
34+
title: 'The NHGRI-EBI GWAS Catalog: standards for reusability, sustainability and diversity'
3535
type: annotation
3636
user: https://www.ebi.ac.uk/gwas/
3737
- description: OBA trait terms facilitate computational drug target identification via the Open Targets Platform.
Lines changed: 146 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,146 @@
1+
---
2+
layout: principle
3+
id: fp-019-term-stability
4+
title: Stability of Term Meaning (principle 19)
5+
---
6+
7+
GO TO: [Recommendations/Requirements](#recommendations-and-requirements) | [Implementation](#implementation) | [Examples/Counter‑Examples](#examples) | [Criteria for Review](#criteria-for-review) | [Feedback/Discussion](#feedback-and-discussion)
8+
9+
Summary
10+
-------
11+
12+
The definition of a term MUST always denote the same thing(s)--known as "referent(s)"--in reality. If a proposed change to the definition would substantially change its referents, then a new term with new IRI and definition MUST instead be created.
13+
14+
Purpose
15+
-------
16+
17+
Users of an ontology depend on the stability of its terms and their meanings. Therefore, changes to the definition of a term should never substantially shift its meaning. Put another way, its set of referents MUST remain stable, within reason. That is, changes to a term definition--or any mechanism to denote meaning, including elucidations and logical axioms--should not cause that term to point to different entities than it denotes already.
18+
19+
Recommendations and Requirements
20+
-------
21+
22+
Below, we use 'definition' to encompass all possible mechanisms to denote term meaning, as described above.
23+
24+
If changing a term definition would change its referents, then instead a new term MUST be created with a new IRI and the new definition. Minor changes to the definition for clarity, grammar, and/or proper punctuation that do not change the referents are permitted. What is considered a 'minor change' will likely need to be evaluated on a case-by-case basis; it is left to the ontology developers to decide. However, any feedback from users MUST be taken into account.
25+
26+
The creation of a new term/definition implies that the old term should possibly be deprecated/obsoleted. Conditions under which a term MUST be deprecated according to this principle, or for which term deprecation SHOULD be considered, include:
27+
28+
1) The old textual definition misses the target(s) intended by the ontology developers. This includes cases where the term refers to non-existent referents (as might happen, for example, when new research reveals that the referent does not exist in reality).
29+
1) The original term definition is considered sufficiently “damaged” (too vague, too restrictive, too misused or too misunderstood).
30+
31+
In all cases the developers SHOULD provide guidance on how to handle deprecated terms (either by exact replacement or by considering other terms), and be mindful of the potential costs to users of the ontology who might use the existing term. As well, developers SHOULD pre-announce term obsoletions. See [Principle 13](http://obofoundry.org/principles/fp-013-notification.html) for guidance on such announcements.
32+
33+
Implementation
34+
-------
35+
36+
Detailed procedures for obsoleting a term are described on the OBO Academy page [Obsoleting an Existing Ontology Term](https://oboacademy.github.io/obook/howto/obsolete-term/).
37+
38+
<i><b>To obsolete a term, the ontology developer</b></i> MUST:
39+
1) Mark the term as obsolete
40+
- OWL format: Add an "owl:deprecated" annotation property with value of "true^xsd:boolean"
41+
- OBO format: Add an "is_obsolete: true" tag
42+
2) Prepend the string "obsolete " (including the space) to the term label <i>and</i> the `editor preferred term` (IAO:0000111), if present
43+
- NOTE: To be consistent with [Principle 12](https://obofoundry.org/principles/fp-012-naming-conventions.html) "Naming Conventions", the syntax/format MUST be precisely as given above (that is, the exact string as shown, lowercase and space included, with no other punctuation before or after). Thus, the following are disallowed: "Obsolete {label}", "obsolete_{label}", "OBSOLETE {label}" (and variations thereof).
44+
3) Remove all existing logical axioms from the term
45+
4) Remove or replace all usages of the term elsewhere in the ontology. For example, if an ontology has A part-of B, and B has been deprecated with replacement by C, then the corrected axiom would be A part-of C. Likewise, if A part-of B, and B part-of C, if B is deprecated, then any part-of axiom involving B MUST be removed; that is, by stating instead A part-of C.
46+
47+
It is not necessary (and not advisable) to delete the textual definition.
48+
49+
<i><b>To obsolete a term, the ontology developer</b></i> SHOULD:
50+
1) Indicate any exact term replacement:
51+
- OWL: Use the `term replaced by` annotation property from OMO ([IAO:0100001](http://purl.obolibrary.org/obo/IAO_0100001)) with the value set to the IRI of the relevant term
52+
- OBO: Use the `replaced_by:` tag with the value set to the CURIE of the relevant term
53+
2) Indicate any inexact term replacements:
54+
- OWL: Use the `oboInOwl:consider` annotation property with the value set to the full IRI(s) of the relevant term(s)
55+
```
56+
<oboInOwl:consider rdf:resource="http://purl.obolibrary.org/obo/OBI_0001544")>
57+
```
58+
59+
- OBO: Use the `consider:` tag with the value set to the CURIE(s) of the relevant term(s)
60+
```
61+
consider: OBI:0001544
62+
```
63+
64+
Note that some older implementations in OWL used the CURIE method as shown below, but this is not preferred.
65+
66+
```
67+
<oboInOwl:consider rdf:datatype="http://www.w3.org/2001/XMLSchema#string">OBI:0001544</oboInOwl:consider>
68+
```
69+
<i><b>To obsolete a term, the ontology developer</b></i> MAY:
70+
71+
1) Prepend the string "OBSOLETE. " (this precise string, including the space) to the term definition. NOTE: This MUST be implemented consistently. That is, if applied at all, it has to be applied to every obsoleted term definition.
72+
2) Indicate the reason(s) for obsoleting:
73+
- OWL: Use the `has obsolescence reason` annotation property from OMO ([IAO:0000231](http://purl.obolibrary.org/obo/IAO_0000231)) with the value set to the IRI of one of the individuals of the "obsolescence reason specification" term [IAO:0000225](http://purl.obolibrary.org/obo/IAO_0000225). See below for example.
74+
- OBO: Use `relationship:` with the CURIE for the annotation property (IAO:0000231) and a CURIE for the specific reason (an individual from the "obsolescence reason specification" term [IAO:0000225](http://purl.obolibrary.org/obo/IAO_0000225)). See below for example. Note that older implementations often used alternative methods (described after the examples). These methods are still valid, but are not preferred.
75+
76+
Examples
77+
-------
78+
79+
The Ontology for Biomedical Investigations obsolete term "cell lysate MHC competitive binding assay using radioactivity detection" (OBI:0001574) can be deprecated as follows:
80+
81+
OWL:
82+
```
83+
<owl:Class rdf:about="http://purl.obolibrary.org/obo/OBI_0001574">
84+
<obo:IAO_0000111>obsolete cell lysate MHC competitive binding assay using radioactivity detection</obo:IAO_0000111>
85+
<obo:IAO_0000115>Competitive inhibition of binding assay measuring MHC ligand binding by radioactivity detection using MHC derived from a cell lysate</obo:IAO_0000115>
86+
<obo:IAO_0000231 rdf:resource="http://purl.obolibrary.org/obo/IAO_0000227"/>
87+
<obo:IAO_0100001 rdf:resource="http://purl.obolibrary.org/obo/OBI_0001544"/>
88+
<rdfs:label>obsolete cell lysate MHC competitive binding assay using radioactivity detection</rdfs:label>
89+
<owl:deprecated rdf:datatype="http://www.w3.org/2001/XMLSchema#boolean">true</owl:deprecated>
90+
</owl:Class>
91+
```
92+
93+
OBO:
94+
```
95+
[Term]
96+
id: OBI:0001574
97+
name: obsolete cell lysate MHC competitive binding assay using radioactivity detection
98+
def: "OBSOLETE. Competitive inhibition of binding assay measuring MHC ligand binding by radioactivity detection using MHC derived from a cell lysate." []
99+
relationship: IAO:0000231 IAO:0000227
100+
is_obsolete: true
101+
replaced_by: OBI:0001544
102+
```
103+
Obsolescence reasons have, historically, been indicated multiple ways. In addition to the preferred methods shown above, the following alternatives are in current use:
104+
1) As a free text comment (`rdfs:comment` in OWL or `comment:` in OBO).
105+
1) In OBO format, using a `property_value:` tag instead of a `relationship:` tag.
106+
1) In OBO format, using an annotation property label-as-identifier (with underscores) instead of the CURIE `IAO:0000231`, and the obsolescence reason label instead of the relevant CURIE. Note that the underscore version of the property label will need to be created in the ontology:
107+
```
108+
[Typedef]
109+
id: has_obsolescence_reason
110+
name: has obsolescence reason
111+
xref: IAO:0000231
112+
is_metadata_tag: true
113+
```
114+
Then:
115+
```
116+
relationship: has_obsolescence_reason IAO:0000227 ! terms merged
117+
```
118+
Or:
119+
```
120+
property_value: has_obsolescence_reason IAO:0000227
121+
```
122+
123+
Counter-example
124+
-------
125+
126+
The PRO term "phosphoprotein" (PR:000037070) is defined as "A protein that includes at least one phosphorylated residue." A study finds 2000 more examples than was previously known. In this case, no new term needs to be made (nor the original deleted) because (1) the term definition did not change; and (2) the referent--proteins with a phophoresidue--did not change (that is, the newly-discovered phosphoproteins are just additional examples of that referent).
127+
128+
Criteria for review
129+
-------
130+
131+
The OBO Dashboard will show:
132+
- An ERROR if any obsolete term (that is, a term with an `owl:deprecated` property or `is_obsolete: true` tag) does not also have 'obsolete ' (that exact string, lowercase and space included, with no other punctuation) prepended to the label
133+
- An ERROR if any obsolete term (as indicated by term label or definition) lacks an `owl:deprecated` property or `is_obsolete: true` tag
134+
- An ERROR if an obsolete term has, itself, any logical axioms (including any subClassOf/is_a declarations) or if it is referenced by logical axioms from other terms
135+
- A WARN if there is at least one term with 'OBSOLETE. ' prepended to the definition but not all obsolete terms are likewise prepended
136+
137+
[This check is automatically validated.](checks/fp_019)
138+
139+
Feedback and Discussion
140+
-------
141+
142+
To suggest revisions or begin a discussion pertaining to this principle, please [create an issue on GitHub](https://github.com/OBOFoundry/OBOFoundry.github.io/issues/new?labels=attn%3A+Editorial+WG,principles&title=Principle+%2319+%22Stability%22of%22Term%22Meaning%22+%3CENTER+ISSUE+TITLE%3E).
143+
144+
To suggest revisions or begin a discussion pertaining to the automated validation of this principle, please [create an issue on GitHub]().
145+
146+
See also [this discussion](https://github.com/OBOFoundry/OBOFoundry.github.io/issues/597) by the OBO Foundry Operations Committee focusing on term deprecation and [this discussion](https://github.com/OBOFoundry/OBOFoundry.github.io/issues/964) regarding the proposal of this principle.

registry/ontologies.jsonld

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6254,14 +6254,14 @@
62546254
"description": "OBA terms are used by the NHGRI-EBI GWAS Catalog for phenotypic trait annotation.",
62556255
"examples": [
62566256
{
6257-
"description": "age of onset of depressive disorder",
6258-
"url": "https://www.ebi.ac.uk/gwas/efotraits/OBA_2040166"
6257+
"description": "hip circumference",
6258+
"url": "https://www.ebi.ac.uk/gwas/efotraits/OBA_1000032"
62596259
}
62606260
],
62616261
"publications": [
62626262
{
6263-
"id": "https://doi.org/10.1093/nar/gkac1010",
6264-
"title": "The NHGRI-EBI GWAS Catalog: knowledgebase and deposition resource"
6263+
"id": "https://doi.org/10.1093/nar/gkae1070",
6264+
"title": "The NHGRI-EBI GWAS Catalog: standards for reusability, sustainability and diversity"
62656265
}
62666266
],
62676267
"type": "annotation",

0 commit comments

Comments
 (0)