Update HttpSourceResourceProvider to create a new HttpClient when the credentials change (#16)

Added Credentials to the equality comparer for PackageSource so that when HttpSourceResourceProvider caches HttpClients, it creates a new client when the credentials change. Previously it was returning the same HttpClient (which already has credentials set) regardles of the PackageSource.Credentails value.

This was a re-implementation of dd0d988#diff-2e2f5bc7aba32eb58bd35315bbc3322399bbf8efd6e84fe7ef1bd95b45dab6a3

Author: enf0rc3

src/NuGet.Core/NuGet.Configuration/PackageSource/PackageSource.cs

@@ -186,7 +186,8 @@ public bool Equals(PackageSource? other)
             }
 
             return Name.Equals(other.Name, StringComparison.CurrentCultureIgnoreCase) &&
-                   Source.Equals(other.Source, StringComparison.OrdinalIgnoreCase);
+                   Source.Equals(other.Source, StringComparison.OrdinalIgnoreCase) &&
+                   Equals(Credentials, other.Credentials);
         }
 
         public override bool Equals(object? obj)

test/NuGet.Core.Tests/NuGet.Configuration.Test/PackageSourceTests.cs

@@ -120,5 +120,33 @@ public void CalculatedMembers_ChangingSource_UpdatesValues()
             source.IsLocal.Should().BeTrue();
             source.GetHashCode().Should().NotBe(hashCodeBefore);
         }
+
+        [Fact]
+        public void Equals_WithDifferentCredentials_AreNotEqual()
+        {
+            var a = CreateSourceForPasswordEquality("Foo");
+            var b = CreateSourceForPasswordEquality("Bar");
+
+            Assert.NotEqual(a, b);
+        }
+
+        [Fact]
+        public void Equals_WithSameCredentials_AreEqual()
+        {
+            var a = CreateSourceForPasswordEquality("Foo");
+            var b = CreateSourceForPasswordEquality("Foo");
+
+            Assert.Equal(a, b);
+        }
+        private static PackageSource CreateSourceForPasswordEquality(string password)
+        {
+            var credentials = new PackageSourceCredential("SourceName", "username", password, isPasswordClearText: false, null);
+            var source = new PackageSource("Source", "SourceName", isEnabled: false)
+            {
+                Credentials = credentials,
+                ProtocolVersion = 43
+            };
+            return source;
+        }
     }
 }

test/NuGet.Core.Tests/NuGet.Protocol.Tests/HttpSourceResourceProviderTests.cs

@@ -62,5 +62,50 @@ public async Task WhenMaxHttpRequestsPerSourceIsConfiguredThenItsValueWillNotBeU
             Assert.NotNull(httpSourceResource);
             Assert.Equal(maxHttpRequestsPerSource, sourceRepository.PackageSource.MaxHttpRequestsPerSource);
         }
+
+        [Fact]
+        public async Task WhenSourceRepositoryHasDifferentCredentialsPassword_ReturnsDifferentHttpSourceResources()
+        {
+            // Arrange
+            var sourceRepositoryA = CreateSourceRepositoryForPasswordEquality("Foo");
+            var sourceRepositoryB = CreateSourceRepositoryForPasswordEquality("Bar");
+
+            // Act
+            var provider = new HttpSourceResourceProvider();
+            var a = await provider.TryCreate(sourceRepositoryA, CancellationToken.None);
+            var b = await provider.TryCreate(sourceRepositoryB, CancellationToken.None);
+
+            // Assert
+            Assert.NotSame(a.Item2, b.Item2);
+        }
+
+        [Fact]
+        public async Task WhenSourceRepositoryHasTheSameCredentialsPassword_ReturnsTheSameHttpSourceResource()
+        {
+            // Arrange
+            var sourceRepositoryA = CreateSourceRepositoryForPasswordEquality("Foo");
+            var sourceRepositoryB = CreateSourceRepositoryForPasswordEquality("Foo");
+
+            // Act
+            var provider = new HttpSourceResourceProvider();
+            var a = await provider.TryCreate(sourceRepositoryA, CancellationToken.None);
+            var b = await provider.TryCreate(sourceRepositoryB, CancellationToken.None);
+
+            // Assert
+            Assert.Same(a.Item2, b.Item2);
+        }
+
+        private SourceRepository CreateSourceRepositoryForPasswordEquality(string password)
+        {
+            return new SourceRepository(
+                new PackageSource(_testPackageSourceURL)
+                {
+                    Credentials = new PackageSourceCredential(_testPackageSourceURL, "user", password, true, null)
+                },
+                [
+                    new HttpSourceResourceProvider()
+                ]
+            );
+        }
     }
 }