Skip to content

Commit 105ce99

Browse files
amakhrovmacjohnny
authored andcommitted
[typescript-angular] Import models from a single model/models.ts (#5128)
* Make api to models from a single model/models.ts instead of individual model files. Fixes inconsistent usage of file names with inline models (inline-model-1, inline-model-2, ...) * Remove additional mapped filename prop from api imports (since it's not reliable) * Rerun ./bin/typescript-angular-petstore-all.sh * Restore the `filename` property passed to the templates, with a comment it's no longer used
1 parent ab5f224 commit 105ce99

54 files changed

Lines changed: 71 additions & 70 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/TypeScriptAngularClientCodegen.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -451,6 +451,7 @@ public Map<String, Object> postProcessOperationsWithModels(Map<String, Object> o
451451
// Add additional filename information for model imports in the services
452452
List<Map<String, Object>> imports = (List<Map<String, Object>>) operations.get("imports");
453453
for (Map<String, Object> im : imports) {
454+
// This property is not used in the templates any more, subject for removal
454455
im.put("filename", im.get("import"));
455456
im.put("classname", im.get("classname"));
456457
}

modules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import '../rxjs-operators';
2424
{{/useHttpClient}}
2525

2626
{{#imports}}
27-
import { {{classname}} } from '../{{filename}}';
27+
import { {{classname}} } from '../model/models';
2828
{{/imports}}
2929

3030
import { BASE_PATH, COLLECTION_FORMATS } from '../variables';

modules/openapi-generator/src/main/resources/typescript-angular/apiInterface.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import { Observable } from 'rxjs';
1414
{{/useRxJS6}}
1515

1616
{{#imports}}
17-
import { {{classname}} } from '../{{filename}}';
17+
import { {{classname}} } from '../model/models';
1818
{{/imports}}
1919

2020

samples/client/petstore/typescript-angular-v2/default/api/pet.service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ import { CustomQueryEncoderHelper } from '../encoder';
1919
import { Observable } from 'rxjs/Observable';
2020
import '../rxjs-operators';
2121

22-
import { ApiResponse } from '../model/apiResponse';
23-
import { Pet } from '../model/pet';
22+
import { ApiResponse } from '../model/models';
23+
import { Pet } from '../model/models';
2424

2525
import { BASE_PATH, COLLECTION_FORMATS } from '../variables';
2626
import { Configuration } from '../configuration';

samples/client/petstore/typescript-angular-v2/default/api/store.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import { CustomQueryEncoderHelper } from '../encoder';
1919
import { Observable } from 'rxjs/Observable';
2020
import '../rxjs-operators';
2121

22-
import { Order } from '../model/order';
22+
import { Order } from '../model/models';
2323

2424
import { BASE_PATH, COLLECTION_FORMATS } from '../variables';
2525
import { Configuration } from '../configuration';

samples/client/petstore/typescript-angular-v2/default/api/user.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import { CustomQueryEncoderHelper } from '../encoder';
1919
import { Observable } from 'rxjs/Observable';
2020
import '../rxjs-operators';
2121

22-
import { User } from '../model/user';
22+
import { User } from '../model/models';
2323

2424
import { BASE_PATH, COLLECTION_FORMATS } from '../variables';
2525
import { Configuration } from '../configuration';

samples/client/petstore/typescript-angular-v2/npm/api/pet.service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ import { CustomQueryEncoderHelper } from '../encoder';
1919
import { Observable } from 'rxjs/Observable';
2020
import '../rxjs-operators';
2121

22-
import { ApiResponse } from '../model/apiResponse';
23-
import { Pet } from '../model/pet';
22+
import { ApiResponse } from '../model/models';
23+
import { Pet } from '../model/models';
2424

2525
import { BASE_PATH, COLLECTION_FORMATS } from '../variables';
2626
import { Configuration } from '../configuration';

samples/client/petstore/typescript-angular-v2/npm/api/store.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import { CustomQueryEncoderHelper } from '../encoder';
1919
import { Observable } from 'rxjs/Observable';
2020
import '../rxjs-operators';
2121

22-
import { Order } from '../model/order';
22+
import { Order } from '../model/models';
2323

2424
import { BASE_PATH, COLLECTION_FORMATS } from '../variables';
2525
import { Configuration } from '../configuration';

samples/client/petstore/typescript-angular-v2/npm/api/user.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import { CustomQueryEncoderHelper } from '../encoder';
1919
import { Observable } from 'rxjs/Observable';
2020
import '../rxjs-operators';
2121

22-
import { User } from '../model/user';
22+
import { User } from '../model/models';
2323

2424
import { BASE_PATH, COLLECTION_FORMATS } from '../variables';
2525
import { Configuration } from '../configuration';

samples/client/petstore/typescript-angular-v2/with-interfaces/api/pet.service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ import { CustomQueryEncoderHelper } from '../encoder';
1919
import { Observable } from 'rxjs/Observable';
2020
import '../rxjs-operators';
2121

22-
import { ApiResponse } from '../model/apiResponse';
23-
import { Pet } from '../model/pet';
22+
import { ApiResponse } from '../model/models';
23+
import { Pet } from '../model/models';
2424

2525
import { BASE_PATH, COLLECTION_FORMATS } from '../variables';
2626
import { Configuration } from '../configuration';

0 commit comments

Comments
 (0)