[go-server] fix imports with go generation (#18514)

* fix imports with go generation

* Wrong copy over

* Missing new line

* tab vs space

* Fix new line between router and std go libs

* Add both use case, add samples to CI validation

* Update samples

Author: darkrift

.github/workflows/samples-go.yaml

@@ -1,20 +1,22 @@
-name: Samples Go 
+name: Samples Go
 
 on:
   push:
     paths:
       - 'samples/server/petstore/go-echo-server/**'
       - 'samples/server/petstore/go-api-server/**'
       - 'samples/server/petstore/go-chi-server/**'
+      - 'samples/server/others/go-server/no-body-path-params/**'
   pull_request:
     paths:
       - 'samples/server/petstore/go-echo-server/**'
       - 'samples/server/petstore/go-api-server/**'
       - 'samples/server/petstore/go-chi-server/**'
+      - 'samples/server/others/go-server/no-body-path-params/**'
 
 jobs:
   build:
-    name: Build Go 
+    name: Build Go
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
@@ -23,6 +25,7 @@ jobs:
           - samples/server/petstore/go-echo-server/
           - samples/server/petstore/go-api-server/
           - samples/server/petstore/go-chi-server/
+          - samples/server/others/go-server/no-body-path-params/
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5

bin/configs/go-server-no-body-path-params.yaml

@@ -0,0 +1,8 @@
+generatorName: go-server
+outputDir: samples/server/others/go-server/no-body-path-params
+inputSpec: modules/openapi-generator/src/test/resources/3_0/go-server/no-body-path-params.yaml
+templateDir: modules/openapi-generator/src/main/resources/go-server
+additionalProperties:
+  hideGenerationTimestamp: "true"
+  packageName: petstoreserver
+  addResponseHeaders: true

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/GoServerCodegen.java

@@ -398,9 +398,29 @@ public OperationsMap postProcessOperationsWithModels(OperationsMap objs, List<Mo
             }
         }
 
+        this.addConditionalImportInformation(objs);
+
         return objs;
     }
 
+    private void addConditionalImportInformation(OperationsMap operations) {
+        boolean hasPathParams = false;
+        boolean hasBodyParams = false;
+
+        for (CodegenOperation op : operations.getOperations().getOperation()) {
+            if (op.getHasPathParams()) {
+                hasPathParams = true;
+            }
+            if (op.getHasBodyParam()) {
+                hasBodyParams = true;
+            }
+        }
+
+        additionalProperties.put("hasPathParams", hasPathParams);
+        additionalProperties.put("hasBodyParams", hasBodyParams);
+    }
+
+
     @Override
     public String apiPackage() {
         return sourceFolder;

modules/openapi-generator/src/main/resources/go-server/controller-api.mustache

@@ -3,7 +3,9 @@ package {{packageName}}
 
 {{#operations}}
 import (
+	{{#hasBodyParams}}
 	"encoding/json"
+	{{/hasBodyParams}}
 	{{#isBodyParam}}
 	    {{^required}}
 	"errors"
@@ -14,6 +16,7 @@ import (
 	"strings"
 {{#imports}}	"{{import}}"
 	{{/imports}}
+{{#hasPathParams}}
 
 {{#routers}}
 	{{#mux}}
@@ -23,6 +26,7 @@ import (
 	"github.com/go-chi/chi/v5"
 	{{/chi}}
 {{/routers}}
+{{/hasPathParams}}
 )
 {{/operations}}
 

modules/openapi-generator/src/main/resources/go-server/go.mod.mustache

@@ -2,6 +2,7 @@ module {{gitHost}}/{{gitUserId}}/{{gitRepoId}}
 
 go 1.18
 
+{{#hasPathParams}}
 {{#routers}}
 	{{#mux}}
 require github.com/gorilla/mux v1.8.0
@@ -16,3 +17,4 @@ require github.com/go-chi/cors v1.2.1
 		{{/featureCORS}}
 	{{/chi}}
 {{/routers}}
+{{/hasPathParams}}

modules/openapi-generator/src/test/resources/3_0/go-server/no-body-path-params.yaml

@@ -0,0 +1,91 @@
+openapi: 3.0.0
+
+info:
+  version: 1.0.0
+  title: Simple no path and body param spec
+
+paths:
+  /none/endpoint:
+    get:
+      tags:
+        - none
+      summary: summary
+      description: description
+      operationId: one
+      responses:
+        '204':
+          description: successful operation
+  /path/endpoint/{pathParam}:
+    get:
+      tags:
+        - path
+      summary: summary
+      description: description
+      operationId: path
+      parameters:
+        - name: pathParam
+          in: path
+          required: true
+          style: form
+          explode: false
+          schema:
+            type: string
+      responses:
+        '204':
+          description: successful operation
+
+  /body/endpoint:
+    post:
+      tags:
+        - body
+      summary: summary
+      description: description
+      operationId: body
+      requestBody:
+        description: Optional description in *Markdown*
+        required: true
+        content:
+          application/json:
+            schema:
+              type: object
+              properties:
+                param:
+                  type: string
+          text/plain:
+            schema:
+              type: string
+      responses:
+        '204':
+          description: successful operation
+
+  /both/endpoint/{pathParam}:
+    post:
+      tags:
+        - both
+      summary: summary
+      description: description
+      operationId: both
+      parameters:
+        - name: pathParam
+          in: path
+          required: true
+          style: form
+          explode: false
+          schema:
+            type: string
+      requestBody:
+        description: Optional description in *Markdown*
+        required: true
+        content:
+          application/json:
+            schema:
+              type: object
+              properties:
+                param:
+                  type: string
+          text/plain:
+            schema:
+              type: string
+      responses:
+        '204':
+          description: successful operation

samples/server/others/go-server/no-body-path-params/.openapi-generator-ignore

@@ -0,0 +1,23 @@
+# OpenAPI Generator Ignore
+# Generated by openapi-generator https://github.com/openapitools/openapi-generator
+
+# Use this file to prevent files from being overwritten by the generator.
+# The patterns follow closely to .gitignore or .dockerignore.
+
+# As an example, the C# client generator defines ApiClient.cs.
+# You can make changes and tell OpenAPI Generator to ignore just this file by uncommenting the following line:
+#ApiClient.cs
+
+# You can match any string of characters against a directory, file or extension with a single asterisk (*):
+#foo/*/qux
+# The above matches foo/bar/qux and foo/baz/qux, but not foo/bar/baz/qux
+
+# You can recursively match patterns against a directory, file or extension with a double asterisk (**):
+#foo/**/qux
+# This matches foo/bar/qux, foo/baz/qux, and foo/bar/baz/qux
+
+# You can also negate patterns with an exclamation (!).
+# For example, you can ignore all files in a docs folder with the file extension .md:
+#docs/*.md
+# Then explicitly reverse the ignore rule for a single file:
+#!docs/README.md

samples/server/others/go-server/no-body-path-params/.openapi-generator/FILES

@@ -0,0 +1,20 @@
+Dockerfile
+README.md
+api/openapi.yaml
+go.mod
+go/api.go
+go/api_body.go
+go/api_body_service.go
+go/api_both.go
+go/api_both_service.go
+go/api_none.go
+go/api_none_service.go
+go/api_path.go
+go/api_path_service.go
+go/error.go
+go/helpers.go
+go/impl.go
+go/logger.go
+go/model_body_request.go
+go/routers.go
+main.go

samples/server/others/go-server/no-body-path-params/.openapi-generator/VERSION

@@ -0,0 +1 @@
+7.6.0-SNAPSHOT

samples/server/others/go-server/no-body-path-params/Dockerfile

@@ -0,0 +1,15 @@
+FROM golang:1.19 AS build
+WORKDIR /go/src
+COPY go ./go
+COPY main.go .
+COPY go.sum .
+COPY go.mod .
+
+ENV CGO_ENABLED=0
+
+RUN go build -o petstoreserver .
+
+FROM scratch AS runtime
+COPY --from=build /go/src/petstoreserver ./
+EXPOSE 8080/tcp
+ENTRYPOINT ["./petstoreserver"]