Skip to content

Commit 14ed53c

Browse files
committed
implement suggestions from CR. Fix declarative interface naming.
1 parent b7864f4 commit 14ed53c

22 files changed

Lines changed: 23 additions & 43 deletions

File tree

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinSpringServerCodegen.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -816,7 +816,7 @@ public void processOpts() {
816816
gradleWrapperPackage.replace(".", File.separator), "gradle-wrapper.jar"));
817817
}
818818

819-
apiTemplateFiles.put("apiInterface.mustache", "Client.kt");
819+
apiTemplateFiles.put("apiInterface.mustache", ".kt");
820820
apiTestTemplateFiles.clear();
821821
}
822822

modules/openapi-generator/src/test/java/org/openapitools/codegen/kotlin/spring/KotlinSpringServerCodegenTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1215,7 +1215,7 @@ public void generateHttpInterfaceReactiveWithReactorResponseEntity() throws Exce
12151215

12161216
generator.opts(input).generate();
12171217

1218-
Path path = Paths.get(outputPath + "/src/main/kotlin/org/openapitools/api/StoreApiClient.kt");
1218+
Path path = Paths.get(outputPath + "/src/main/kotlin/org/openapitools/api/StoreApi.kt");
12191219
assertFileContains(
12201220
path,
12211221
"import reactor.core.publisher.Flux\n"
@@ -1287,7 +1287,7 @@ public void generateHttpInterfaceReactiveWithCoroutinesResponseEntity() throws E
12871287

12881288
generator.opts(input).generate();
12891289

1290-
Path path = Paths.get(outputPath + "/src/main/kotlin/org/openapitools/api/StoreApiClient.kt");
1290+
Path path = Paths.get(outputPath + "/src/main/kotlin/org/openapitools/api/StoreApi.kt");
12911291
assertFileContains(
12921292
path,
12931293
" suspend fun getInventory(\n"
@@ -1329,7 +1329,7 @@ public void generateHttpInterfaceReactiveWithReactor() throws Exception {
13291329

13301330
generator.opts(input).generate();
13311331

1332-
Path path = Paths.get(outputPath + "/src/main/kotlin/org/openapitools/api/StoreApiClient.kt");
1332+
Path path = Paths.get(outputPath + "/src/main/kotlin/org/openapitools/api/StoreApi.kt");
13331333
assertFileContains(
13341334
path,
13351335
"import reactor.core.publisher.Flux\n"
@@ -1377,7 +1377,7 @@ public void generateHttpInterfaceReactiveWithCoroutines() throws Exception {
13771377

13781378
generator.opts(input).generate();
13791379

1380-
Path path = Paths.get(outputPath + "/src/main/kotlin/org/openapitools/api/StoreApiClient.kt");
1380+
Path path = Paths.get(outputPath + "/src/main/kotlin/org/openapitools/api/StoreApi.kt");
13811381
assertFileContains(
13821382
path,
13831383
" suspend fun getInventory(\n"
@@ -1418,7 +1418,7 @@ public void generateHttpInterfaceResponseEntity() throws Exception {
14181418

14191419
generator.opts(input).generate();
14201420

1421-
Path path = Paths.get(outputPath + "/src/main/kotlin/org/openapitools/api/StoreApiClient.kt");
1421+
Path path = Paths.get(outputPath + "/src/main/kotlin/org/openapitools/api/StoreApi.kt");
14221422
assertFileContains(
14231423
path,
14241424
" fun getInventory(\n"
@@ -1463,7 +1463,7 @@ public void generateHttpInterface() throws Exception {
14631463

14641464
generator.opts(input).generate();
14651465

1466-
Path path = Paths.get(outputPath + "/src/main/kotlin/org/openapitools/api/StoreApiClient.kt");
1466+
Path path = Paths.get(outputPath + "/src/main/kotlin/org/openapitools/api/StoreApi.kt");
14671467
// Note: We cannot use property placeholders as HttpServiceProxyFactory does not resolve them by default.
14681468
assertFileContains(
14691469
path,

modules/openapi-generator/src/test/resources/3_0/kotlin/petstore-with-x-kotlin-implements.yaml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -797,13 +797,6 @@ paths:
797797
description: Tests x-spring-paginated with no query params except pagination
798798
operationId: listPetsByIdPaginated
799799
parameters:
800-
- name: petId
801-
in: path
802-
description: Pet ID
803-
required: true
804-
schema:
805-
type: integer
806-
format: int64
807800
- name: X-Request-ID
808801
in: header
809802
description: Request ID for tracing
@@ -842,13 +835,6 @@ paths:
842835
description: Comprehensive test with all parameter types
843836
operationId: listPetsMixedParams
844837
parameters:
845-
- name: categoryId
846-
in: path
847-
description: Category ID
848-
required: true
849-
schema:
850-
type: integer
851-
format: int64
852838
- name: Authorization
853839
in: header
854840
description: Authorization header

samples/server/petstore/kotlin-spring-declarative-interface-reactive-coroutines/.openapi-generator/FILES

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ gradlew
66
gradlew.bat
77
pom.xml
88
settings.gradle
9-
src/main/kotlin/org/openapitools/api/PetApiClient.kt
10-
src/main/kotlin/org/openapitools/api/StoreApiClient.kt
11-
src/main/kotlin/org/openapitools/api/UserApiClient.kt
9+
src/main/kotlin/org/openapitools/api/PetApi.kt
10+
src/main/kotlin/org/openapitools/api/StoreApi.kt
11+
src/main/kotlin/org/openapitools/api/UserApi.kt
1212
src/main/kotlin/org/openapitools/model/Category.kt
1313
src/main/kotlin/org/openapitools/model/ModelApiResponse.kt
1414
src/main/kotlin/org/openapitools/model/Order.kt

samples/server/petstore/kotlin-spring-declarative-interface-reactive-coroutines/src/main/kotlin/org/openapitools/api/PetApiClient.kt renamed to samples/server/petstore/kotlin-spring-declarative-interface-reactive-coroutines/src/main/kotlin/org/openapitools/api/PetApi.kt

File renamed without changes.

samples/server/petstore/kotlin-spring-declarative-interface-reactive-coroutines/src/main/kotlin/org/openapitools/api/StoreApiClient.kt renamed to samples/server/petstore/kotlin-spring-declarative-interface-reactive-coroutines/src/main/kotlin/org/openapitools/api/StoreApi.kt

File renamed without changes.

samples/server/petstore/kotlin-spring-declarative-interface-reactive-coroutines/src/main/kotlin/org/openapitools/api/UserApiClient.kt renamed to samples/server/petstore/kotlin-spring-declarative-interface-reactive-coroutines/src/main/kotlin/org/openapitools/api/UserApi.kt

File renamed without changes.

samples/server/petstore/kotlin-spring-declarative-interface-reactive-reactor-wrapped/.openapi-generator/FILES

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ gradlew
66
gradlew.bat
77
pom.xml
88
settings.gradle
9-
src/main/kotlin/org/openapitools/api/PetApiClient.kt
10-
src/main/kotlin/org/openapitools/api/StoreApiClient.kt
11-
src/main/kotlin/org/openapitools/api/UserApiClient.kt
9+
src/main/kotlin/org/openapitools/api/PetApi.kt
10+
src/main/kotlin/org/openapitools/api/StoreApi.kt
11+
src/main/kotlin/org/openapitools/api/UserApi.kt
1212
src/main/kotlin/org/openapitools/model/Category.kt
1313
src/main/kotlin/org/openapitools/model/ModelApiResponse.kt
1414
src/main/kotlin/org/openapitools/model/Order.kt

samples/server/petstore/kotlin-spring-declarative-interface-reactive-reactor-wrapped/src/main/kotlin/org/openapitools/api/PetApiClient.kt renamed to samples/server/petstore/kotlin-spring-declarative-interface-reactive-reactor-wrapped/src/main/kotlin/org/openapitools/api/PetApi.kt

File renamed without changes.

samples/server/petstore/kotlin-spring-declarative-interface-reactive-reactor-wrapped/src/main/kotlin/org/openapitools/api/StoreApiClient.kt renamed to samples/server/petstore/kotlin-spring-declarative-interface-reactive-reactor-wrapped/src/main/kotlin/org/openapitools/api/StoreApi.kt

File renamed without changes.

0 commit comments

Comments
 (0)