[C++][Pistache] Fix optional error and wrong function signatures (#264)

* Added missing includes for optional

* Removed shared pointer from pistache generator

* Changed Net namespace to Pistache Namespace

* Clean up code and removed unnecessary lines in mustache files

* Removed remaining shared pointer syntax

* Code review fixes + updated samples

* Added const to all model setter functions, and reference to all params in setters that are not primitives

* Refactored modelbase

* Removed const

* Updated samples

Author: stkrwork

modules/openapi-generator-online/.openapi-generator/VERSION

@@ -1 +1 @@
-3.0.0-SNAPSHOT
+3.0.1-SNAPSHOT

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/CppPistacheServerCodegen.java

@@ -219,14 +219,14 @@ public Map<String, Object> postProcessOperations(Map<String, Object> objs) {
 
                 //TODO: This changes the info about the real type but it is needed to parse the header params
                 if (param.isHeaderParam) {
-                    param.dataType = "Optional<Net::Http::Header::Raw>";
-                    param.baseType = "Optional<Net::Http::Header::Raw>";
+                    param.dataType = "Pistache::Optional<Pistache::Http::Header::Raw>";
+                    param.baseType = "Pistache::Optional<Pistache::Http::Header::Raw>";
                 } else if (param.isQueryParam) {
                     if (param.isPrimitiveType) {
-                        param.dataType = "Optional<" + param.dataType + ">";
+                        param.dataType = "Pistache::Optional<" + param.dataType + ">";
                     } else {
-                        param.dataType = "Optional<" + param.baseType + ">";
-                        param.baseType = "Optional<" + param.baseType + ">";
+                        param.dataType = "Pistache::Optional<" + param.baseType + ">";
+                        param.baseType = "Pistache::Optional<" + param.baseType + ">";
                     }
                 }
             }
@@ -299,7 +299,7 @@ public String getTypeDeclaration(Schema p) {
             return toModelName(openAPIType);
         }
 
-        return "std::shared_ptr<" + openAPIType + ">";
+        return openAPIType;
     }
 
     @Override
@@ -326,30 +326,14 @@ public String toDefaultValue(Schema p) {
         } else if (ModelUtils.isArraySchema(p)) {
             ArraySchema ap = (ArraySchema) p;
             String inner = getSchemaType(ap.getItems());
-            if (!languageSpecificPrimitives.contains(inner)) {
-                inner = "std::shared_ptr<" + inner + ">";
-            }
             return "std::vector<" + inner + ">()";
         } else if (!StringUtils.isEmpty(p.get$ref())) { // model
-            return "new " + toModelName(ModelUtils.getSimpleRef(p.get$ref())) + "()";
+            return toModelName(ModelUtils.getSimpleRef(p.get$ref())) + "()";
         } else if (ModelUtils.isStringSchema(p)) {
             return "\"\"";
         }
 
-        return "nullptr";
-    }
-
-    @Override
-    public void postProcessParameter(CodegenParameter parameter) {
-        super.postProcessParameter(parameter);
-
-        boolean isPrimitiveType = parameter.isPrimitiveType == Boolean.TRUE;
-        boolean isListContainer = parameter.isListContainer == Boolean.TRUE;
-        boolean isString = parameter.isString == Boolean.TRUE;
-
-        if (!isPrimitiveType && !isListContainer && !isString && !parameter.dataType.startsWith("std::shared_ptr")) {
-            parameter.dataType = "std::shared_ptr<" + parameter.dataType + ">";
-        }
+        return "";
     }
 
     /**

modules/openapi-generator/src/main/resources/cpp-pistache-server/api-header.mustache

@@ -14,6 +14,8 @@
 #include <pistache/router.h>
 #include <pistache/http_headers.h>
 
+#include <pistache/optional.h>
+
 {{#imports}}{{{import}}}
 {{/imports}}
 
@@ -41,7 +43,7 @@ private:
     {{/operation}}
     void {{classnameSnakeLowerCase}}_default_handler(const Pistache::Rest::Request &request, Pistache::Http::ResponseWriter response);
 
-    std::shared_ptr<Pistache::Http::Endpoint> httpEndpoint;
+    Pistache::Http::Endpoint httpEndpoint;
     Pistache::Rest::Router router;
 
     {{#operation}}

modules/openapi-generator/src/main/resources/cpp-pistache-server/api-impl-header.mustache

@@ -17,6 +17,8 @@
 
 #include <{{classname}}.h>
 
+#include <pistache/optional.h>
+
 {{#imports}}{{{import}}}
 {{/imports}}
 

modules/openapi-generator/src/main/resources/cpp-pistache-server/api-source.mustache

@@ -10,24 +10,24 @@ namespace {{this}} {
 using namespace {{modelNamespace}};
 
 {{classname}}::{{classname}}(Pistache::Address addr)
-    : httpEndpoint(std::make_shared<Pistache::Http::Endpoint>(addr))
+    : httpEndpoint(addr)
 { };
 
 void {{classname}}::init(size_t thr = 2) {
     auto opts = Pistache::Http::Endpoint::options()
         .threads(thr)
         .flags(Pistache::Tcp::Options::InstallSignalHandler);
-    httpEndpoint->init(opts);
+    httpEndpoint.init(opts);
     setupRoutes();
 }
 
 void {{classname}}::start() {
-    httpEndpoint->setHandler(router.handler());
-    httpEndpoint->serve();
+    httpEndpoint.setHandler(router.handler());
+    httpEndpoint.serve();
 }
 
 void {{classname}}::shutdown() {
-    httpEndpoint->shutdown();
+    httpEndpoint.shutdown();
 }
 
 void {{classname}}::setupRoutes() {

modules/openapi-generator/src/main/resources/cpp-pistache-server/model-header.mustache

@@ -45,7 +45,7 @@ public:
     /// </summary>
     {{^isNotContainer}}{{{dataType}}}& {{getter}}();
     {{/isNotContainer}}{{#isNotContainer}}{{{dataType}}} {{getter}}() const;
-    void {{setter}}({{{dataType}}} value);
+    void {{setter}}({{{dataType}}} const{{^isPrimitiveType}}&{{/isPrimitiveType}} value);
     {{/isNotContainer}}{{^required}}bool {{nameInCamelCase}}IsSet() const;
     void unset{{name}}();
     {{/required}}

modules/openapi-generator/src/main/resources/cpp-pistache-server/model-source.mustache

@@ -84,7 +84,7 @@ void {{classname}}::fromJson(nlohmann::json& val)
             else
             {
                 {{{items.datatype}}} newItem({{{items.defaultValue}}});
-                newItem->fromJson(item);
+                newItem.fromJson(item);
                 m_{{name}}.push_back( newItem );
             }
             {{/items.isDateTime}}{{/items.isString}}{{/isPrimitiveType}}
@@ -100,7 +100,7 @@ void {{classname}}::fromJson(nlohmann::json& val)
         {{/isDateTime}}{{^isDateTime}}if(!val["{{baseName}}"].is_null())
         {
             {{{dataType}}} newItem({{{defaultValue}}});
-            newItem->fromJson(val["{{baseName}}"]);
+            newItem.fromJson(val["{{baseName}}"]);
             {{setter}}( newItem );
         }
         {{/isDateTime}}{{/isString}}
@@ -119,7 +119,7 @@ void {{classname}}::fromJson(nlohmann::json& val)
 {
     return m_{{name}};
 }
-void {{classname}}::{{setter}}({{{dataType}}} value)
+void {{classname}}::{{setter}}({{{dataType}}} const{{^isPrimitiveType}}&{{/isPrimitiveType}} value)
 {
     m_{{name}} = value;
     {{^required}}m_{{name}}IsSet = true;{{/required}}

modules/openapi-generator/src/main/resources/cpp-pistache-server/modelbase-header.mustache

@@ -28,13 +28,13 @@ public:
     virtual nlohmann::json toJson() const = 0;
     virtual void fromJson(nlohmann::json& json) = 0;
 
-    static std::string toJson( const std::string& value );
-    static std::string toJson( const std::time_t& value );
-    static int32_t toJson( int32_t value );
-    static int64_t toJson( int64_t value );
-    static double toJson( double value );
-    static bool toJson( bool value );
-    static nlohmann::json toJson( std::shared_ptr<ModelBase> content );
+    static std::string toJson(  std::string const& value );
+    static std::string toJson(  std::time_t const& value );
+    static int32_t toJson( int32_t const value );
+    static int64_t toJson( int64_t const value );
+    static double toJson( double const value );
+    static bool toJson( bool const value );
+    static nlohmann::json toJson(ModelBase const& content );
 
 };
 

modules/openapi-generator/src/main/resources/cpp-pistache-server/modelbase-source.mustache

@@ -12,41 +12,41 @@ ModelBase::~ModelBase()
 {
 }
 
-std::string ModelBase::toJson( const std::string& value )
+std::string ModelBase::toJson( std::string const& value )
 {
     return value;
 }
 
-std::string ModelBase::toJson( const std::time_t& value )
+std::string ModelBase::toJson( std::time_t const& value )
 {
     char buf[sizeof "2011-10-08T07:07:09Z"];
     strftime(buf, sizeof buf, "%FT%TZ", gmtime(&value));
     return buf;
 }
 
-int32_t ModelBase::toJson( int32_t value )
+int32_t ModelBase::toJson( int32_t const value )
 {
     return value;
 }
 
-int64_t ModelBase::toJson( int64_t value )
+int64_t ModelBase::toJson( int64_t const value )
 {
     return value;
 }
 
-double ModelBase::toJson( double value )
+double ModelBase::toJson( double const value )
 {
     return value;
 }
 
-bool ModelBase::toJson( bool value )
+bool ModelBase::toJson( bool const value )
 {
     return value;
 }
 
-nlohmann::json ModelBase::toJson( std::shared_ptr<ModelBase> content )
+nlohmann::json ModelBase::toJson(ModelBase content )
 {
-    return content.get() ? content->toJson() : nlohmann::json();
+    return content.toJson();
 }
 
 {{#modelNamespaceDeclarations}}

samples/server/petstore/cpp-pistache/.openapi-generator/VERSION

@@ -1 +1 @@
-3.0.0-SNAPSHOT
+3.0.2-SNAPSHOT