Fixed the query string for HttpSigning core vs dotnet47 (#8189)

* Fixed the query string for HttpSigning core vs dotnet47

* updated the sample

* replace the tab with space

* update samples

Co-authored-by: William Cheng <wing328hk@gmail.com>

Author: Ghufz

modules/openapi-generator/src/main/resources/csharp-netcore/HttpSigningConfiguration.mustache

@@ -123,6 +123,7 @@ namespace {{packageName}}.Client
             var httpValues = HttpUtility.ParseQueryString(String.Empty);
             foreach (var parameter in requestOptions.QueryParameters)
             {
+#if (NETCOREAPP)
                 if (parameter.Value.Count > 1)
                 { // array
                     foreach (var value in parameter.Value)
@@ -132,13 +133,25 @@ namespace {{packageName}}.Client
                 }
                 else
                 {
-                    httpValues.Add(HttpUtility.UrlEncode(parameter.Key), parameter.Value[0]);
-
+                httpValues.Add(HttpUtility.UrlEncode(parameter.Key), parameter.Value[0]);
                 }
+#else
+                if (parameter.Value.Count > 1)
+                    { // array
+                    foreach (var value in parameter.Value)
+                    {
+                        httpValues.Add(parameter.Key + "[]", value);
+                    }
+                    }
+                    else
+                    {
+                        httpValues.Add(parameter.Key, parameter.Value[0]);
+                    }
+#endif
             }
             var uriBuilder = new UriBuilder(string.Concat(basePath, path));
-            uriBuilder.Query = httpValues.ToString();
-
+            uriBuilder.Query = httpValues.ToString().Replace("+", "%20");
+            
             var dateTime = DateTime.Now;
             String Digest = String.Empty;
 

samples/client/petstore/csharp-netcore/OpenAPIClient-net47/src/Org.OpenAPITools/Client/HttpSigningConfiguration.cs

@@ -123,6 +123,7 @@ internal Dictionary<string, string> GetHttpSignedHeader(string basePath,string m
             var httpValues = HttpUtility.ParseQueryString(String.Empty);
             foreach (var parameter in requestOptions.QueryParameters)
             {
+#if (NETCOREAPP)
                 if (parameter.Value.Count > 1)
                 { // array
                     foreach (var value in parameter.Value)
@@ -132,13 +133,25 @@ internal Dictionary<string, string> GetHttpSignedHeader(string basePath,string m
                 }
                 else
                 {
-                    httpValues.Add(HttpUtility.UrlEncode(parameter.Key), parameter.Value[0]);
-
+                httpValues.Add(HttpUtility.UrlEncode(parameter.Key), parameter.Value[0]);
                 }
+#else
+                if (parameter.Value.Count > 1)
+                    { // array
+                    foreach (var value in parameter.Value)
+                    {
+                        httpValues.Add(parameter.Key + "[]", value);
+                    }
+                    }
+                    else
+                    {
+                        httpValues.Add(parameter.Key, parameter.Value[0]);
+                    }
+#endif
             }
             var uriBuilder = new UriBuilder(string.Concat(basePath, path));
-            uriBuilder.Query = httpValues.ToString();
-
+            uriBuilder.Query = httpValues.ToString().Replace("+", "%20");
+            
             var dateTime = DateTime.Now;
             String Digest = String.Empty;
 

samples/client/petstore/csharp-netcore/OpenAPIClient/src/Org.OpenAPITools/Client/HttpSigningConfiguration.cs

@@ -123,6 +123,7 @@ internal Dictionary<string, string> GetHttpSignedHeader(string basePath,string m
             var httpValues = HttpUtility.ParseQueryString(String.Empty);
             foreach (var parameter in requestOptions.QueryParameters)
             {
+#if (NETCOREAPP)
                 if (parameter.Value.Count > 1)
                 { // array
                     foreach (var value in parameter.Value)
@@ -132,13 +133,25 @@ internal Dictionary<string, string> GetHttpSignedHeader(string basePath,string m
                 }
                 else
                 {
-                    httpValues.Add(HttpUtility.UrlEncode(parameter.Key), parameter.Value[0]);
-
+                httpValues.Add(HttpUtility.UrlEncode(parameter.Key), parameter.Value[0]);
                 }
+#else
+                if (parameter.Value.Count > 1)
+                    { // array
+                    foreach (var value in parameter.Value)
+                    {
+                        httpValues.Add(parameter.Key + "[]", value);
+                    }
+                    }
+                    else
+                    {
+                        httpValues.Add(parameter.Key, parameter.Value[0]);
+                    }
+#endif
             }
             var uriBuilder = new UriBuilder(string.Concat(basePath, path));
-            uriBuilder.Query = httpValues.ToString();
-
+            uriBuilder.Query = httpValues.ToString().Replace("+", "%20");
+            
             var dateTime = DateTime.Now;
             String Digest = String.Empty;
 

samples/client/petstore/csharp-netcore/OpenAPIClientCore/src/Org.OpenAPITools/Client/HttpSigningConfiguration.cs

@@ -123,6 +123,7 @@ internal Dictionary<string, string> GetHttpSignedHeader(string basePath,string m
             var httpValues = HttpUtility.ParseQueryString(String.Empty);
             foreach (var parameter in requestOptions.QueryParameters)
             {
+#if (NETCOREAPP)
                 if (parameter.Value.Count > 1)
                 { // array
                     foreach (var value in parameter.Value)
@@ -132,13 +133,25 @@ internal Dictionary<string, string> GetHttpSignedHeader(string basePath,string m
                 }
                 else
                 {
-                    httpValues.Add(HttpUtility.UrlEncode(parameter.Key), parameter.Value[0]);
-
+                httpValues.Add(HttpUtility.UrlEncode(parameter.Key), parameter.Value[0]);
                 }
+#else
+                if (parameter.Value.Count > 1)
+                    { // array
+                    foreach (var value in parameter.Value)
+                    {
+                        httpValues.Add(parameter.Key + "[]", value);
+                    }
+                    }
+                    else
+                    {
+                        httpValues.Add(parameter.Key, parameter.Value[0]);
+                    }
+#endif
             }
             var uriBuilder = new UriBuilder(string.Concat(basePath, path));
-            uriBuilder.Query = httpValues.ToString();
-
+            uriBuilder.Query = httpValues.ToString().Replace("+", "%20");
+            
             var dateTime = DateTime.Now;
             String Digest = String.Empty;