Skip to content

Commit 7275384

Browse files
committed
fix: address cubic-dev-ai review comments
- Remove {{^-first}} to include ALL responses in errorType map (not just from 2nd response) - Add transient keyword to errorEntity field for serialization safety - Update test to expect transient keyword - Regenerate samples with fixes
1 parent 5dedcc8 commit 7275384

4 files changed

Lines changed: 4 additions & 5 deletions

File tree

modules/openapi-generator/src/main/resources/Java/libraries/jersey3/api.mustache

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,11 +197,9 @@ public class {{classname}} {
197197
{{/hasAuthMethods}}
198198
final Map<String, GenericType> localVarErrorTypes = new HashMap<String, GenericType>();
199199
{{#responses}}
200-
{{^-first}}
201200
{{#dataType}}
202201
localVarErrorTypes.put("{{code}}", new GenericType<{{{dataType}}}>() {});
203202
{{/dataType}}
204-
{{/-first}}
205203
{{/responses}}
206204
{{#returnType}}
207205
GenericType<{{{returnType}}}> localVarReturnType = new GenericType<{{{returnType}}}>() {};

modules/openapi-generator/src/main/resources/Java/libraries/jersey3/apiException.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public class ApiException extends{{#useRuntimeException}} RuntimeException {{/us
2020
private int code = 0;
2121
private Map<String, List<String>> responseHeaders = null;
2222
private String responseBody = null;
23-
private Object errorEntity = null;
23+
private transient Object errorEntity = null;
2424
2525
public ApiException() {}
2626

modules/openapi-generator/src/test/java/org/openapitools/codegen/java/jersey3/JavaJersey3ErrorEntityFunctionalTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ public void testGeneratedApiExceptionHasErrorEntity() throws Exception {
5050
String template = readTemplate("apiException.mustache");
5151
assertNotNull(template);
5252

53-
// Verify errorEntity field exists
54-
assertTrue(template.contains("private Object errorEntity = null"),
53+
// Verify errorEntity field exists (transient for serialization safety)
54+
assertTrue(template.contains("private transient Object errorEntity = null"),
5555
"Generated ApiException should have errorEntity field");
5656

5757
// Verify getErrorEntity() method exists

samples/client/petstore/java/jersey3-oneOf/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -358,6 +358,7 @@
358358
<commons-lang3-version>3.12.0</commons-lang3-version>
359359
<http-signature-version>1.8</http-signature-version>
360360
<junit-version>5.10.0</junit-version>
361+
<junit-version>5.10.0</junit-version>
361362
<spotless.version>2.21.0</spotless.version>
362363
</properties>
363364
</project>

0 commit comments

Comments
 (0)