Set error_reporting(E_ALL) in phpunit.xml settings, to crash on undefined variables (#3266)

ndbroadbent · wing328 · commit 78551d018075 · 2019-07-06T22:21:41.000+08:00
* Set error_reporting(E_ALL) in phpunit.xml settings, so that undefined variables will always cause a test failure

* Update petstore sample for php-laravel
diff --git a/modules/openapi-generator/src/main/resources/php-laravel/phpunit.xml b/modules/openapi-generator/src/main/resources/php-laravel/phpunit.xml
@@ -23,6 +23,7 @@
         </whitelist>
     </filter>
     <php>
+        <ini name="error_reporting" value="E_ALL" />
         <env name="APP_ENV" value="testing"/>
         <env name="BCRYPT_ROUNDS" value="4"/>
         <env name="CACHE_DRIVER" value="array"/>
diff --git a/modules/openapi-generator/src/main/resources/php-lumen/phpunit.xml b/modules/openapi-generator/src/main/resources/php-lumen/phpunit.xml
@@ -20,6 +20,7 @@
         </whitelist>
     </filter>
     <php>
+        <ini name="error_reporting" value="E_ALL" />
         <env name="APP_ENV" value="testing"/>
         <env name="CACHE_DRIVER" value="array"/>
         <env name="QUEUE_DRIVER" value="sync"/>
diff --git a/modules/openapi-generator/src/main/resources/php-slim-server/phpunit.xml.mustache b/modules/openapi-generator/src/main/resources/php-slim-server/phpunit.xml.mustache
@@ -24,4 +24,7 @@
             <directory suffix=".php">{{modelSrcPath}}</directory>
         </whitelist>
     </filter>
-</phpunit>
+    <php>
+        <ini name="error_reporting" value="E_ALL" />
+    </php>
+</phpunit>
diff --git a/modules/openapi-generator/src/main/resources/php-symfony/testing/phpunit.xml.mustache b/modules/openapi-generator/src/main/resources/php-symfony/testing/phpunit.xml.mustache
@@ -11,15 +11,14 @@
             <directory>{{modelTestPath}}</directory>
         </testsuite>
     </testsuites>
-
-    <php>
-        <server name="KERNEL_DIR" value="Tests/" />
-    </php>
-
     <filter>
         <whitelist processUncoveredFilesFromWhitelist="true">
             <directory suffix=".php">{{apiSrcPath}}</directory>
             <directory suffix=".php">{{modelSrcPath}}</directory>
         </whitelist>
     </filter>
+    <php>
+        <ini name="error_reporting" value="E_ALL" />
+        <server name="KERNEL_DIR" value="Tests/" />
+    </php>
 </phpunit>
diff --git a/modules/openapi-generator/src/main/resources/php/phpunit.xml.mustache b/modules/openapi-generator/src/main/resources/php/phpunit.xml.mustache
@@ -11,11 +11,13 @@
             <directory>{{modelTestPath}}</directory>
         </testsuite>
     </testsuites>
-
     <filter>
         <whitelist processUncoveredFilesFromWhitelist="true">
             <directory suffix=".php">{{apiSrcPath}}</directory>
             <directory suffix=".php">{{modelSrcPath}}</directory>
         </whitelist>
     </filter>
+    <php>
+        <ini name="error_reporting" value="E_ALL" />
+    </php>
 </phpunit>
diff --git a/samples/client/petstore/php/OpenAPIClient-php/phpunit.xml.dist b/samples/client/petstore/php/OpenAPIClient-php/phpunit.xml.dist
@@ -11,11 +11,13 @@
             <directory>./test/Model</directory>
         </testsuite>
     </testsuites>
-
     <filter>
         <whitelist processUncoveredFilesFromWhitelist="true">
             <directory suffix=".php">./lib/Api</directory>
             <directory suffix=".php">./lib/Model</directory>
         </whitelist>
     </filter>
+    <php>
+        <ini name="error_reporting" value="E_ALL" />
+    </php>
 </phpunit>
diff --git a/samples/openapi3/client/petstore/php/OpenAPIClient-php/phpunit.xml.dist b/samples/openapi3/client/petstore/php/OpenAPIClient-php/phpunit.xml.dist
@@ -11,11 +11,13 @@
             <directory>./test/Model</directory>
         </testsuite>
     </testsuites>
-
     <filter>
         <whitelist processUncoveredFilesFromWhitelist="true">
             <directory suffix=".php">./lib/Api</directory>
             <directory suffix=".php">./lib/Model</directory>
         </whitelist>
     </filter>
+    <php>
+        <ini name="error_reporting" value="E_ALL" />
+    </php>
 </phpunit>
diff --git a/samples/server/petstore/php-laravel/.openapi-generator/VERSION b/samples/server/petstore/php-laravel/.openapi-generator/VERSION
@@ -1 +1 @@
-4.0.0-SNAPSHOT
+4.0.3-SNAPSHOT
diff --git a/samples/server/petstore/php-laravel/lib/app/Http/Controllers/AnotherFakeController.php b/samples/server/petstore/php-laravel/lib/app/Http/Controllers/AnotherFakeController.php
@@ -4,7 +4,7 @@
  * OpenAPI Petstore
  * This spec is mainly for testing Petstore server and contains fake endpoints, models. Please do not use this for any other purpose. Special characters: \" \\
  *
- * OpenAPI spec version: 1.0.0
+ * The version of the OpenAPI document: 1.0.0
  * 
  *
  * NOTE: This class is auto generated by OpenAPI-Generator
diff --git a/samples/server/petstore/php-laravel/lib/app/Http/Controllers/FakeClassnameTags123Controller.php b/samples/server/petstore/php-laravel/lib/app/Http/Controllers/FakeClassnameTags123Controller.php
@@ -4,7 +4,7 @@
  * OpenAPI Petstore
  * This spec is mainly for testing Petstore server and contains fake endpoints, models. Please do not use this for any other purpose. Special characters: \" \\
  *
- * OpenAPI spec version: 1.0.0
+ * The version of the OpenAPI document: 1.0.0
  * 
  *
  * NOTE: This class is auto generated by OpenAPI-Generator
diff --git a/samples/server/petstore/php-laravel/lib/app/Http/Controllers/FakeController.php b/samples/server/petstore/php-laravel/lib/app/Http/Controllers/FakeController.php
@@ -4,7 +4,7 @@
  * OpenAPI Petstore
  * This spec is mainly for testing Petstore server and contains fake endpoints, models. Please do not use this for any other purpose. Special characters: \" \\
  *
- * OpenAPI spec version: 1.0.0
+ * The version of the OpenAPI document: 1.0.0
  * 
  *
  * NOTE: This class is auto generated by OpenAPI-Generator
diff --git a/samples/server/petstore/php-laravel/lib/app/Http/Controllers/PetController.php b/samples/server/petstore/php-laravel/lib/app/Http/Controllers/PetController.php
@@ -4,7 +4,7 @@
  * OpenAPI Petstore
  * This spec is mainly for testing Petstore server and contains fake endpoints, models. Please do not use this for any other purpose. Special characters: \" \\
  *
- * OpenAPI spec version: 1.0.0
+ * The version of the OpenAPI document: 1.0.0
  * 
  *
  * NOTE: This class is auto generated by OpenAPI-Generator
diff --git a/samples/server/petstore/php-laravel/lib/app/Http/Controllers/StoreController.php b/samples/server/petstore/php-laravel/lib/app/Http/Controllers/StoreController.php
@@ -4,7 +4,7 @@
  * OpenAPI Petstore
  * This spec is mainly for testing Petstore server and contains fake endpoints, models. Please do not use this for any other purpose. Special characters: \" \\
  *
- * OpenAPI spec version: 1.0.0
+ * The version of the OpenAPI document: 1.0.0
  * 
  *
  * NOTE: This class is auto generated by OpenAPI-Generator
diff --git a/samples/server/petstore/php-laravel/lib/app/Http/Controllers/UserController.php b/samples/server/petstore/php-laravel/lib/app/Http/Controllers/UserController.php
@@ -4,7 +4,7 @@
  * OpenAPI Petstore
  * This spec is mainly for testing Petstore server and contains fake endpoints, models. Please do not use this for any other purpose. Special characters: \" \\
  *
- * OpenAPI spec version: 1.0.0
+ * The version of the OpenAPI document: 1.0.0
  * 
  *
  * NOTE: This class is auto generated by OpenAPI-Generator
diff --git a/samples/server/petstore/php-laravel/lib/app/Models/AdditionalPropertiesAnyType.php b/samples/server/petstore/php-laravel/lib/app/Models/AdditionalPropertiesAnyType.php
@@ -0,0 +1,15 @@
+<?php
+/**
+ * AdditionalPropertiesAnyType
+ */
+namespace app\Models;
+
+/**
+ * AdditionalPropertiesAnyType
+ */
+class AdditionalPropertiesAnyType {
+
+    /** @var string $name */
+    private $name;
+
+}
diff --git a/samples/server/petstore/php-laravel/lib/app/Models/AdditionalPropertiesArray.php b/samples/server/petstore/php-laravel/lib/app/Models/AdditionalPropertiesArray.php
@@ -0,0 +1,15 @@
+<?php
+/**
+ * AdditionalPropertiesArray
+ */
+namespace app\Models;
+
+/**
+ * AdditionalPropertiesArray
+ */
+class AdditionalPropertiesArray {
+
+    /** @var string $name */
+    private $name;
+
+}
diff --git a/samples/server/petstore/php-laravel/lib/app/Models/AdditionalPropertiesBoolean.php b/samples/server/petstore/php-laravel/lib/app/Models/AdditionalPropertiesBoolean.php
@@ -0,0 +1,15 @@
+<?php
+/**
+ * AdditionalPropertiesBoolean
+ */
+namespace app\Models;
+
+/**
+ * AdditionalPropertiesBoolean
+ */
+class AdditionalPropertiesBoolean {
+
+    /** @var string $name */
+    private $name;
+
+}
diff --git a/samples/server/petstore/php-laravel/lib/app/Models/AdditionalPropertiesClass.php b/samples/server/petstore/php-laravel/lib/app/Models/AdditionalPropertiesClass.php
@@ -9,10 +9,37 @@
  */
 class AdditionalPropertiesClass {
 
-    /** @var map[string,string] $mapProperty */
-    private $mapProperty;
+    /** @var map[string,string] $mapString */
+    private $mapString;
 
-    /** @var map[string,map[string,string]] $mapOfMapProperty */
-    private $mapOfMapProperty;
+    /** @var map[string,float] $mapNumber */
+    private $mapNumber;
+
+    /** @var map[string,int] $mapInteger */
+    private $mapInteger;
+
+    /** @var map[string,bool] $mapBoolean */
+    private $mapBoolean;
+
+    /** @var map[string,int[]] $mapArrayInteger */
+    private $mapArrayInteger;
+
+    /** @var map[string,object[]] $mapArrayAnytype */
+    private $mapArrayAnytype;
+
+    /** @var map[string,map[string,string]] $mapMapString */
+    private $mapMapString;
+
+    /** @var map[string,map[string,object]] $mapMapAnytype */
+    private $mapMapAnytype;
+
+    /** @var object $anytype1 */
+    private $anytype1;
+
+    /** @var object $anytype2 */
+    private $anytype2;
+
+    /** @var object $anytype3 */
+    private $anytype3;
 
 }
diff --git a/samples/server/petstore/php-laravel/lib/app/Models/AdditionalPropertiesInteger.php b/samples/server/petstore/php-laravel/lib/app/Models/AdditionalPropertiesInteger.php
@@ -0,0 +1,15 @@
+<?php
+/**
+ * AdditionalPropertiesInteger
+ */
+namespace app\Models;
+
+/**
+ * AdditionalPropertiesInteger
+ */
+class AdditionalPropertiesInteger {
+
+    /** @var string $name */
+    private $name;
+
+}
diff --git a/samples/server/petstore/php-laravel/lib/app/Models/AdditionalPropertiesNumber.php b/samples/server/petstore/php-laravel/lib/app/Models/AdditionalPropertiesNumber.php
@@ -0,0 +1,15 @@
+<?php
+/**
+ * AdditionalPropertiesNumber
+ */
+namespace app\Models;
+
+/**
+ * AdditionalPropertiesNumber
+ */
+class AdditionalPropertiesNumber {
+
+    /** @var string $name */
+    private $name;
+
+}
diff --git a/samples/server/petstore/php-laravel/lib/app/Models/AdditionalPropertiesObject.php b/samples/server/petstore/php-laravel/lib/app/Models/AdditionalPropertiesObject.php
@@ -0,0 +1,15 @@
+<?php
+/**
+ * AdditionalPropertiesObject
+ */
+namespace app\Models;
+
+/**
+ * AdditionalPropertiesObject
+ */
+class AdditionalPropertiesObject {
+
+    /** @var string $name */
+    private $name;
+
+}
diff --git a/samples/server/petstore/php-laravel/lib/app/Models/AdditionalPropertiesString.php b/samples/server/petstore/php-laravel/lib/app/Models/AdditionalPropertiesString.php
@@ -0,0 +1,15 @@
+<?php
+/**
+ * AdditionalPropertiesString
+ */
+namespace app\Models;
+
+/**
+ * AdditionalPropertiesString
+ */
+class AdditionalPropertiesString {
+
+    /** @var string $name */
+    private $name;
+
+}
diff --git a/samples/server/petstore/php-laravel/lib/app/Models/CatAllOf.php b/samples/server/petstore/php-laravel/lib/app/Models/CatAllOf.php
@@ -0,0 +1,15 @@
+<?php
+/**
+ * CatAllOf
+ */
+namespace app\Models;
+
+/**
+ * CatAllOf
+ */
+class CatAllOf {
+
+    /** @var bool $declawed */
+    private $declawed;
+
+}
diff --git a/samples/server/petstore/php-laravel/lib/app/Models/DogAllOf.php b/samples/server/petstore/php-laravel/lib/app/Models/DogAllOf.php
@@ -0,0 +1,15 @@
+<?php
+/**
+ * DogAllOf
+ */
+namespace app\Models;
+
+/**
+ * DogAllOf
+ */
+class DogAllOf {
+
+    /** @var string $breed */
+    private $breed;
+
+}
diff --git a/samples/server/petstore/php-laravel/lib/phpunit.xml b/samples/server/petstore/php-laravel/lib/phpunit.xml
@@ -23,6 +23,7 @@
         </whitelist>
     </filter>
     <php>
+        <ini name="error_reporting" value="E_ALL" />
         <env name="APP_ENV" value="testing"/>
         <env name="BCRYPT_ROUNDS" value="4"/>
         <env name="CACHE_DRIVER" value="array"/>
diff --git a/samples/server/petstore/php-laravel/lib/routes/api.php b/samples/server/petstore/php-laravel/lib/routes/api.php
@@ -4,7 +4,7 @@
  * OpenAPI Petstore
  * This spec is mainly for testing Petstore server and contains fake endpoints, models. Please do not use this for any other purpose. Special characters: \" \\
  *
- * OpenAPI spec version: 1.0.0
+ * The version of the OpenAPI document: 1.0.0
  * 
  *
  * NOTE: This class is auto generated by OpenAPI-Generator
diff --git a/samples/server/petstore/php-laravel/lib/routes/channels.php b/samples/server/petstore/php-laravel/lib/routes/channels.php
@@ -4,7 +4,7 @@
  * OpenAPI Petstore
  * This spec is mainly for testing Petstore server and contains fake endpoints, models. Please do not use this for any other purpose. Special characters: \" \\
  *
- * OpenAPI spec version: 1.0.0
+ * The version of the OpenAPI document: 1.0.0
  * 
  *
  * NOTE: This class is auto generated by OpenAPI-Generator
diff --git a/samples/server/petstore/php-laravel/lib/routes/console.php b/samples/server/petstore/php-laravel/lib/routes/console.php
@@ -4,7 +4,7 @@
  * OpenAPI Petstore
  * This spec is mainly for testing Petstore server and contains fake endpoints, models. Please do not use this for any other purpose. Special characters: \" \\
  *
- * OpenAPI spec version: 1.0.0
+ * The version of the OpenAPI document: 1.0.0
  * 
  *
  * NOTE: This class is auto generated by OpenAPI-Generator
diff --git a/samples/server/petstore/php-laravel/lib/routes/web.php b/samples/server/petstore/php-laravel/lib/routes/web.php
@@ -4,7 +4,7 @@
  * OpenAPI Petstore
  * This spec is mainly for testing Petstore server and contains fake endpoints, models. Please do not use this for any other purpose. Special characters: \" \\
  *
- * OpenAPI spec version: 1.0.0
+ * The version of the OpenAPI document: 1.0.0
  * 
  *
  * NOTE: This class is auto generated by OpenAPI-Generator
diff --git a/samples/server/petstore/php-slim/phpunit.xml.dist b/samples/server/petstore/php-slim/phpunit.xml.dist
@@ -24,4 +24,7 @@
             <directory suffix=".php">./lib/Model</directory>
         </whitelist>
     </filter>
-</phpunit>
+    <php>
+        <ini name="error_reporting" value="E_ALL" />
+    </php>
+</phpunit>
diff --git a/samples/server/petstore/php-symfony/SymfonyBundle-php/phpunit.xml.dist b/samples/server/petstore/php-symfony/SymfonyBundle-php/phpunit.xml.dist

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`* OpenAPI Petstore`
`5`	`5`	`* This spec is mainly for testing Petstore server and contains fake endpoints, models. Please do not use this for any other purpose. Special characters: \" \\`
`6`	`6`	`*`
`7`		`- * OpenAPI spec version: 1.0.0`
	`7`	`+ * The version of the OpenAPI document: 1.0.0`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* NOTE: This class is auto generated by OpenAPI-Generator`