Skip to content

Commit b4045da

Browse files
committed
fix #22492 [BUG][JAVA][MAVEN] Lombok @Getter disables validation and #19743 #18794 #17793 #17606
1 parent f36b834 commit b4045da

11 files changed

Lines changed: 28 additions & 173 deletions

File tree

modules/openapi-generator/src/main/resources/JavaSpring/lombokAnnotation.mustache

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@
1414
{{#isPassword}}
1515
@lombok.ToString.Exclude
1616
{{/isPassword}}
17-
{{^isContainer}}
18-
{{#useBeanValidation}}{{>beanValidation}}{{/useBeanValidation}}
19-
{{/isContainer}}
17+
{{^isContainer}}{{#useBeanValidation}}{{>beanValidation}}{{/useBeanValidation}}{{/isContainer}}
2018
{{^useBeanValidation}}
2119
{{#required}}
2220
@lombok.NonNull

samples/server/petstore/springboot-lombok-data/.openapi-generator/FILES

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,8 @@ src/main/java/org/openapitools/OpenApiGeneratorApplication.java
44
src/main/java/org/openapitools/RFC3339DateFormat.java
55
src/main/java/org/openapitools/api/ApiUtil.java
66
src/main/java/org/openapitools/api/PetApi.java
7-
src/main/java/org/openapitools/api/PetApiController.java
87
src/main/java/org/openapitools/api/StoreApi.java
9-
src/main/java/org/openapitools/api/StoreApiController.java
108
src/main/java/org/openapitools/api/UserApi.java
11-
src/main/java/org/openapitools/api/UserApiController.java
129
src/main/java/org/openapitools/configuration/HomeController.java
1310
src/main/java/org/openapitools/configuration/SpringDocConfiguration.java
1411
src/main/java/org/openapitools/model/Category.java

samples/server/petstore/springboot-lombok-data/src/main/java/org/openapitools/api/PetApiController.java

Lines changed: 0 additions & 48 deletions
This file was deleted.

samples/server/petstore/springboot-lombok-data/src/main/java/org/openapitools/api/StoreApiController.java

Lines changed: 0 additions & 47 deletions
This file was deleted.

samples/server/petstore/springboot-lombok-data/src/main/java/org/openapitools/api/UserApiController.java

Lines changed: 0 additions & 47 deletions
This file was deleted.

samples/server/petstore/springboot-lombok-data/src/main/java/org/openapitools/model/Category.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,12 @@
2727
@Generated(value = "org.openapitools.codegen.languages.SpringCodegen", comments = "Generator version: 7.18.0-SNAPSHOT")
2828
public class Category {
2929

30-
30+
3131
@Schema(name = "id", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
3232
@JsonProperty("id")
3333
private @Nullable Long id;
3434

35-
@Pattern(regexp = "^[a-zA-Z0-9]+[a-zA-Z0-9\\.\\-_]*[a-zA-Z0-9]+$")
35+
@Pattern(regexp = "^[a-zA-Z0-9]+[a-zA-Z0-9\\.\\-_]*[a-zA-Z0-9]+$")
3636
@Schema(name = "name", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
3737
@JsonProperty("name")
3838
private @Nullable String name;

samples/server/petstore/springboot-lombok-data/src/main/java/org/openapitools/model/ModelApiResponse.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,17 @@
2929
@Generated(value = "org.openapitools.codegen.languages.SpringCodegen", comments = "Generator version: 7.18.0-SNAPSHOT")
3030
public class ModelApiResponse {
3131

32-
32+
3333
@Schema(name = "code", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
3434
@JsonProperty("code")
3535
private @Nullable Integer code;
3636

37-
37+
3838
@Schema(name = "type", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
3939
@JsonProperty("type")
4040
private @Nullable String type;
4141

42-
42+
4343
@Schema(name = "message", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
4444
@JsonProperty("message")
4545
private @Nullable String message;

samples/server/petstore/springboot-lombok-data/src/main/java/org/openapitools/model/Order.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,22 +30,22 @@
3030
@Generated(value = "org.openapitools.codegen.languages.SpringCodegen", comments = "Generator version: 7.18.0-SNAPSHOT")
3131
public class Order {
3232

33-
33+
3434
@Schema(name = "id", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
3535
@JsonProperty("id")
3636
private @Nullable Long id;
3737

38-
38+
3939
@Schema(name = "petId", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
4040
@JsonProperty("petId")
4141
private @Nullable Long petId;
4242

43-
43+
4444
@Schema(name = "quantity", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
4545
@JsonProperty("quantity")
4646
private @Nullable Integer quantity;
4747

48-
@Valid
48+
@Valid
4949
@Schema(name = "shipDate", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
5050
@JsonProperty("shipDate")
5151
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE_TIME)
@@ -88,12 +88,12 @@ public static StatusEnum fromValue(String value) {
8888
}
8989
}
9090

91-
91+
9292
@Schema(name = "status", description = "Order Status", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
9393
@JsonProperty("status")
9494
private @Nullable StatusEnum status;
9595

96-
96+
9797
@Schema(name = "complete", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
9898
@JsonProperty("complete")
9999
@lombok.Builder.Default

samples/server/petstore/springboot-lombok-data/src/main/java/org/openapitools/model/Pet.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,27 +33,29 @@
3333
@Generated(value = "org.openapitools.codegen.languages.SpringCodegen", comments = "Generator version: 7.18.0-SNAPSHOT")
3434
public class Pet {
3535

36-
36+
3737
@Schema(name = "id", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
3838
@JsonProperty("id")
3939
private @Nullable Long id;
4040

41-
@Valid
41+
@Valid
4242
@Schema(name = "category", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
4343
@JsonProperty("category")
4444
private @Nullable Category category;
4545

46-
@NotNull
46+
@NotNull
4747
@Schema(name = "name", example = "doggie", requiredMode = Schema.RequiredMode.REQUIRED)
4848
@JsonProperty("name")
4949
private String name;
5050

51+
5152
@Schema(name = "photoUrls", requiredMode = Schema.RequiredMode.REQUIRED)
5253
@JsonProperty("photoUrls")
5354
@lombok.Builder.Default
5455
@Valid
5556
private List<String> photoUrls = new ArrayList<>();
5657

58+
5759
@Schema(name = "tags", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
5860
@JsonProperty("tags")
5961
@lombok.Builder.Default
@@ -97,7 +99,7 @@ public static StatusEnum fromValue(String value) {
9799
}
98100
}
99101

100-
102+
101103
@Schema(name = "status", description = "pet status in the store", deprecated = true, requiredMode = Schema.RequiredMode.NOT_REQUIRED)
102104
@JsonProperty("status")
103105
@Deprecated

samples/server/petstore/springboot-lombok-data/src/main/java/org/openapitools/model/Tag.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,12 @@
2727
@Generated(value = "org.openapitools.codegen.languages.SpringCodegen", comments = "Generator version: 7.18.0-SNAPSHOT")
2828
public class Tag {
2929

30-
30+
3131
@Schema(name = "id", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
3232
@JsonProperty("id")
3333
private @Nullable Long id;
3434

35-
35+
3636
@Schema(name = "name", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
3737
@JsonProperty("name")
3838
private @Nullable String name;

0 commit comments

Comments
 (0)