add tests

Author: Picazsoo

modules/openapi-generator-gradle-plugin/PARAMETRIZATION_IMPLEMENTATION_SUMMARY.md

@@ -0,0 +1,116 @@
+# Test Parametrization Implementation Summary
+
+## Overview
+Successfully parametrized all Gradle plugin tests to verify file/directory properties work with both String-based (`.absolutePath`) and File-based (`file()`) formats.
+
+## Changes Implemented
+
+### 1. TestBase.kt
+- Added `PropertyFormat` enum with `STRING` and `FILE` values
+- Added `String.toPropertyReference(format: PropertyFormat)` extension function
+- Added comprehensive KDoc documentation
+
+### 2. GenerateTaskConfigurationCacheTest.kt
+- Updated data providers to include format parameter
+- FILE format only tested with Gradle 8.7
+- Converted `inputSpecExtensionContents` to function
+- Updated 2 test methods
+- **Test count**: 3 → 5 (+2)
+
+### 3. GenerateTaskUpToDateTest.kt
+- Updated data provider: `[["8.7", "STRING"], ["7.6.4", "STRING"], ["8.7", "FILE"]]`
+- Converted 4 extension content vals to functions
+- Updated 8 test methods
+- **Test count**: 16 → 20 (+4)
+
+### 4. GenerateTaskFromCacheTest.kt
+- Updated data provider with same pattern as UpToDateTest
+- Converted 4 extension content vals to functions
+- Updated 8 test methods
+- **Test count**: 16 → 20 (+4)
+
+### 5. ValidateTaskDslTest.kt
+- Updated data provider: `[[null, "STRING"], ["8.7", "STRING"], ["7.6.4", "STRING"], ["8.7", "FILE"]]`
+- Added `inputSpecProperty()` helper method
+- Updated 8 test methods (kept 1 non-parametrized)
+- **Test count**: 30 → 39 (+9)
+
+### 6. GenerateTaskDslTest.kt
+- Added property format data provider
+- Converted `defaultBuildGradle` to function
+- Parametrized 13 tests (excluded URL-based test)
+- **Test count**: 14 → 27 (+13)
+
+### 7. MetaTaskDslTest.kt
+- Added property format data provider
+- Parametrized `outputFolder` property with special handling for DirectoryProperty
+- **Test count**: 1 → 2 (+1)
+
+### 8. GeneratorsTaskDslTest.kt
+- **No changes** - doesn't use file/directory properties
+
+## Total Impact
+- **Total test count**: 65 → 98 tests (+33 tests, +51% increase)
+- **Strategy**: FILE format tests ONLY with Gradle 8.7 for performance
+- **Consistency**: All properties in single test use same format (no mixing)
+
+## Running the Tests
+
+### Run all tests:
+```cmd
+cd C:\Users\jachymm\IdeaProjects\openapi-generator-forked\modules\openapi-generator-gradle-plugin
+gradlew.bat test
+```
+
+### Run specific test class:
+```cmd
+gradlew.bat test --tests GenerateTaskConfigurationCacheTest
+gradlew.bat test --tests GenerateTaskUpToDateTest
+gradlew.bat test --tests GenerateTaskFromCacheTest
+gradlew.bat test --tests ValidateTaskDslTest
+gradlew.bat test --tests GenerateTaskDslTest
+gradlew.bat test --tests MetaTaskDslTest
+```
+
+### Run with more output:
+```cmd
+gradlew.bat test --info
+gradlew.bat test --debug
+```
+
+### Run and generate HTML report:
+```cmd
+gradlew.bat test
+:: Report will be at: build\reports\tests\test\index.html
+```
+
+## Properties Parametrized
+
+The following file/directory properties are now tested with both formats:
+
+1. **inputSpec** - Input OpenAPI specification file
+2. **outputDir** - Output directory for generated code
+3. **inputSpecRootDirectory** - Root directory for multiple spec files
+4. **templateDir** - Custom template directory
+5. **configFile** - Configuration file
+6. **ignoreFileOverride** - Override file for .openapi-generator-ignore
+7. **outputFolder** - Output folder for meta task (MetaTask only)
+
+## Test Naming Convention
+
+Tests now include the format in their execution, displayed by TestNG as:
+- `testMethod[8.7, STRING]`
+- `testMethod[8.7, FILE]`
+- `testMethod[7.6.4, STRING]`
+
+## Verification
+
+All modified test files compile without errors. Some type inference warnings exist but are benign and don't affect functionality.
+
+## Next Steps
+
+1. Run the tests using the commands above
+2. Review test results in the HTML report
+3. If any tests fail, check the output for specific error messages
+4. The FILE format tests specifically validate that Gradle properly resolves File objects to absolute paths internally
+

modules/openapi-generator-gradle-plugin/src/test/kotlin/GenerateTaskConfigurationCacheTest.kt

@@ -20,23 +20,30 @@ class GenerateTaskConfigurationCacheTest : TestBase() {
     }
 
     @DataProvider(name = "gradle_version_provider")
-    private fun gradleVersionProviderWithConfigurationCache(): Array<Array<String>> = arrayOf(arrayOf("8.7"), arrayOf("7.6.4"))
+    private fun gradleVersionProviderWithConfigurationCache(): Array<Array<String>> = arrayOf(
+        arrayOf("8.7", "STRING"),
+        arrayOf("7.6.4", "STRING"),
+        arrayOf("8.7", "FILE")
+    )
 
     @DataProvider(name = "gradle_version_provider_without_cc")
-    private fun gradleVersionProviderWithoutConfigurationCache(): Array<Array<String>> = arrayOf(arrayOf("5.6.1"))
+    private fun gradleVersionProviderWithoutConfigurationCache(): Array<Array<String>> = arrayOf(
+        arrayOf("5.6.1", "STRING")
+    )
 
     // inputSpec tests
 
-    private val inputSpecExtensionContents = """
+    private fun inputSpecExtensionContents(format: PropertyFormat) = """
         generatorName = "kotlin"
-        inputSpec = file("spec.yaml")
+        inputSpec = ${"spec.yaml".toPropertyReference(format)}
         cleanupOutput.set(true)
         """.trimIndent()
 
     @Test(dataProvider = "gradle_version_provider")
-    fun `openApiGenerate should reuse configuration cache`(gradleVersion: String) {
+    fun `openApiGenerate should reuse configuration cache`(gradleVersion: String, format: String) {
+        val propertyFormat = PropertyFormat.valueOf(format)
         // Arrange
-        withProject(inputSpecExtensionContents)
+        withProject(inputSpecExtensionContents(propertyFormat))
 
         // Act
         val result1 = build {
@@ -69,13 +76,14 @@ class GenerateTaskConfigurationCacheTest : TestBase() {
     }
 
     @Test(dataProvider = "gradle_version_provider_without_cc")
-    fun `openApiGenerate should work with Gradle legacy versions`(gradleVersion: String) {
+    fun `openApiGenerate should work with Gradle legacy versions`(gradleVersion: String, format: String) {
+        val propertyFormat = PropertyFormat.valueOf(format)
         if(getJavaVersion() > 12) {
             // https://docs.gradle.org/current/userguide/compatibility.html
             throw SkipException("Skipping test as Gradle ${gradleVersion} is not compatible with Java ${getJavaVersion()}")
         }
         // Arrange
-        withProject(inputSpecExtensionContents)
+        withProject(inputSpecExtensionContents(propertyFormat))
 
         // Act
         val result1 = build {