Skip to content

Commit ece9cfe

Browse files
committed
fix #22492 [BUG][JAVA][MAVEN] Lombok @Getter disables validation and #19743 #18794 #17793 #17606
1 parent b4197ef commit ece9cfe

11 files changed

Lines changed: 28 additions & 182 deletions

File tree

modules/openapi-generator/src/main/resources/JavaSpring/lombokAnnotation.mustache

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,9 @@
1414
{{#isPassword}}
1515
@lombok.ToString.Exclude
1616
{{/isPassword}}
17-
{{#useBeanValidation}}{{>beanValidation}}{{/useBeanValidation}}
17+
{{^isContainer}}
18+
{{#useBeanValidation}}{{>beanValidation}}{{/useBeanValidation}}
19+
{{/isContainer}}
1820
{{^useBeanValidation}}
1921
{{#required}}
2022
@lombok.NonNull

samples/server/petstore/springboot-lombok-data/src/main/java/org/openapitools/api/PetApiController.java

Lines changed: 0 additions & 47 deletions
This file was deleted.

samples/server/petstore/springboot-lombok-data/src/main/java/org/openapitools/api/StoreApiController.java

Lines changed: 0 additions & 47 deletions
This file was deleted.

samples/server/petstore/springboot-lombok-data/src/main/java/org/openapitools/api/UserApiController.java

Lines changed: 0 additions & 47 deletions
This file was deleted.

samples/server/petstore/springboot-lombok-data/src/main/java/org/openapitools/model/Category.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@
2828
@Generated(value = "org.openapitools.codegen.languages.SpringCodegen", comments = "Generator version: 7.18.0-SNAPSHOT")
2929
public class Category {
3030

31-
31+
3232
@Schema(name = "id", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
3333
@JsonProperty("id")
3434
private @Nullable Long id;
3535

36-
@Pattern(regexp = "^[a-zA-Z0-9]+[a-zA-Z0-9\\.\\-_]*[a-zA-Z0-9]+$")
36+
@Pattern(regexp = "^[a-zA-Z0-9]+[a-zA-Z0-9\\.\\-_]*[a-zA-Z0-9]+$")
3737
@Schema(name = "name", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
3838
@JsonProperty("name")
3939
private @Nullable String name;

samples/server/petstore/springboot-lombok-data/src/main/java/org/openapitools/model/ModelApiResponse.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,17 @@
3030
@Generated(value = "org.openapitools.codegen.languages.SpringCodegen", comments = "Generator version: 7.18.0-SNAPSHOT")
3131
public class ModelApiResponse {
3232

33-
33+
3434
@Schema(name = "code", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
3535
@JsonProperty("code")
3636
private @Nullable Integer code;
3737

38-
38+
3939
@Schema(name = "type", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
4040
@JsonProperty("type")
4141
private @Nullable String type;
4242

43-
43+
4444
@Schema(name = "message", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
4545
@JsonProperty("message")
4646
private @Nullable String message;

samples/server/petstore/springboot-lombok-data/src/main/java/org/openapitools/model/Order.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,22 +31,22 @@
3131
@Generated(value = "org.openapitools.codegen.languages.SpringCodegen", comments = "Generator version: 7.18.0-SNAPSHOT")
3232
public class Order {
3333

34-
34+
3535
@Schema(name = "id", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
3636
@JsonProperty("id")
3737
private @Nullable Long id;
3838

39-
39+
4040
@Schema(name = "petId", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
4141
@JsonProperty("petId")
4242
private @Nullable Long petId;
4343

44-
44+
4545
@Schema(name = "quantity", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
4646
@JsonProperty("quantity")
4747
private @Nullable Integer quantity;
4848

49-
@Valid
49+
@Valid
5050
@Schema(name = "shipDate", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
5151
@JsonProperty("shipDate")
5252
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE_TIME)
@@ -89,12 +89,12 @@ public static StatusEnum fromValue(String value) {
8989
}
9090
}
9191

92-
92+
9393
@Schema(name = "status", description = "Order Status", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
9494
@JsonProperty("status")
9595
private @Nullable StatusEnum status;
9696

97-
97+
9898
@Schema(name = "complete", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
9999
@JsonProperty("complete")
100100
@lombok.Builder.Default

samples/server/petstore/springboot-lombok-data/src/main/java/org/openapitools/model/Pet.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,29 +34,27 @@
3434
@Generated(value = "org.openapitools.codegen.languages.SpringCodegen", comments = "Generator version: 7.18.0-SNAPSHOT")
3535
public class Pet {
3636

37-
37+
3838
@Schema(name = "id", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
3939
@JsonProperty("id")
4040
private @Nullable Long id;
4141

42-
@Valid
42+
@Valid
4343
@Schema(name = "category", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
4444
@JsonProperty("category")
4545
private @Nullable Category category;
4646

47-
@NotNull
47+
@NotNull
4848
@Schema(name = "name", example = "doggie", requiredMode = Schema.RequiredMode.REQUIRED)
4949
@JsonProperty("name")
5050
private String name;
5151

52-
@NotNull
5352
@Schema(name = "photoUrls", requiredMode = Schema.RequiredMode.REQUIRED)
5453
@JsonProperty("photoUrls")
5554
@lombok.Builder.Default
5655
@Valid
5756
private List<String> photoUrls = new ArrayList<>();
5857

59-
@Valid
6058
@Schema(name = "tags", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
6159
@JsonProperty("tags")
6260
@lombok.Builder.Default
@@ -100,7 +98,7 @@ public static StatusEnum fromValue(String value) {
10098
}
10199
}
102100

103-
101+
104102
@Schema(name = "status", description = "pet status in the store", deprecated = true, requiredMode = Schema.RequiredMode.NOT_REQUIRED)
105103
@JsonProperty("status")
106104
@Deprecated

samples/server/petstore/springboot-lombok-data/src/main/java/org/openapitools/model/Tag.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@
2828
@Generated(value = "org.openapitools.codegen.languages.SpringCodegen", comments = "Generator version: 7.18.0-SNAPSHOT")
2929
public class Tag {
3030

31-
31+
3232
@Schema(name = "id", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
3333
@JsonProperty("id")
3434
private @Nullable Long id;
3535

36-
36+
3737
@Schema(name = "name", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
3838
@JsonProperty("name")
3939
private @Nullable String name;

samples/server/petstore/springboot-lombok-data/src/main/java/org/openapitools/model/User.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,42 +28,42 @@
2828
@Generated(value = "org.openapitools.codegen.languages.SpringCodegen", comments = "Generator version: 7.18.0-SNAPSHOT")
2929
public class User {
3030

31-
31+
3232
@Schema(name = "id", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
3333
@JsonProperty("id")
3434
private @Nullable Long id;
3535

36-
36+
3737
@Schema(name = "username", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
3838
@JsonProperty("username")
3939
private @Nullable String username;
4040

41-
41+
4242
@Schema(name = "firstName", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
4343
@JsonProperty("firstName")
4444
private @Nullable String firstName;
4545

46-
46+
4747
@Schema(name = "lastName", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
4848
@JsonProperty("lastName")
4949
private @Nullable String lastName;
5050

51-
51+
5252
@Schema(name = "email", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
5353
@JsonProperty("email")
5454
private @Nullable String email;
5555

56-
56+
5757
@Schema(name = "password", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
5858
@JsonProperty("password")
5959
private @Nullable String password;
6060

61-
61+
6262
@Schema(name = "phone", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
6363
@JsonProperty("phone")
6464
private @Nullable String phone;
6565

66-
66+
6767
@Schema(name = "userStatus", description = "User Status", requiredMode = Schema.RequiredMode.NOT_REQUIRED)
6868
@JsonProperty("userStatus")
6969
private @Nullable Integer userStatus;

0 commit comments

Comments
 (0)