Merge branch 'willkg:normalize_path_fix'

Pull request #343, Issues #339 / #343

Author: IanLee1521

CHANGES.txt

@@ -22,6 +22,8 @@ Bug fixes:
 * Report E266 instead of E265 when the block comment starts with
   multiple ``#``. (Issue #270)
 
+* Strip whitespace from around paths during normalization. (Issue #339 / #343)
+
 
 1.5.7 (2014-05-29)
 ------------------

pep8.py

@@ -1156,10 +1156,13 @@ def normalize_paths(value, parent=os.curdir):
 
     Return a list of absolute paths.
     """
-    if not value or isinstance(value, list):
+    if not value:
+        return []
+    if isinstance(value, list):
         return value
     paths = []
     for path in value.split(','):
+        path = path.strip()
         if '/' in path:
             path = os.path.abspath(os.path.join(parent, path))
         paths.append(path.rstrip('/'))

testsuite/test_all.py

@@ -46,12 +46,13 @@ def test_own_dog_food(self):
 
 
 def suite():
-    from testsuite import test_api, test_shell
+    from testsuite import test_api, test_shell, test_util
 
     suite = unittest.TestSuite()
     suite.addTest(unittest.makeSuite(Pep8TestCase))
     suite.addTest(unittest.makeSuite(test_api.APITestCase))
     suite.addTest(unittest.makeSuite(test_shell.ShellTestCase))
+    suite.addTest(unittest.makeSuite(test_util.UtilTestCase))
     return suite
 
 

testsuite/test_util.py

@@ -0,0 +1,23 @@
+#!/usr/bin/env python
+# -*- coding: utf-8 -*-
+import os
+import unittest
+
+import pep8
+
+
+class UtilTestCase(unittest.TestCase):
+    def test_normalize_paths(self):
+        cwd = os.getcwd()
+
+        self.assertEquals(pep8.normalize_paths(''), [])
+        self.assertEquals(pep8.normalize_paths([]), [])
+        self.assertEquals(pep8.normalize_paths(None), [])
+        self.assertEquals(pep8.normalize_paths(['foo']), ['foo'])
+        self.assertEquals(pep8.normalize_paths('foo'), ['foo'])
+        self.assertEquals(pep8.normalize_paths('foo,bar'), ['foo', 'bar'])
+        self.assertEquals(pep8.normalize_paths('foo,  bar  '), ['foo', 'bar'])
+        self.assertEquals(pep8.normalize_paths('/foo/bar,baz/../bat'),
+                          ['/foo/bar', cwd + '/bat'])
+        self.assertEquals(pep8.normalize_paths(".pyc,\n   build/*"),
+                          ['.pyc', cwd + '/build/*'])