Do not skip physical checks if the newline is escaped; issue #319

Author: florentx

CHANGES.txt

@@ -43,6 +43,8 @@ Bug fixes:
 
 * Fix false positive E711/E712/E713. (Issues #330 and #336)
 
+* Do not skip physical checks if the newline is escaped. (Issue #319)
+
 
 1.5.7 (2014-05-29)
 ------------------

pep8.py

@@ -1238,14 +1238,12 @@ def filename_match(filename, patterns, default=True):
     return any(fnmatch(filename, pattern) for pattern in patterns)
 
 
+def _is_eol_token(token):
+    return token[0] in NEWLINE or token[4][token[3][1]:].lstrip() == '\\\n'
 if COMMENT_WITH_NL:
-    def _is_eol_token(token):
-        return (token[0] in NEWLINE or
-                (token[0] == tokenize.COMMENT and token[1] == token[4]))
-else:
-    def _is_eol_token(token):
-        return token[0] in NEWLINE
-
+    def _is_eol_token(token, _eol_token=_is_eol_token):
+        return _eol_token(token) or (token[0] == tokenize.COMMENT and
+                                     token[1] == token[4])
 
 ##############################################################################
 # Framework to run all checks

testsuite/E50.py

@@ -1,5 +1,19 @@
 #: E501
 a = '12345678901234567890123456789012345678901234567890123456789012345678901234567890'
+#: E501
+a = '1234567890123456789012345678901234567890123456789012345678901234567890' or \
+    6
+#: E501
+a = 7 or \
+    '1234567890123456789012345678901234567890123456789012345678901234567890' or \
+    6
+#: E501 E501
+a = 7 or \
+    '1234567890123456789012345678901234567890123456789012345678901234567890' or \
+    '1234567890123456789012345678901234567890123456789012345678901234567890' or \
+    6
+#: E501
+a = '1234567890123456789012345678901234567890123456789012345678901234567890'  # \
 #: E502
 a = ('123456789012345678901234567890123456789012345678901234567890123456789'  \
      '01234567890')

testsuite/W19.py

@@ -86,7 +86,7 @@ def long_function_name(
     b == """abc def ghi
 jkl mno"""):
 	return True
-#: E101 W191
+#: W191:2:1 W191:3:1 E101:3:2
 if length > options.max_line_length:
 	return options.max_line_length, \
 	    "E501 line too long (%d characters)" % length